Commit 17a18940 authored by Nate Graham's avatar Nate Graham
Browse files

applets/systemtray: fix glitch for some applets with headers

PlasmoidPopupsContainer.qml has special code to handle merging headers
from applets if those applets use a PlasmaComponents3.Page instance as
their FullRepresentation. However this breaks for any applets that use
PlasmaExtras.Representation, which is a subclass of it that we have been
porting applets to over time, because it offers more features in a
single location. This caused the detection to break, so such applets
woudl have their headers improperly merged.

Explicitly detecting the use of PlasmaExtras.Representation as well
fixes it.

BUG: 438178
FIXED-IN: 5.24

(cherry picked from commit 7221ffd1)
parent 0ae79512
Pipeline #125758 failed with stage
in 24 seconds
......@@ -42,7 +42,8 @@ StackView {
activeApplet.fullRepresentationItem.anchors.centerIn = undefined;
activeApplet.fullRepresentationItem.anchors.fill = undefined;
if (activeApplet.fullRepresentationItem instanceof PlasmaComponents3.Page) {
if (activeApplet.fullRepresentationItem instanceof PlasmaComponents3.Page ||
activeApplet.fullRepresentationItem instanceof PlasmaExtras.Representation) {
if (activeApplet.fullRepresentationItem.header && activeApplet.fullRepresentationItem.header instanceof PlasmaExtras.PlasmoidHeading) {
mainStack.appletHasHeading = true
activeApplet.fullRepresentationItem.header.background.visible = false
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment