Commit 20c24e02 authored by Nate Graham's avatar Nate Graham
Browse files

kcms/colors: fix spacing between radio buttons and content

Both had excessive spacing, and they were also not consistent with one
parent d32073e2
Pipeline #146501 failed with stage
in 8 minutes and 43 seconds
......@@ -142,7 +142,6 @@ KCM.GridViewKCM {
Kirigami.FormData.label: i18n("Use accent color:")
text: i18n("From current color scheme")
leftPadding: Kirigami.Units.largeSpacing
checked: Qt.colorEqual(kcm.accentColor, "transparent")
onToggled: {
......@@ -152,9 +151,12 @@ KCM.GridViewKCM {
RowLayout {
id: accentColorButtonsLayout
spacing: Kirigami.Units.smallSpacing
QtControls.RadioButton {
id: accentBox
checked: !Qt.colorEqual(kcm.accentColor, "transparent")
rightPadding: -accentColorButtonsLayout.spacing
onToggled: {
if (enabled) {
  • mentioned in commit d7469d57

    Toggle commit list
  • Was there a MR?

    Negative margins are a sign of doing something very wrong. Please revert asap.

  • Yeah my bad, it seemed obvious at the time but that's probably not ideal. Here's a fixup MR: !1534 (merged)

Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment