Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Plasma
Plasma Workspace
Commits
2a8670ab
Verified
Commit
2a8670ab
authored
Apr 21, 2022
by
Fushan Wen
Browse files
libtaskmanager: Port to `std::accumulate`
Fixes "Consider using std::accumulate algorithm instead of a raw loop."
parent
ff834fc9
Pipeline
#166176
passed with stage
in 5 minutes and 44 seconds
Changes
1
Pipelines
3
Hide whitespace changes
Inline
Side-by-side
libtaskmanager/tasksmodel.cpp
View file @
2a8670ab
...
...
@@ -893,24 +893,15 @@ bool TasksModel::Private::lessThan(const QModelIndex &left, const QModelIndex &r
// activity. This will sort tasks by comparing a cumulative score made
// up of the task counts for each activity a task is assigned to, and
// otherwise fall through to alphabetical sorting.
int
leftScore
=
-
1
;
int
rightScore
=
-
1
;
const
QStringList
&
leftActivities
=
left
.
data
(
AbstractTasksModel
::
Activities
).
toStringList
();
if
(
!
leftActivities
.
isEmpty
())
{
foreach
(
const
QString
&
activity
,
leftActivities
)
{
leftScore
+=
activityTaskCounts
[
activity
];
}
}
int
leftScore
=
std
::
accumulate
(
leftActivities
.
cbegin
(),
leftActivities
.
cend
(),
-
1
,
[
this
](
int
a
,
const
QString
&
activity
)
{
return
a
+
activityTaskCounts
[
activity
];
});
const
QStringList
&
rightActivities
=
right
.
data
(
AbstractTasksModel
::
Activities
).
toStringList
();
if
(
!
rightActivities
.
isEmpty
())
{
foreach
(
const
QString
&
activity
,
rightActivities
)
{
rightScore
+=
activityTaskCounts
[
activity
];
}
}
int
rightScore
=
std
::
accumulate
(
rightActivities
.
cbegin
(),
rightActivities
.
cend
(),
-
1
,
[
this
](
int
a
,
const
QString
&
activity
)
{
return
a
+
activityTaskCounts
[
activity
];
});
if
(
leftScore
==
-
1
||
rightScore
==
-
1
)
{
const
int
sumScore
=
std
::
accumulate
(
activityTaskCounts
.
constBegin
(),
activityTaskCounts
.
constEnd
(),
0
);
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment