Commit 3f612a31 authored by Nate Graham's avatar Nate Graham
Browse files

Only accept press-and-hold to enter Edit Mode, not click-and-hold

Press-and-hold is fairly common on touch UIs, but click-and-hold is a
very rare interaction. As a result, the user is much more likely to
enter Edit Mode accidentally while trying to drag something on the
desktop than they are to know that click-and-hold works here and do
it intentionally.

Let's disable click-and-hold and only enter Edit Mode with a
press-and-hold using a touch device. For pointing device users, there
are already multiple context menus items that will let them enter Edit
Mode.

BUG: 457979
FIXED-IN: 5.26
parent 0e063913
Pipeline #221177 passed with stage
in 8 minutes and 39 seconds
......@@ -597,6 +597,12 @@ void AppletsLayout::mousePressEvent(QMouseEvent *event)
{
forceActiveFocus(Qt::MouseFocusReason);
// Only accept synthesized events i.e. touch events, because we only want
// to support press-and-hold. Click-and-hold is weird. See 457979.
if (!(event->source() == Qt::MouseEventSynthesizedBySystem || event->source() == Qt::MouseEventSynthesizedByQt)) {
return;
}
if (!m_editMode && m_editModeCondition == AppletsLayout::Manual) {
return;
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment