Verified Commit 3ff3cea1 authored by Fushan Wen's avatar Fushan Wen 💬
Browse files

shell/scripting: don't set formFactor again

The formFactor has been set, either by `ShellCorona::addPanel` or the
ctor of `ContainmentPrivate::ContainmentPrivate`, so it's redundant to
set the default value here again, or the panel will be added to the top
edge again and again.
parent 9e1cfd57
......@@ -396,9 +396,6 @@ Plasma::Containment *ScriptEngine::createContainment(const QString &type, const
if (c) {
if (type == QLatin1String("Panel")) {
// some defaults
c->setFormFactor(Plasma::Types::Horizontal);
c->setLocation(Plasma::Types::TopEdge);
// we have to force lastScreen of the newly created containment,
// or it won't have a screen yet at that point, breaking JS code
// that relies on it
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment