Fix some clazy warnings

applets/appmenu/plugin/appmenumodel.cpp

@@ -40,8 +40,8 @@ protected:
 
 AppMenuModel::AppMenuModel(QObject *parent)
     : QAbstractListModel(parent)
-    , m_serviceWatcher(new QDBusServiceWatcher(this))
     , m_tasksModel(new TaskManager::TasksModel(this))
+    , m_serviceWatcher(new QDBusServiceWatcher(this))
 {
     m_tasksModel->setFilterByScreen(true);
     connect(m_tasksModel, &TaskManager::TasksModel::activeTaskChanged, this, &AppMenuModel::onActiveWindowChanged);

applets/digital-clock/plugin/clipboardmenu.cpp

@@ -37,7 +37,7 @@ bool ClipboardMenu::secondsIncluded() const
     return m_secondsIncluded;
 }
 
-void ClipboardMenu::setSecondsIncluded(const bool &secondsIncluded)
+void ClipboardMenu::setSecondsIncluded(bool secondsIncluded)
 {
     if (m_secondsIncluded != secondsIncluded) {
         m_secondsIncluded = secondsIncluded;

applets/digital-clock/plugin/clipboardmenu.h

@@ -26,7 +26,7 @@ public:
     void setCurrentDate(const QDateTime &date);
 
     bool secondsIncluded() const;
-    void setSecondsIncluded(const bool &secondsIncluded);
+    void setSecondsIncluded(bool secondsIncluded);
 
     Q_INVOKABLE void setupMenu(QAction *action);
 

applets/panelspacer/plugin/panelspacer.h

@@ -21,7 +21,7 @@ class SpacersTracker : public QObject
     Q_OBJECT
 
 public:
-    SpacersTracker(QObject *parent = nullptr);
+    explicit SpacersTracker(QObject *parent = nullptr);
     ~SpacersTracker() override;
 
     static SpacersTracker *self();

dataengines/apps/appsource.cpp

@@ -10,7 +10,7 @@
 
 #include <QDebug>
 
-AppSource::AppSource(KServiceGroup::Ptr group, QObject *parent)
+AppSource::AppSource(const KServiceGroup::Ptr &group, QObject *parent)
     : Plasma::DataContainer(parent)
     , m_group(group)
     , m_app()
@@ -21,7 +21,7 @@ AppSource::AppSource(KServiceGroup::Ptr group, QObject *parent)
     updateGroup();
 }
 
-AppSource::AppSource(KService::Ptr app, QObject *parent)
+AppSource::AppSource(const KService::Ptr &app, QObject *parent)
     : Plasma::DataContainer(parent)
     , m_group()
     , m_app(app)

dataengines/apps/appsource.h

@@ -20,8 +20,8 @@ class AppSource : public Plasma::DataContainer
     Q_OBJECT
 
 public:
-    AppSource(KServiceGroup::Ptr startup, QObject *parent);
-    AppSource(KService::Ptr app, QObject *parent);
+    AppSource(const KServiceGroup::Ptr &startup, QObject *parent);
+    AppSource(const KService::Ptr &app, QObject *parent);
     ~AppSource() override;
 
 protected:

dataengines/devicenotifications/ksolidnotify.cpp

@@ -173,7 +173,7 @@ void KSolidNotify::onSolidReply(SolidReplyType type, Solid::ErrorType error, con
 
             if (type == SolidReplyType::Eject) {
                 QString discUdi;
-                for (Solid::Device device : qAsConst(m_devices)) {
+                for (const Solid::Device &device : qAsConst(m_devices)) {
                     if (device.parentUdi() == udi) {
                         discUdi = device.udi();
                     }