Commit 5fbe1eab authored by Laurent Montel's avatar Laurent Montel
Browse files

Fix some clazy warnings

parent c2c3a2d6
Pipeline #149820 passed with stage
in 8 minutes and 29 seconds
......@@ -40,8 +40,8 @@ protected:
AppMenuModel::AppMenuModel(QObject *parent)
: QAbstractListModel(parent)
, m_serviceWatcher(new QDBusServiceWatcher(this))
, m_tasksModel(new TaskManager::TasksModel(this))
, m_serviceWatcher(new QDBusServiceWatcher(this))
{
m_tasksModel->setFilterByScreen(true);
connect(m_tasksModel, &TaskManager::TasksModel::activeTaskChanged, this, &AppMenuModel::onActiveWindowChanged);
......
......@@ -37,7 +37,7 @@ bool ClipboardMenu::secondsIncluded() const
return m_secondsIncluded;
}
void ClipboardMenu::setSecondsIncluded(const bool &secondsIncluded)
void ClipboardMenu::setSecondsIncluded(bool secondsIncluded)
{
if (m_secondsIncluded != secondsIncluded) {
m_secondsIncluded = secondsIncluded;
......
......@@ -26,7 +26,7 @@ public:
void setCurrentDate(const QDateTime &date);
bool secondsIncluded() const;
void setSecondsIncluded(const bool &secondsIncluded);
void setSecondsIncluded(bool secondsIncluded);
Q_INVOKABLE void setupMenu(QAction *action);
......
......@@ -21,7 +21,7 @@ class SpacersTracker : public QObject
Q_OBJECT
public:
SpacersTracker(QObject *parent = nullptr);
explicit SpacersTracker(QObject *parent = nullptr);
~SpacersTracker() override;
static SpacersTracker *self();
......
......@@ -10,7 +10,7 @@
#include <QDebug>
AppSource::AppSource(KServiceGroup::Ptr group, QObject *parent)
AppSource::AppSource(const KServiceGroup::Ptr &group, QObject *parent)
: Plasma::DataContainer(parent)
, m_group(group)
, m_app()
......@@ -21,7 +21,7 @@ AppSource::AppSource(KServiceGroup::Ptr group, QObject *parent)
updateGroup();
}
AppSource::AppSource(KService::Ptr app, QObject *parent)
AppSource::AppSource(const KService::Ptr &app, QObject *parent)
: Plasma::DataContainer(parent)
, m_group()
, m_app(app)
......
......@@ -20,8 +20,8 @@ class AppSource : public Plasma::DataContainer
Q_OBJECT
public:
AppSource(KServiceGroup::Ptr startup, QObject *parent);
AppSource(KService::Ptr app, QObject *parent);
AppSource(const KServiceGroup::Ptr &startup, QObject *parent);
AppSource(const KService::Ptr &app, QObject *parent);
~AppSource() override;
protected:
......
......@@ -173,7 +173,7 @@ void KSolidNotify::onSolidReply(SolidReplyType type, Solid::ErrorType error, con
if (type == SolidReplyType::Eject) {
QString discUdi;
for (Solid::Device device : qAsConst(m_devices)) {
for (const Solid::Device &device : qAsConst(m_devices)) {
if (device.parentUdi() == udi) {
discUdi = device.udi();
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment