Commit c4a3a4e5 authored by Nate Graham's avatar Nate Graham
Browse files

Revert "[lookandfeel] Fix wake existing screensaver mode with key presses"

This reverts commit 13057013.

That commit set the cursorVisible: propety to true. However that
property only exists in the QtQuickControls 2 TextField, not the QQC1
version. We ported the lock screen to PlasmaComponents3 (which
internally uses QQC2) after Plasma 5.18, meaning that in the LTS
version, we still have a QQC1 TextField so this property does not exist.
Trying to set it causes a runtime error and breaks the lock screen.

BUG: 435233
FIXED-IN: 5.18.7.1
parent fc52a248
......@@ -229,6 +229,9 @@ PlasmaCore.ColorScope {
// this isn't implicit, otherwise items still get processed for the scenegraph
visible: opacity > 0
// changing enabled will toggle if an item can have activeFocus, which otherwise
//keeps the text cursor blinking even when invisble
enabled: visible
initialItem: MainBlock {
id: mainBlock
......
......@@ -66,12 +66,6 @@ SessionManagementScreen {
enabled: !authenticator.graceLocked
revealPasswordButtonShown: true
// In Qt this is implicitly active based on focus rather than visibility
// in any other application having a focussed invisible object would be weird
// but here we are using to wake out of screensaver mode
// We need to explicitly disable cursor flashing to avoid unnecessary renders
cursorVisible: visible
onAccepted: {
if (lockScreenUiVisible) {
startLogin();
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment