Enable the apply button after:

1. Drag and drop
2. Add an image using the file dialog
3. Delete an image that is not the currently selected one

Fushan Wen authored May 31, 2022 and Nate Graham committed Jun 02, 2022

FEATURE: 403384
FIXED-IN: 5.26

This ports from units.* to PlasmaCore.Units.* and theme.* to
PlasmaCore.Theme.*

This begins the process of porting plasma-workspace to PlasmaComponents3. At
this point, only the relatively easy work is done. Every file not ported
now has been given the reason for still using PC2 in a comment on the import
line so you can see at a glance what the blocker is by running
`grep -r "org.kde.plasma.components 2.0"` in the repo.

Everything is tested and there are no breakages or functional regressions. In
the process, a few unused imports are removed.

Here are the remaining PC3 omissions blocking what's left from getting easily
ported:
- No Highlight
- No ListItem
- No PageStack
- No ContextMenu
- No QueryDialog
- No ModelContextMenu
- TabBar has no left and right tab states
- ToolButton has no built-in method to show a menu when clicked

David Edmundson authored Jun 29, 2020 and Nate Graham committed Jul 01, 2020

If a user selects a wallpaper from a package we want to save the package
name, not a path.

This means we continue to load the correct resolution image if a screen
size (or scale) changes at runtime.


(cherry picked from commit 530b36ab)

David Edmundson authored Jun 29, 2020 and Nate Graham committed Jul 01, 2020

If a user selects a wallpaper from a package we want to save the package
name, not a path.

This means we continue to load the correct resolution image if a screen
size (or scale) changes at runtime.

If we have this feature now, let's use it and give the wallpaper authors the credit they deserve rather than being tucked away in the tooltip.

Differential Revision: https://phabricator.kde.org/D26531

Summary:
This is full of mixed bindings/signal handlers for properties and of
broken references in here!

There's likely more to do, but those were the most obvious ones when
working on the screenlocker KCM.

Reviewers: #plasma, mart, davidedmundson, crossi, bport

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25567

Summary:
Allows setting of other sorting orders like alphabetical or last modified date.
To enable this a new ProxyModel is introduced which handles the sorting and
filtering (as indicated by the checkboxes). This is backed by the slideshowModel
whcih previously as only used for the configutation. The lists of slides and  unseen
slides are dropped as now the slides that are shown are taken from the model.

FEATURE: 186181
FIXED-IN: 5.17.0

Test Plan:
{F6938259}
{F6938260}
{F6938261}
{F6938263}

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22121

David Redondo authored Apr 01, 2019 and Nate Graham committed Apr 01, 2019

Summary:
This allows to exlude single images from the slideshow by unchecking the little checkbox in the top right corner.
Feature or todo?: If a folder is removed I don't touch the unchecked Slides. So the list could get very big but if a formerly removed folder is
added again an excluded image will be excluded again.

Test Plan:
{F6684113}
- Uncheck some images
- They don't appear in the slideshow

Reviewers: #plasma, #vdg, ngraham, davidedmundson

Reviewed By: #plasma, #vdg, ngraham, davidedmundson

Subscribers: davidedmundson, filipf, abetts, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19687

David Redondo authored Mar 09, 2019 and Nate Graham committed Mar 09, 2019

Summary:
This shows all the pictures inside the folders added to the Folders list. I also tried to make single pictures excludable via a checkbox on the thumbnail. This is the first time for me programming with QT/QML/Singals-Slots and I tried to use as much existing code as possible. The thumbnail view is the same as for single images and I simply subclassed the listmodel. However even if I tried to do everything like the code for slidePaths it doesn't work correctly. The checking/unchecking of images only applies on restart of plasmashell. Maybe it's a single mistake that is easily spotted by a more experienced programmer otherwise if the thumbnail view is accepted I can also revert all the checkbox stuff.

FEATURE: 403703
FIXED-IN: 5.16.0

{F6595564}

Reviewers: #vdg, ngraham, davidedmundson

Reviewed By: #vdg, ngraham, davidedmundson

Subscribers: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18809

Summary:
This patch makes the wallpaper chooser grid view delegates show the wallpaper's
title (if it has a desktop file) or filename (if it doesn't). Authorship information
is shown via a tooltip, if present.

Test Plan:
{F6587535, size=full}
{F6587536, size=full}

Reviewers: #vdg, #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18737

Summary:
update the wallpaper dialog to the same design as the new KCMS
for consistency

Test Plan:
dialog loads with proper wallpaper selected, and both clicking on one
works and the attached toolbuttons work too

Reviewers: #plasma, #vdg, davidedmundson, broulik

Reviewed By: #plasma, broulik

Subscribers: davidedmundson, broulik, abetts, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12148

Summary:
The wallpaper loading code expects the catalogs to follow the pattern
"plasma_wallpaper_" + pluginid. While in config QML the domain needs
to be explicitly set using i18nd, as the default textdomain is set to
that of the config container, it is not needed in the wallpaper QML.

While using a catalog with plasma_applet_* prefix works if setting
the domain explicitly, the usage goes against the design of the
naming patterns. So to give a good example and also properly marking
the usage of the catalog, the names are switched.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10850

The delete button changes the currentIndex to something else when deleting the current image but that didn't update cfg_Image.
Just listen to when we become current. Might also fix keyboard navigation (didn't test if that worked before but it certainly does now).

BUG: 388805

Differential Revision: https://phabricator.kde.org/D9818

This allows to open the location of the folder the wallpaper is in.

BUG: 371247
FIXED-IN: 5.11.0

Differential Revision: https://phabricator.kde.org/D6450

Summary:
Currently the we create previews with QPixmapItem from KDeclrarative and
when a wallpaper is set to centered sets it to an enum value that
doesn't exist.

PreserveAspectFit displays the wallpaper in the correct proportions as
when it will be applied, but will still be big enough to make it
actually previewable.

BUG: 375675

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4840

Summary:
select the correct index upon loading when the count changes.
this removes the flicker at startup and the view is at the correct
wallpaper since the first frame. Also, now when a wallpaper is
downloaded with knewstuff, the old wallpaper stays selected,
it doesn't get resetted to the first wallpaper anymore

Test Plan:
open wallpaer dialog, no more flicker
install a new wallpaper, the currently selected one stays selected

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3532

BUG:350414

REVIEW: 123211
BUG: 338729

If there are no metadata, showing "by Unknown" is a bit strange and
serves not much purpose. So let it show only the filename when no
metadata available.

REVIEW: 122622

Reflect that in the settings in case somebody uses an image with alpha-channel,
although we don't really support/encourage that, do we?

The GridView needs to receive focus for keyboard navigation. Also, make
sure that we're not changing the current wallpaper on deselection, this
might happen when the currentIndex is changed through the keyboard.

The parent item has opacity == 0.8, which means both the preview icon
and the actual preview are sligtly transparent and the icon bleeds
through; let's hide it completely

BUG: 339628
Reviewed-by: Bhushan Shah

This produces a warning, from the looks of it it's a left-over from a
different time/space continuum, and I wouldn't know why it should be
needed with the other anchors in place. Kill it with fire.

BUG:337313