Summary:
The return code of the Pool::load() method is somewhat misleading, as it
returns true only if there were no errors at all. The error flag is set on the first
validation error, but the pool will contain meaningful data nevertheless.

BUG: 397531

Test Plan:
Searching for "blend"
Unfixed version:
No results are returned under "Software Center"
Fixed version:
Software Center: "Get Blender", "Get Hugin", ...

Reviewers: #plasma, #frameworks, apol

Reviewed By: apol

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14807

Robert Hoffmann authored Aug 31, 2018 and Nate Graham committed Aug 31, 2018

Summary:
If a user logged in with one screen connected plugs in
a second screen, which becomes the new primary screen,
this screen would stay black or behave weird.

Unplugging the screen again would mess up plasmashell.

Added to ScreenPool::setPrimaryConnector():
In the case primary output changed m_idForConnector
doesn't contain the new primary, so a screen mapping
is created for it.

Test Plan:
Testing on virtualbox or vmware player seems impossible, because
these don't allow disabling the first display (VGA-1) and booting
with the second (VGA-2) only.

1. Boot machine with one screen connected to HDMI-3 (primary output).
2. Log in
3. Plug in second screen to HDMI-2:
--> primary output changes from HDMI-3 to HDMI-2
4. OSD appears: extend to right
--> Without this patch, the new screen (HDMI-2) would stay blank.
--> With this patch applied, the screen content moves to the new
   second screen.

5. Unplug second screen (HDMI-2)
--> Without this patch, the background would get black, control panel
   would disappear, could only be restored by restart of plasmashell
--> With this patch applied, screen content moves to the right and
   works

Reviewers: #plasma, mart, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13853

Summary:
Slideshow wallpapers use the same Blur/Color selector that single image
wallpapers use.  However, the Blur config entry was added to the image
xml but not the slideshow xml.  The result was that the selection was
never persisted and reverted to the default on restart.  This allows the
slideshow blur config to persist.

Test Plan:
Configure the desktop backgrounds.
Select slideshow with one or more images that are smaller than the screen.
Choose fill with solid color.  Apply and exit.
Note that the background fill takes on the solid color
Restart
Note that the background fill is still the solid color
Configure desktop background
Choose fill with blur.  Apply and exit
Note that the background fill is a blur
Restart
Note that the background fill is still a blur.

Reviewers: #plasma_workspaces, davidedmundson

Reviewed By: #plasma_workspaces, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13555

The entry is only shown when run standalone anyway.

Differential Revision: https://phabricator.kde.org/D14487

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

All the information we need (player capabilities and playback status) is already present and managed by the PlayerContainer

BUG: 397685
FIXED-IN: 5.13.5

Differential Revision: https://phabricator.kde.org/D14970

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
If a slot or Q_INVOKABLE has a QVariant as parameter and gets called
from a QJSEngine's script, it receives a QJSValue wrapped as QVariant.
To get a QVariant with the actual value wrapped, calling QJSValue::toVariant
is necessary.

I'm not entirely sure whether this is intentional behaviour of QJSEngine, but
even if it's a bug we'll have to workaround it.

BUG: 397338

Test Plan: I have favorites in kickoff again.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14822

There is always one...

Since we have a unified screen for logging out and shutting down, the hint is always shown as the user could click on "Logout"
but then shut down anyway.

Differential Revision: https://phabricator.kde.org/D14905

Karthik Periagaram authored Aug 17, 2018 and Kai Uwe Broulik committed Aug 17, 2018

If a destination file name is present, it is a better label for a job
than the source file name. This is particularly true for web downloads
where the source file name may be a gibberish base64 string while the
destination file name would be selected by the user.

If there is no destination file name, we fall back to using the source
file name.

BUG: 396744

Differential Revision: https://phabricator.kde.org/D14857

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

It takes almost 30ms here to create the engine and then we usually don't end up using
it as all update scripts had already been processed in the past.

Differential Revision: https://phabricator.kde.org/D14751

This might trigger automounting of devices.

CCBUG: 355258

Differential Revision: https://phabricator.kde.org/D14532

On teardown with the popup expanded, the cleanup handler might fire with us already having been deleted.

BUG: 397105
FIXED-IN: 5.12.7

Differential Revision: https://phabricator.kde.org/D14651

For KCMs we get a relative entryPath() for our KService resulting in an invalid URL being created.

CCBUG: 397070

Differential Revision: https://phabricator.kde.org/D14546

They were missing in a couple of places leading to crashes.

Differential Revision: https://phabricator.kde.org/D14576

BUG: 397087
FIXED-IN: 5.13.5

Differential Revision: https://phabricator.kde.org/D14556

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: The Qt bug that makes `Text.NativeRendering` look terrible with non-integer scale factors (https://bugreports.qt.io/browse/QTBUG-67007) is still a problem, so we need to apply the same workaround here that we previously applied to all the PlasmaComponents.

Test Plan:
No visual change at 1x scale. Looks much better at 1.5x scale.

1.5x scale, before:
{F6136688}

1.5x scale, after:
{F6136691}

Reviewers: #plasma, davidedmundson, broulik

Reviewed By: #plasma, davidedmundson, broulik

Subscribers: broulik, svenmauch, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14347