1. 30 Dec, 2021 1 commit
  2. 14 Aug, 2021 1 commit
  3. 09 Aug, 2021 2 commits
  4. 27 Jul, 2021 1 commit
  5. 13 May, 2021 1 commit
  6. 04 May, 2021 1 commit
  7. 25 Mar, 2021 1 commit
  8. 12 Mar, 2021 1 commit
  9. 07 Nov, 2020 1 commit
    • Konrad Materka's avatar
      [applets/systemtray] Rework of "expanded" state handling · 04112536
      Konrad Materka authored
      Refactor and simply logic of "expanded" state when dialog with active applet or list of hidden applets is shown.
      
      Fixes a problem with keyboard shortcut activation.
      It also fixes a bug when dialog closes on "go-back" button click.
      
      BUG: 427685
      FIXED-IN: 5.21
      CCBUG: 400278
      04112536
  10. 25 Oct, 2020 2 commits
  11. 24 Oct, 2020 1 commit
  12. 16 Oct, 2020 1 commit
  13. 08 Oct, 2020 1 commit
  14. 06 Oct, 2020 1 commit
  15. 02 Oct, 2020 1 commit
  16. 28 Sep, 2020 1 commit
  17. 25 Sep, 2020 1 commit
  18. 11 Aug, 2020 1 commit
  19. 07 Aug, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Return to pre-5.20 default panel icon arrangement · 394b0ca0
      Nate Graham authored
      After much much much VDG discussion, it turned out that we don't
      actually want to make the System Tray icons scale with the panel. We
      returned to that with 31c7ebe3, but one
      element remained: to make the icons automatically become a
      two/row/column layout for thick panels, as we had for Plasma 5.19 and
      earlier. This commit does that, and in the process simplifies the
      configuration UI to show only the two options that we decided make sense:
      
      1. Small icons that become two-row/column for thick panels
      2. Auto-sizing icons that match the size of other panel widgets
      
      Number one returns to being the default as it was before, and number two
      is available for people/themes that want all icons to match in size.
      394b0ca0
  20. 30 Jul, 2020 2 commits
  21. 29 Jul, 2020 2 commits
  22. 16 Jul, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Improve size options · 4db4eab5
      Nate Graham authored
      Currently in git master there are three options for Tray icon sizing/arrangement:
      1. Scale to fit + automatic number of rows/columns
      2. One auto-scaling row/column
      3. Two auto-scaling rows/columns
      
      After consultation with VDG folks and many discussions, we discovered that the
      latter two settings are kind of useless and are unlikely to satisfy anyone.
      Instead, what some people will actually want is a way to return to the pre-Plasma
      5.20 style, with one or two rows/columns of small-ish, fixed size icons.
      
      This commit changes those two options to provide exactly that, allowing people who
      don't like auto-scaling icons to return to the way their System Tray looked before
      Plasma 5.20, and can also be used for global themes which are trying to emulate
      Windows or Cinnamon, which have tray icons like this.
      4db4eab5
  23. 14 Jul, 2020 1 commit
  24. 09 Jul, 2020 1 commit
    • Nate Graham's avatar
      [System Tray] Auto-scale icons and expose setting for number of rows/columns · 55ae651a
      Nate Graham authored
      Before Plasma 5.20, the system tray icons were always 22px in size and became
      multi-row/multi column as the panel increased in thickness.
      
      So far in the Plasma 5.20 development cycle, we have exposed the existing
      `iconSize` setting to the user to allow them to determine for themselves how
      big they want the icon to be, or whether to be multi-row/column.
      
      However this is not exposed very intuitively, as you have to already know that
      the icon size determines the number of rows/columns, or that the largest "Enormous"
      size produces an auto-scaling icon behavior. In other words, the UI reflects the
      implementation, rather than the user's expectation.
      
      This commit changes around the UI to more closely approximate what the user is
      likely to want to configure: the number of rows/columns. The new default setting
      is an "automatic" mode, which approximates the 5.19 and earlier behavior whereby
      the system tray switches to a two-row/column view when the panel becomes thick
      enough. In addition, users can now force it to always display one or two rows/
      columns.
      
      A major difference is that no matter which setting is set, icons now always
      expand to fill the available space, which brings them in line with the margins
      used for other Panel widgets.
      55ae651a
  25. 16 Jun, 2020 1 commit
  26. 15 Jun, 2020 1 commit
    • Michail Vourlakos's avatar
      systemtray items respect Fitt's Law when in panel · fd78da89
      Michail Vourlakos authored and Nate Graham's avatar Nate Graham committed
      --systemtray items are now using a rectangular form
      in order to specify their hit area. So they take into
      account the panel thickness in order to calculate
      properly their cell length and thickness to
      respect Fitt's Law. Items that are nearer to the
      screen edge can now trigger all their events when
      the user uses its mouse at the farest of the screen edge.
      fd78da89
  27. 10 Jun, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Use a grid for the hidden items view · 1669197b
      Nate Graham authored
      This improves the applet in a variety of ways:
      - Much more touch friendly than the current skinny list view
      - Many more items can be displayed without needing to scroll
      - Substantial code simplification
      - UI improvement from no longer sometimes showing an awkward vertical
        strip of icons that was invisibly scrollable but some of whose items
        ate scroll events, and which pushed the header over to the left in a
        somewhat random-looking way
      
      BUG: 402681
      FIXED-IN: 5.20
      1669197b
  28. 29 May, 2020 1 commit
  29. 03 May, 2020 1 commit
  30. 01 May, 2020 1 commit
  31. 01 Apr, 2020 1 commit
  32. 31 Mar, 2020 1 commit
    • Eugene Popov's avatar
      [applets/clipboard]: Fix applet closing itself when clicking on a history item... · 17542416
      Eugene Popov authored and Nate Graham's avatar Nate Graham committed
      [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open
      
      Summary:
      When I pin a Klipper widget and then click on a history item, the Klipper widget closes.
      
      To fix this bug, we need to check if Klipped is pinned, but to be able to do this, we also need to "forward" the pinned state from the SystemTray applet to the Klipper applet.
      
      BUG: 416510
      FIXED-IN: 5.19.0
      
      Reviewers: ngraham, #plasma
      
      Reviewed By: ngraham
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28408
      17542416
  33. 24 Mar, 2020 1 commit
    • Konrad Materka's avatar
      [applets/systemtray] Simplify icon size logic · a9d941b3
      Konrad Materka authored
      Summary: This change simplifies icon size logic - now it is controled only in one place: AbstractItem. This gives additional benefits, like icons perfectly centered.
      
      Test Plan: Highlights should always be centered
      
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, apol
      
      Reviewed By: #plasma_workspaces, #plasma, ngraham, broulik
      
      Subscribers: mart, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28109
      a9d941b3
  34. 10 Mar, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Fix item size for very narrow panel · 85f646eb
      Konrad Materka authored
      Summary:
      For very narrow panel item size is too big (item + padding exceed panel size). This adds a check to not exceed panel size.
      Before:
      {F8167941}
      After:
      {F8167942}
      
      Test Plan:
      * Make panel very narrow - icons should fit into panel
      * Repeat for vertical/horizontal
      
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27958
      85f646eb
  35. 08 Mar, 2020 1 commit
    • Dominic Hayes's avatar
      Increase the size of system tray icon hitboxes on the System Tray Plasmoid · d1d76984
      Dominic Hayes authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Depends on D27465
      
      @ngraham recommended that I split up https://phabricator.kde.org/D27438 into three patches:
      
      1. The foundation code to get landed first so that the other two patches can be done as patches that change two separate lines instead of just one
      
      2. Tablet Mode increases tray icon spacing
      
      3. This patch - Increase tray icon spacing slightly on Non-Tablet Mode (half of the amount it increases by in Tablet Mode)
      
      This patch is for the third patch of the three recommended patches to split the original patch into, and makes the click areas for the System Tray Plasmoid slightly larger in normal Plasma.
      
      Test Plan:
      1. Install this patch to the System Tray Plasmoid
      
      BEFORE:
      {F8109485}
      
      AFTER:
      {F8109489}
      
      Reviewers: #vdg, niccolove, ngraham
      
      Reviewed By: #vdg, niccolove, ngraham
      
      Subscribers: kmaterka, gvgeo, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27466
      d1d76984
  36. 07 Mar, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Use unified data model everywhere · 39975673
      Konrad Materka authored
      Summary:
      Use the unified data model everywhere, not just in configuration. This simplifies UI code, separetes presentation from data.
      This requires the use of ListView and GridView.
      This change enables the implementation of more advanced sorting algorithms for systemtray items.
      
      Test Plan: Affects almost all areas of system tray.
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
      
      Reviewed By: #plasma_workspaces, #plasma, davidedmundson, ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26992
      39975673