Konrad Materka authored Oct 10, 2019 and Nate Graham committed Oct 10, 2019

Summary:
Do not scale up small icons to avoid quality detoriation. For small icons scaling should be done in SystemTray only. Currently XembedSNIProxy scales to 32x32, then SystemTray (usually) scales it down to 24x24.

BUG: 366047
FIXED-IN: 5.17.1

Test Plan:
I've run few applications with small icons:
  - keepassx (22x22)
  - liferea (16x16)
  - tuxguitar (16x16)

It looks much better without scaling in xemebdsniproxy.

Reviewers: davidedmundson, #plasma, #plasma_workspaces

Reviewed By: davidedmundson, #plasma, #plasma_workspaces

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24531

Konrad Materka authored Oct 10, 2019 and Nate Graham committed Oct 10, 2019

Summary:
If needed, perform resize in each update().
Client window may be too big, it must be resized to a certain reasonable size. Sometimes resizing in the constructor is not enough because it is too early and the client window is not fully initialized. Even if client window is resized, on first update it reverts back to original size (or just ignores the first request - some kind of a race condition).

In addition, I applied some rules from: https://community.kde.org/Policies/Kdelibs_Coding_Style

BUG: 358240

Test Plan:
I tested it using keepass2, now it shows better results (still not perfect). Window is resized to 32x32, but icon is only 24x24 it top-left. Better than 273x273 with tiny dot in the corner. This is a workaround for unsolvable bug in Mono - AFAIK Windows Forms are not longer maintained so it won't be fixed.

I tested this change with several other apps for regressions, no issues:
pidgin
liferea
hexchat
tuxguitar
xchat
keepassx
stardict
and other I don't remember now. No regressions.

Reviewers: davidedmundson, #plasma, #plasma_workspaces, broulik

Reviewed By: davidedmundson, #plasma, #plasma_workspaces

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24529

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The inhibition handling (e.g. combining time-based, screen mirrored, etc) is done inside the applet.
The Server knows nothing about it and only reports Inhibited as true when an external application
requested one, not when the user enabled it in the applet.
This patch exposes the NotificationManager.Server as singleton QML type and adds a way for the
applet to tell it the effective inhibition state.
Exposing the server to QML could also be used in the future to provide better error reporting
to the user when the service isn't running and/or owned by someone else (e.g. Dunst)

Differential Revision: https://phabricator.kde.org/D24486

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
It gives the following runtime warning:
   Warning: QT_AUTO_SCREEN_SCALE_FACTOR is deprecated. Instead use:
      QT_ENABLE_HIGHDPI_SCALING to enable platform plugin controlled per-screen factors

But we don't need to set QT_ENABLE_HIGHDPI_SCALING to 0.
Just setting QT_SCREEN_SCALE_FACTORS is enough to control scaling, after
my commit e018d11600bffc6 to qtbase.

Kudos for porting startkde to be C++ code, it makes this commit much
easier...

Test Plan: Builds; not rebooted yet

Reviewers: apol, davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24255

The notification popup typically gets in the way of the system tray popup.
In case it would cover a Plasma dialog, hide the notification popup.
It doesn't specifically check for System Tray but then it will also get out of the way of your
calendar and other widgets you might have placed in the respective corner.

Differential Revision: https://phabricator.kde.org/D24208

Otherwise we'll start of with a bigger gap to the bottom than in e.g. a top panel

Differential Revision: https://phabricator.kde.org/D24225

Kishore Gopalakrishnan authored Sep 21, 2019 and Nate Graham committed Sep 23, 2019

Summary:
This patch removes some spacing which was making the 'switch users' button get slightly cut off on small displays (1366x768). Quite a few old laptops have screens of this size, so it is good to take into account that display size as well, as long as it doesn't negatively affect the appearance for large displays.

BUG: 410801
FIXED-IN: 5.17.0

Test Plan:
Lock screen when connected to a low-res display and check that the 'switch users' button isn't cut off.

**Before this patch:**
Lockscreen on small display (1366x768): {F7330101}
Lockscreen on big display (1920x1080): {F7330096}

**After this patch:**
Lockscreen on small display (1366x768): {F7342190}
Lockscreen on big display (1920x1080): {F7342191}

Reviewers: #plasma, #vdg, ngraham, filipf

Reviewed By: #vdg, ngraham, filipf

Subscribers: filipf, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23786

They were present in most cases but missing in some.

Differential Revision: https://phabricator.kde.org/D24108

GIT_SILENT

Missed that part during move of kicker plugin to plasma-workspace

BUG: 412069

GIT_SILENT

It cannot be added to the same catalog as the original applet in plasma-desktop
so it is now extracted to a "libkicker" catalog

GIT_SILENT

grab must never be stolen by flickables

Summary:
There are two proposed justifications for this addition:
- In general, VDG would like to move towards consistently using the Meta key for global shortcuts
- Switching macOS users will be able to activate KRunner with the exact same keyboard shortcut they used to activate Spotlight

Reviewers: #vdg, #plasma, ndavis, GB_2

Reviewed By: #vdg, ndavis, GB_2

Subscribers: GB_2, romangg, ndavis, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24033

Summary:
TL;DR version: whenever you currently would be taken to a session switcher page where the only possible action is to go to SDDM and start a new session, instead just show SDDM immediately instead.

Currently, the session switcher screen suffers from a few UX problems:
- There's a fake "start new session" item that looks like a button but isn't clickable
- Asking to switch users always goes to the screen where you can switch to existing sessions even if there are no existing sessions to switch to, which is an unnecessary extra step

This patch aims to solve those problems in the following ways:
- Don't show a fake "start new session" item in the Breeze theme; instead add a real button in the UI to do this
- When asked to show the session management screen and there is only one session so the on;y thing you could do on that screen is create another session, instead just go to session creation directly
- For themes where the fake "start new session" button is shown, use a better icon that doesn't make it look like a clickable button

BUG: 386361
FIXED-IN: 5.17.0

Depends on D23279

Test Plan:
1. Have only one session > Kickoff/Kicker/dash/Krunner > Switch User -> you go directly to SDDM where you can start a new session
2. Start a new session, then Switch user again -> you go to the session management screen where you can switch to the other session, or start a new one

Videos:
Clicking "Switch User" when there are no other sessions: {F7264475}

Clicking "Switch User" when there is another session to switch to, and then switching to it: {F7264476}

Clicking "Switch User" when there is another session to switch to, and then starting a new session: {F7264480}

Switching between multiple sessions in the session switcher: {F7264483}

If the fake "New Session" item is shown (e.g in other themes), here's what it now looks like: {F7264485}

Reviewers: #plasma, #vdg, GB_2, mart

Reviewed By: #plasma, #vdg, GB_2, mart

Subscribers: GB_2, gregormi, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23283

The Switch Window popup menu originally numbered the desktops starting
from 0, in contrast to the KWin and Task Manager menus which start
from 1.  Adjust the Switch Window numbering to start from 1 also.

Do not use the internal desktop ID for this, on X11 it is indeed the
1-based desktop number but on Wayland it is a UUID string.

BUG:410190

Differential Revision: https://phabricator.kde.org/D22740

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
I wanted to debug why an application didn't start, this helped me see that it
was found and in which phase.
It's not installed for now.

Test Plan:
```
$ ./bin/plasma-autostart
phase: 0
- org.kde.plasmashell /home/apol/devel/kde5/etc/xdg/autostart/org.kde.plasmashell.desktop
- polkit-kde-authentication-agent-1 /home/apol/devel/kde5/etc/xdg/autostart/polkit-kde-authentication-agent-1.desktop
- xembedsniproxy /home/apol/devel/kde5/etc/xdg/autostart/xembedsniproxy.desktop

phase: 1
- gmenudbusmenuproxy /home/apol/devel/kde5/etc/xdg/autostart/gmenudbusmenuproxy.desktop
- pulseaudio /etc/xdg/autostart/pulseaudio.desktop
- org.kde.discover.notifier /home/apol/devel/kde5/etc/xdg/autostart/org.kde.discover.notifier.desktop
- org.kde.kdeconnect.daemon /home/apol/devel/kde5/etc/xdg/autostart/org.kde.kdeconnect.daemon.desktop

phase: 2
- geoclue-demo-agent /etc/xdg/autostart/geoclue-demo-agent.desktop
- gnome-shell-overrides-migration /etc/xdg/autostart/gnome-shell-overrides-migration.desktop
- snap-userd-autostart /etc/xdg/autostart/snap-userd-autostart.desktop
- powerdevil /home/apol/devel/kde5/etc/xdg/autostart/powerdevil.desktop
- org.kde.yakuake /home/apol/.config/autostart/org.kde.yakuake.desktop
```

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23727

Instead of using cmake config installed by ourself, use source dir paths

Make sure a cancel request gets rid of the job dialog eventually.

Differential Revision: https://phabricator.kde.org/D23982

and make sure it builds

A job instance is created as soon as the job starts but it might not be shown to the user right away or at all.
JobPrivate::prettyDestUrl() already creates the KFilePlacesModel if needed, no need to do it in the constructor.

Differential Revision: https://phabricator.kde.org/D23983

Makes sure that when a job is undismissed its ago text is correct immediately

Currently, a notification is considered "unread" when it was created or updated after the last time the user opened the history.
To alleviate this, when the notification popup is hovered, e.g. because the user wanted to drag an image out, select some text,
or open the "More" menu, it is considered read. It will still end up in the history but will not needlessly show the "unread notification" bell icon.

Moreover, job finished notifications are always considered read, as they are either from long-standing jobs which the user is likely aware of,
or confirmation of short tasks the user doesn't need explicit confirmation about. For example, extracting an archive in Dolphin,
I get an "Extracting (Finished)" but I don't want to explicitly acknowledge that notification because I can just enter the folder that was just created in Dolphin.

This surely doesn't fix the underlying problem of notification expiration and history, and the user might just interact wiht some
tray icons or the clock and not actually deal with the notification popup but this is imho an acceptable stopgap until a proper
solution is found, which won't happen in time for Plasma 5.17 anyway.

Differential Revision: https://phabricator.kde.org/D23977

Summary: It got lost during the porting to native executables

Test Plan:
Set KDEWM=awesome, successfully started a new Plasma
session with it, unset it again and kwin is started in the next
session.

Reviewers: #plasma, apol, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23910

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"