1. 10 Oct, 2019 4 commits
    • Konrad Materka's avatar
      [XembedSNIProxy] Scale only big icons · 13efbfca
      Konrad Materka authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Do not scale up small icons to avoid quality detoriation. For small icons scaling should be done in SystemTray only. Currently XembedSNIProxy scales to 32x32, then SystemTray (usually) scales it down to 24x24.
      
      BUG: 366047
      FIXED-IN: 5.17.1
      
      Test Plan:
      I've run few applications with small icons:
        - keepassx (22x22)
        - liferea (16x16)
        - tuxguitar (16x16)
      
      It looks much better without scaling in xemebdsniproxy.
      
      Reviewers: davidedmundson, #plasma, #plasma_workspaces
      
      Reviewed By: davidedmundson, #plasma, #plasma_workspaces
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24531
      13efbfca
    • Konrad Materka's avatar
      [XembedSNIProxy] Check size in each update() · acf91005
      Konrad Materka authored and Nate Graham's avatar Nate Graham committed
      Summary:
      If needed, perform resize in each update().
      Client window may be too big, it must be resized to a certain reasonable size. Sometimes resizing in the constructor is not enough because it is too early and the client window is not fully initialized. Even if client window is resized, on first update it reverts back to original size (or just ignores the first request - some kind of a race condition).
      
      In addition, I applied some rules from: https://community.kde.org/Policies/Kdelibs_Coding_Style
      
      BUG: 358240
      
      Test Plan:
      I tested it using keepass2, now it shows better results (still not perfect). Window is resized to 32x32, but icon is only 24x24 it top-left. Better than 273x273 with tiny dot in the corner. This is a workaround for unsolvable bug in Mono - AFAIK Windows Forms are not longer maintained so it won't be fixed.
      
      I tested this change with several other apps for regressions, no issues:
      pidgin
      liferea
      hexchat
      tuxguitar
      xchat
      keepassx
      stardict
      and other I don't remember now. No regressions.
      
      Reviewers: davidedmundson, #plasma, #plasma_workspaces, broulik
      
      Reviewed By: davidedmundson, #plasma, #plasma_workspaces
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24529
      acf91005
    • Jonathan Esk-Riddell's avatar
      Update version number for 5.17.0 · 9290f05a
      Jonathan Esk-Riddell authored
      GIT_SILENT
      9290f05a
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · f1bfb665
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      f1bfb665
  2. 09 Oct, 2019 1 commit
    • Kai Uwe Broulik's avatar
      [Notifications] Report effective Inhibited state on DBus · bb0e4208
      Kai Uwe Broulik authored
      The inhibition handling (e.g. combining time-based, screen mirrored, etc) is done inside the applet.
      The Server knows nothing about it and only reports Inhibited as true when an external application
      requested one, not when the user enabled it in the applet.
      This patch exposes the NotificationManager.Server as singleton QML type and adds a way for the
      applet to tell it the effective inhibition state.
      Exposing the server to QML could also be used in the future to provide better error reporting
      to the user when the service isn't running and/or owned by someone else (e.g. Dunst)
      
      Differential Revision: https://phabricator.kde.org/D24486
      bb0e4208
  3. 08 Oct, 2019 1 commit
  4. 07 Oct, 2019 1 commit
  5. 06 Oct, 2019 1 commit
  6. 30 Sep, 2019 1 commit
  7. 27 Sep, 2019 2 commits
    • David Faure's avatar
      [startplasma] don't set QT_AUTO_SCREEN_SCALE_FACTOR with Qt >= 5.14 · a0a80c67
      David Faure authored
      Summary:
      It gives the following runtime warning:
         Warning: QT_AUTO_SCREEN_SCALE_FACTOR is deprecated. Instead use:
            QT_ENABLE_HIGHDPI_SCALING to enable platform plugin controlled per-screen factors
      
      But we don't need to set QT_ENABLE_HIGHDPI_SCALING to 0.
      Just setting QT_SCREEN_SCALE_FACTORS is enough to control scaling, after
      my commit e018d11600bffc6 to qtbase.
      
      Kudos for porting startkde to be C++ code, it makes this commit much
      easier...
      
      Test Plan: Builds; not rebooted yet
      
      Reviewers: apol, davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24255
      a0a80c67
    • Kai Uwe Broulik's avatar
      [Notifications] Dodge Plasma dialogs · cc0c1254
      Kai Uwe Broulik authored
      The notification popup typically gets in the way of the system tray popup.
      In case it would cover a Plasma dialog, hide the notification popup.
      It doesn't specifically check for System Tray but then it will also get out of the way of your
      calendar and other widgets you might have placed in the respective corner.
      
      Differential Revision: https://phabricator.kde.org/D24208
      cc0c1254
  8. 25 Sep, 2019 2 commits
  9. 23 Sep, 2019 1 commit
    • Kishore Gopalakrishnan's avatar
      Remove some spacing on lockscreen that was causing elements to get cut off on small displays · cb96abf9
      Kishore Gopalakrishnan authored and Nate Graham's avatar Nate Graham committed
      Summary:
      This patch removes some spacing which was making the 'switch users' button get slightly cut off on small displays (1366x768). Quite a few old laptops have screens of this size, so it is good to take into account that display size as well, as long as it doesn't negatively affect the appearance for large displays.
      
      BUG: 410801
      FIXED-IN: 5.17.0
      
      Test Plan:
      Lock screen when connected to a low-res display and check that the 'switch users' button isn't cut off.
      
      **Before this patch:**
      Lockscreen on small display (1366x768): {F7330101}
      Lockscreen on big display (1920x1080): {F7330096}
      
      **After this patch:**
      Lockscreen on small display (1366x768): {F7342190}
      Lockscreen on big display (1920x1080): {F7342191}
      
      Reviewers: #plasma, #vdg, ngraham, filipf
      
      Reviewed By: #vdg, ngraham, filipf
      
      Subscribers: filipf, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23786
      cb96abf9
  10. 20 Sep, 2019 1 commit
  11. 19 Sep, 2019 7 commits
  12. 18 Sep, 2019 1 commit
  13. 17 Sep, 2019 4 commits
    • Nate Graham's avatar
      Add Meta+Space as a default shortcut to activate KRunner · 4000bd5d
      Nate Graham authored
      Summary:
      There are two proposed justifications for this addition:
      - In general, VDG would like to move towards consistently using the Meta key for global shortcuts
      - Switching macOS users will be able to activate KRunner with the exact same keyboard shortcut they used to activate Spotlight
      
      Reviewers: #vdg, #plasma, ndavis, GB_2
      
      Reviewed By: #vdg, ndavis, GB_2
      
      Subscribers: GB_2, romangg, ndavis, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24033
      4000bd5d
    • Nate Graham's avatar
      When asked to switch sessions, jump to session creation if there's nothing to switch to · c87d9064
      Nate Graham authored
      Summary:
      TL;DR version: whenever you currently would be taken to a session switcher page where the only possible action is to go to SDDM and start a new session, instead just show SDDM immediately instead.
      
      Currently, the session switcher screen suffers from a few UX problems:
      - There's a fake "start new session" item that looks like a button but isn't clickable
      - Asking to switch users always goes to the screen where you can switch to existing sessions even if there are no existing sessions to switch to, which is an unnecessary extra step
      
      This patch aims to solve those problems in the following ways:
      - Don't show a fake "start new session" item in the Breeze theme; instead add a real button in the UI to do this
      - When asked to show the session management screen and there is only one session so the on;y thing you could do on that screen is create another session, instead just go to session creation directly
      - For themes where the fake "start new session" button is shown, use a better icon that doesn't make it look like a clickable button
      
      BUG: 386361
      FIXED-IN: 5.17.0
      
      Depends on D23279
      
      Test Plan:
      1. Have only one session > Kickoff/Kicker/dash/Krunner > Switch User -> you go directly to SDDM where you can start a new session
      2. Start a new session, then Switch user again -> you go to the session management screen where you can switch to the other session, or start a new one
      
      Videos:
      Clicking "Switch User" when there are no other sessions: {F7264475}
      
      Clicking "Switch User" when there is another session to switch to, and then switching to it: {F7264476}
      
      Clicking "Switch User" when there is another session to switch to, and then starting a new session: {F7264480}
      
      Switching between multiple sessions in the session switcher: {F7264483}
      
      If the fake "New Session" item is shown (e.g in other themes), here's what it now looks like: {F7264485}
      
      Reviewers: #plasma, #vdg, GB_2, mart
      
      Reviewed By: #plasma, #vdg, GB_2, mart
      
      Subscribers: GB_2, gregormi, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23283
      c87d9064
    • Jonathan Marten's avatar
      Consistent virtual desktop numbering between Switch Window popup and taskbar · eed2d620
      Jonathan Marten authored
      The Switch Window popup menu originally numbered the desktops starting
      from 0, in contrast to the KWin and Task Manager menus which start
      from 1.  Adjust the Switch Window numbering to start from 1 also.
      
      Do not use the internal desktop ID for this, on X11 it is indeed the
      1-based desktop number but on Wayland it is a UUID string.
      
      BUG:410190
      
      Differential Revision: https://phabricator.kde.org/D22740
      eed2d620
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · dbc616f0
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      dbc616f0
  14. 16 Sep, 2019 13 commits
    • Aleix Pol Gonzalez's avatar
      Provide a simple test tool to see what autostart will look like · e7cc46fa
      Aleix Pol Gonzalez authored
      Summary:
      I wanted to debug why an application didn't start, this helped me see that it
      was found and in which phase.
      It's not installed for now.
      
      Test Plan:
      ```
      $ ./bin/plasma-autostart
      phase: 0
      - org.kde.plasmashell /home/apol/devel/kde5/etc/xdg/autostart/org.kde.plasmashell.desktop
      - polkit-kde-authentication-agent-1 /home/apol/devel/kde5/etc/xdg/autostart/polkit-kde-authentication-agent-1.desktop
      - xembedsniproxy /home/apol/devel/kde5/etc/xdg/autostart/xembedsniproxy.desktop
      
      phase: 1
      - gmenudbusmenuproxy /home/apol/devel/kde5/etc/xdg/autostart/gmenudbusmenuproxy.desktop
      - pulseaudio /etc/xdg/autostart/pulseaudio.desktop
      - org.kde.discover.notifier /home/apol/devel/kde5/etc/xdg/autostart/org.kde.discover.notifier.desktop
      - org.kde.kdeconnect.daemon /home/apol/devel/kde5/etc/xdg/autostart/org.kde.kdeconnect.daemon.desktop
      
      phase: 2
      - geoclue-demo-agent /etc/xdg/autostart/geoclue-demo-agent.desktop
      - gnome-shell-overrides-migration /etc/xdg/autostart/gnome-shell-overrides-migration.desktop
      - snap-userd-autostart /etc/xdg/autostart/snap-userd-autostart.desktop
      - powerdevil /home/apol/devel/kde5/etc/xdg/autostart/powerdevil.desktop
      - org.kde.yakuake /home/apol/.config/autostart/org.kde.yakuake.desktop
      ```
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23727
      e7cc46fa
    • Bhushan Shah's avatar
      f6098d6a
    • Bhushan Shah's avatar
      kicker: fix accidentially introduced self-dep · 1972c9a3
      Bhushan Shah authored
      Instead of using cmake config installed by ourself, use source dir paths
      1972c9a3
    • Kai Uwe Broulik's avatar
      [Notifications] Kill job after 2 seconds if application doesn't react to cancel request · 49519b7a
      Kai Uwe Broulik authored
      Make sure a cancel request gets rid of the job dialog eventually.
      
      Differential Revision: https://phabricator.kde.org/D23982
      49519b7a
    • Bhushan Shah's avatar
      Import CMakeLists file for kicker · 18722ec7
      Bhushan Shah authored
      and make sure it builds
      18722ec7
    • Bhushan Shah's avatar
      Import kicker plugin in plasma-workspace · 6487fa26
      Bhushan Shah authored
      6487fa26
    • Bhushan Shah's avatar
      Move the kicker plugin to the subdirectory · 66f3569d
      Bhushan Shah authored
      66f3569d
    • Kai Uwe Broulik's avatar
      [Notifications] Create KFilePlacesModel when needed · 935318df
      Kai Uwe Broulik authored
      A job instance is created as soon as the job starts but it might not be shown to the user right away or at all.
      JobPrivate::prettyDestUrl() already creates the KFilePlacesModel if needed, no need to do it in the constructor.
      
      Differential Revision: https://phabricator.kde.org/D23983
      935318df
    • Kai Uwe Broulik's avatar
      [Notifications] Update agoText in Component.onCompleted · 52b2306d
      Kai Uwe Broulik authored
      Makes sure that when a job is undismissed its ago text is correct immediately
      52b2306d
    • Kai Uwe Broulik's avatar
      GIT_SILENT: Remove stray semicolon · bee80743
      Kai Uwe Broulik authored
      bee80743
    • Kai Uwe Broulik's avatar
      [Notifications] Introduce dedicated "read" state for notification · 083e9409
      Kai Uwe Broulik authored
      Currently, a notification is considered "unread" when it was created or updated after the last time the user opened the history.
      To alleviate this, when the notification popup is hovered, e.g. because the user wanted to drag an image out, select some text,
      or open the "More" menu, it is considered read. It will still end up in the history but will not needlessly show the "unread notification" bell icon.
      
      Moreover, job finished notifications are always considered read, as they are either from long-standing jobs which the user is likely aware of,
      or confirmation of short tasks the user doesn't need explicit confirmation about. For example, extracting an archive in Dolphin,
      I get an "Extracting (Finished)" but I don't want to explicitly acknowledge that notification because I can just enter the folder that was just created in Dolphin.
      
      This surely doesn't fix the underlying problem of notification expiration and history, and the user might just interact wiht some
      tray icons or the clock and not actually deal with the notification popup but this is imho an acceptable stopgap until a proper
      solution is found, which won't happen in time for Plasma 5.17 anyway.
      
      Differential Revision: https://phabricator.kde.org/D23977
      083e9409
    • Heiko Becker's avatar
      startplasma: Respect KDEWM again · 0fcd2939
      Heiko Becker authored
      Summary: It got lost during the porting to native executables
      
      Test Plan:
      Set KDEWM=awesome, successfully started a new Plasma
      session with it, unset it again and kwin is started in the next
      session.
      
      Reviewers: #plasma, apol, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23910
      0fcd2939
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 62f183a7
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      62f183a7