1. 15 Jul, 2020 1 commit
    • Nate Graham's avatar
      [applets/batterymonitor] Handle "plugged in but still discharging" state · 19c41453
      Nate Graham authored
      Right now we handle the "plugged in but not charging" state but not the
      state where you're plugged in but the power supply doesn't supply enough
      power to prevent discharging anyway. We can wiggle the logic around to
      catch this case with the existing one for the "plugged in and not
      charging" state.
      19c41453
  2. 22 May, 2020 1 commit
    • Nate Graham's avatar
      [applets/batterymonitor] Improve UI for power management inhibition · 544f917e
      Nate Graham authored
      This patch improves the UI for inhibiting power management and seeing
      which apps are automatically doing it. Here are the changes, explained:
      
      1. Use less jargonistic terminology for the feature itself, and remove
         the explanatory tooltip which is no longer necessary
      2. Show the full list of apps which are inhibiting power management,
         because we have the space now that app icons are smaller
      3. Correctly show and hide the list of inhibitions based on count and
         Whether or not the user has independently suppressed PM
      4. Leave a bit more room for long reasons and alert translators to
         minimize string length as much as possible
      
      BUG: 401108
      FIXED-IN: 5.20.0
      544f917e
  3. 19 May, 2020 1 commit
    • Nate Graham's avatar
      [applets] Show KCMs in System Settings or Info Center, as appropriate · e8c72744
      Nate Graham authored
      Summary:
      CCBUG: 417836
      
      Depends on D29711
      
      As this will depend on Frameworks 5.71, it will be landed on master after branching,
      ending up in Plasma 5.20.
      
      Test Plan:
      Right-click on applets and activate their configure menu items
      Open applets and click on their settings buttons
      Observe that the KCMs are opened in System Settings or Info Center
      (depending on the context)
      
      Reviewers: mart, #plasma
      
      Reviewed By: mart, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29712
      e8c72744
  4. 12 May, 2020 1 commit
  5. 13 Mar, 2020 1 commit
    • Matej Mrenica's avatar
      [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line · db2518b0
      Matej Mrenica authored
      Summary:
      Currently the applet uses the main line in tooltip to display all info. Instead it should show always the same first line like other widgets and use the second line to show info.
      
      BUG: 411973
      FIXED-IN: 5.19.0
      
      Test Plan:
      The point of this patch is to make the tooltip more like the style used in the Audio Volume applet:
      {F7862465}
      
      Other "after" images:
      
      {F7862461}
      
      {F7862463}
      
      {F7862464}
      
      {F7871067}
      
      Reviewers: #vdg, #plasma, broulik, ndavis, mthw
      
      Reviewed By: #vdg, #plasma, broulik, ndavis, mthw
      
      Subscribers: GB_2, ndavis, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24070
      db2518b0
  6. 05 Jan, 2020 1 commit
    • Kai Uwe Broulik's avatar
      [Battery Monitor] Don't blink when battery is critical · 222b4074
      Kai Uwe Broulik authored
      Especially when you're almost out of juice you don't want to be wasting it blinking an icon causing excess repaints.
      Also considering the critical percentage is hardcoded to 5% here and doesn't follow PowerDevil's setting.
      Given battery critical notification is persistent and always on top of everything these days,
      you can't really miss the fact that you're almost ouf of power.
      
      Differential Revision: https://phabricator.kde.org/D26434
      222b4074
  7. 31 Dec, 2019 1 commit
    • Aleix Pol Gonzalez's avatar
      battery: Improve the brightness responsiveness · 62be85f4
      Aleix Pol Gonzalez authored
      Summary:
      Use QQC2.Slider, so that we have a moved signal. This way we can only
      issue new brightnesses when the user actually interacts with it.
      Don't adapt to the system brightness until we have finished interacting
      with it.
      
      Test Plan:
      Manual testing, flickering is very much reduced both when scrolling over the
      compact plasmoid as well as the slider.
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26035
      62be85f4
  8. 21 Jun, 2019 1 commit
  9. 09 Mar, 2019 1 commit
  10. 14 Dec, 2018 1 commit
  11. 25 Oct, 2017 1 commit
    • Bhushan Shah's avatar
      [batterymonitor] Fix brightness resetting to 1 on startup · 1c0f4179
      Bhushan Shah authored
      Summary:
      This was tricky bug to track down, needed to add debug statements in
      literally every functions.
      
      The flow of events is something like this, At startup:
      
      - We don't have information about actual brightness for few seconds
      - In this period, brightness slider have default value of 1
      - This triggers the function which sets batterymonitor.screenBrightness
      - onScreenBrightnessChanged gets called, which sets the actual
      brightness
      - onScreenBrightnessChanged have a guard for disableBrightnessUpdate but
      since we have it marked as false initially, we proceed to set actual
      brightness to 1
      - However before we set value of brightness to 1, we do get actual
      brightness back from dataengine, and our call overrides it to 1 later.
      - On desktop we do get 2nd dataChanged event from somewhere, so
      brightness is proper, but on mobile that is not case and results in
      brightness staying at 1.
      
      To fix this bug, we set disableBrightnessUpdate true at startup, and
      when there is actual brightness change from powerdevil or
      powermanagement engine, Logic.js takes care of enabling and disabling
      brightness change.
      
      (I quite like the boolean trap there in variable name :P .. will fix in
      another change in master)
      
      Test Plan:
      Tested on desktop and mobile, verified that
      
      - Brightness keys work
      - Brightness slider works
      - Scroll to change brightness works
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8462
      1c0f4179
  12. 23 Sep, 2017 1 commit
  13. 14 Mar, 2017 1 commit
    • Fabian Vogt's avatar
      Do not use fixed steps when scrolling on battery icon · 82a44a3f
      Fabian Vogt authored
      Summary:
      This makes it possible to have some more fine-grained control over
      the screen brightness with scroll devices that support it, like
      touchpads or trackpoints.
      
      Test Plan: Tested with touchpad, trackpoint and scroll wheel on mouse
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D5025
      82a44a3f
  14. 07 Dec, 2016 1 commit
    • Marco Martin's avatar
      Option to show percentage charge in the icon · 27ac0b76
      Marco Martin authored
      Summary:
      add an option to show a text label with the percentage value
      in the battery icon. text will be shown bottom-right
      of the icon with a background for readability, similar to
      unread count for IM or email apps.
      code was already there but effectively dead code
      
      Test Plan: tried both with and without label
      
      Reviewers: broulik, #plasma
      
      Reviewed By: broulik, #plasma
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3603
      27ac0b76
  15. 05 Jun, 2016 1 commit
  16. 19 May, 2016 1 commit
  17. 12 May, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Battery Monitor] Take "Has Cumulative" into account for tooltip · ed0b2043
      Kai Uwe Broulik authored
      This fixes showing "0% charging" on a desktop computer which has a
      wireless mouse/keyboard. If there is no battery whatsoever it continues
      to show "No batteries available" but for the aforementioned case the
      generic "Battery and brightness" is shown in order not to lie to the user :)
      
      CHANGELOG: Battery tooltip no longer shows "0% charging" for computers with wireless mouse/keyboard
      
      BUG: 362924
      Reviewed-By: mgraesslin
      ed0b2043
  18. 26 Mar, 2016 2 commits
  19. 09 Mar, 2016 2 commits
    • Kai Uwe Broulik's avatar
      [Battery Monitor] Be more declarative · a1e37a80
      Kai Uwe Broulik authored
      Calculate the plasmoid status and tooltips in a binding rather than invoking
      Logic.updateFoo manually; this way we can have the QML engine do what it can do best.
      Unfortunately it cannot look inside JS objects, so we cannot have the inhibitions
      be handled the same way.
      a1e37a80
    • Kai Uwe Broulik's avatar
      [Battery Monitor] Just use "battery tooltip icon · abb3183c
      Kai Uwe Broulik authored
      There's no point in having separate logic for the tooltip and Breeze
      doesn't have the icons we need anyway.
      
      CCBUG: 360276
      abb3183c
  20. 02 Jul, 2015 1 commit
  21. 11 May, 2015 1 commit
  22. 10 Apr, 2015 1 commit
  23. 09 Apr, 2015 1 commit
  24. 12 Feb, 2015 1 commit
  25. 23 Jan, 2015 2 commits
  26. 19 Jan, 2015 1 commit
  27. 13 Jan, 2015 1 commit
  28. 04 Jan, 2015 2 commits
  29. 22 Dec, 2014 1 commit
    • Kai Uwe Broulik's avatar
      Don't show OSD when dragging the slider · c8688f43
      Kai Uwe Broulik authored
      Prevent a "You don't say" moment, only show the OSD when using the mousewheel on the tray icon
      to provide feedback. Also make it more finegrained and allow 5% steps on the tray icon
      c8688f43
  30. 14 Dec, 2014 1 commit
  31. 08 Dec, 2014 1 commit
  32. 06 Dec, 2014 2 commits
  33. 05 Dec, 2014 1 commit
    • Kai Uwe Broulik's avatar
      Use absolute brightness values in battery monitor · 2c85cf22
      Kai Uwe Broulik authored
      This finally allows us to have predictable sliders where a wheel whill always
      result in a brightness change rather than having it go from 0 to 10 which is still
      below 33% in case of 3 keyboard brightness steps resulting in no change whatsoever.
      It also shows 0/3, 1/3, etc instead of percentage in such cases.
      
      Also clean up a bit, remove superfluous clipping and prevent brightness change
      on popup instantiation
      2c85cf22
  34. 14 Oct, 2014 1 commit
  35. 06 Sep, 2014 1 commit