1. 15 Jun, 2020 2 commits
    • David Edmundson's avatar
      Fix race in loading DBus activatable applets · 1c3dc486
      David Edmundson authored and David Edmundson's avatar David Edmundson committed
      If a service was registered between us requesting a list of names from
      the daemon and us processing the reply we would miss it. An event
      somewhat likely given plasmashell is very busy during startup.
      
      DBus does guarantee preserved message order, so the correct thing to do
      is:
       - create a match rule for new servies on DBus daemon
       - start fetching a list of names
       - ignore all changes that happen in the meantime
       - handle the list of all names
      
      This will be race free
      1c3dc486
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · e2cc9f6d
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      e2cc9f6d
  2. 14 Jun, 2020 1 commit
  3. 13 Jun, 2020 1 commit
  4. 12 Jun, 2020 1 commit
  5. 11 Jun, 2020 4 commits
  6. 10 Jun, 2020 1 commit
  7. 09 Jun, 2020 2 commits
  8. 07 Jun, 2020 1 commit
  9. 06 Jun, 2020 1 commit
  10. 05 Jun, 2020 1 commit
  11. 03 Jun, 2020 1 commit
  12. 02 Jun, 2020 1 commit
  13. 31 May, 2020 2 commits
  14. 29 May, 2020 1 commit
  15. 28 May, 2020 1 commit
  16. 27 May, 2020 2 commits
    • Alexander Lohnau's avatar
      4e706dc6
    • Alexander Lohnau's avatar
      Bookmarks Runner: Fix extraction of firefox profile · a960c028
      Alexander Lohnau authored
      Summary:
      BUG: 418526
      
      The profile group with the value `Default=1` is not always the default profile, for example in the profiles.ini file from the bug report:
      ```
      [Profile1]
      Name=default
      IsRelative=1
      Path=dun5pnnn.default
      Default=1
      
      [Profile0]
      Name=default-default
      IsRelative=1
      Path=xewbk2mp.default-default
      
      [Install11457493C5A56847]
      Default=xewbk2mp.default-default
      Locked=1```
      
      In the text you can see that the profile with `dun5pnnn.default` has the value `Default=1`,
      but it is not  the default profile.
      The correct default profile is in the `[Install11457493C5A56847]` group with the key `Default`.
      
      Test Plan:
      If you create a new profile it will be extracted as the default profile
      (but the old value might still be cached see D28619).
      
      Reviewers: #plasma, ngraham, bruns, broulik, meven
      
      Reviewed By: meven
      
      Subscribers: meven, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29326
      a960c028
  17. 26 May, 2020 1 commit
    • Konrad Materka's avatar
      [applets/systemtray] Fix configuraiton read on Plasma start · 40b1a94a
      Konrad Materka authored
      System tray models are created lazily, so it is possible that the configuration will load earlier and not notify the model of the stored values. Add explicit configuration load, so that it always loads correctly during the initialization.
      
      This is a fix for regression introduced in the !14
      40b1a94a
  18. 25 May, 2020 2 commits
    • Konrad Materka's avatar
      [applets/systemtray] Consistent name/icon in System Tray settings · 04bd86e1
      Konrad Materka authored
      Summary:
      Icon and title of entries in System Tray settings should not change when status changes.
      Use only plugin's meta-data for consistent title and icon.
      
      BUG: 421561
      
      FIXED-IN: 5.19.0
      
      Test Plan:
      1. Check Weather or Media Player applets
      2. Enbable/disable/change status
      3. Icon and title should remain the same
      04bd86e1
    • Konrad Materka's avatar
      [applets/systemtray] Lazy initialize SystemTray model · 2ce60f4e
      Konrad Materka authored
      Summary:
      SystemTray model was created in constructor, delay initialization and
      create it lazily.
      The `SystemTray::appletAdded` signal is connected to both SystemTray's
      model and `Container`. `Container` must be connected first, because it sets
      some properties of newly added applet: `visible` to false and `parent`
      to the root item (container). If `Container` is connected second, then
      newly created applet ios added to the model and rendered, but immediately
      after that `Container` changes visibility to false.
      
      BUG: 420993
      
      Test Plan:
      1. Do not play anything (no Medial Player icon at all)
      2. Run Gwenview
      3. Check if Medial Player icon in hidden view is rendered correct.
      Before change:
      Sometimes icon is not rendered, looks like invisible or fully transparent.
      After change:
      Icon rendered correctly.
      2ce60f4e
  19. 24 May, 2020 2 commits
    • Konrad Materka's avatar
      [applets/mediacontroller] Icon for Playing/Paused · 220d3540
      Konrad Materka authored
      Add icon for Playing/Paused states, this partially reverts !16
      220d3540
    • Konrad Materka's avatar
      [applets/mediacontroller] Don't use Album Art for icon · 6f826a1b
      Konrad Materka authored
      Summary:
      Icon of Media Player applet is missing in the System Tray settings when
      the media playing has a cover. Such icon is present when nothing is playing.
      Fix by not using album art in any case - icon is not longer used in
      tooltip, can be static.
      
      BUG: 420197
      
      FIXED-IN: 5.19.0
      
      Test plan:
      1. play audio/video with a player compatible with Media Player applet
      2. open system tray settings during playback
      3. Icon of Media Player applet is always present in system tray
      settings, regardless of state.
      6f826a1b
  20. 21 May, 2020 2 commits
  21. 20 May, 2020 2 commits
  22. 19 May, 2020 1 commit
  23. 18 May, 2020 2 commits
  24. 15 May, 2020 3 commits
  25. 14 May, 2020 2 commits