1. 28 Jun, 2020 1 commit
  2. 16 Sep, 2019 1 commit
  3. 04 Sep, 2019 1 commit
  4. 27 Aug, 2019 1 commit
  5. 25 Mar, 2019 1 commit
    • Tranter Madi's avatar
      [KickerDash] Add missed argument in addFavorite · 14c8ce82
      Tranter Madi authored
      Test Plan:
      Before:
      - Drag&Drop an item from the middle column into the Favorite column at the position 2 (index =1) -> it is always added at the last position
      
      After:
      - Drag&Drop an item from the middle column into the Favorite column at the position 2 (index =1) -> it is added at the wanted position 2
      
      Reviewers: ngraham, hein, #plasma
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19893
      14c8ce82
  6. 26 Nov, 2018 1 commit
    • Kevin Funk's avatar
      ASAN: Fix leak in KAStatsFavoritesModel · 49676fe2
      Kevin Funk authored
      Summary:
      Trace:
      Direct leak of 336 byte(s) in 6 object(s) allocated from:
          #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
          #1 0x7fbad15cddaf in KAStatsFavoritesModel::Private::entryForResource(QString const&) const /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:171:24
          #2 0x7fbad15b2d8e in KAStatsFavoritesModel::Private::addResult(QString const&, int, bool) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:280:22
          #3 0x7fbad15b044f in KAStatsFavoritesModel::Private::Private(KAStatsFavoritesModel*, QString) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:233:13
          #4 0x7fbad15a78ea in KAStatsFavoritesModel::initForClient(QString const&) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:485:13
          ...
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17039
      49676fe2
  7. 25 Jul, 2018 1 commit
  8. 30 Jan, 2018 2 commits
    • Marco Martin's avatar
      Fix iterator · a5d2f416
      Marco Martin authored
      Summary:
      removing favorites crashed, next() has to be called
      before accessing the item
      
      Test Plan: crash--
      
      Reviewers: #plasma, hein, ivan
      
      Reviewed By: #plasma, ivan
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10177
      a5d2f416
    • Marco Martin's avatar
      Fix iterator · b299d187
      Marco Martin authored
      Summary:
      removing favorites crashed, next() has to be called
      before accessing the item
      
      Test Plan: crash--
      
      Reviewers: #plasma, hein, ivan
      
      Reviewed By: #plasma, ivan
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10177
      b299d187
  9. 13 Nov, 2017 1 commit
    • David Edmundson's avatar
      Fix crash in KAStatsFavouritesModel · 615f6ac1
      David Edmundson authored
      Summary:
      KAStatsFavouritesModel doesn't initialise a D-pointer for the lifespan
      of the KAStatsFavouritesModel, like the name implies.
      
      It is set in initForClient.
      
      If the activity changes before we have a client ID, there's no point
      doing anything and trying to use the clientID will crash.
      
      BUG: 386439
      
      Test Plan: None.
      
      Reviewers: #plasma, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: anthonyfieroni, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8608
      615f6ac1
  10. 02 Nov, 2017 2 commits
  11. 10 Oct, 2017 1 commit
    • Fabian Vogt's avatar
      Fix editing items in SimpleFavoritesModel · 065a0fcf
      Fabian Vogt authored
      Summary:
      tools.js is supposed to support both KaStatsFavoritesModel (used for
      favorite applications) and SimpleFavoritesModel (used for system actions,
      like poweroff/reboot/logout). The latter did not work though, as tools.js
      unconditionally calls methods only present in KaStatsFavoritesModel.
      This commit makes KaStatsFavoritesModel API compatible to SimpleFavoritesModel
      and changes the relevant code in tools.js to support both.
      
      Additionally, this syncs applets/kickoff/package/contents/code/tools.js again.
      
      BUG: 385463
      
      Test Plan:
      Before this patch it wasn't possible to remove system actions from
      the favorites bar.
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: hein, davidedmundson, rikmills, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8178
      065a0fcf
  12. 08 Sep, 2017 1 commit
    • Ivan Čukić's avatar
      Per-activity favorites (Final, again?) · c311339e
      Ivan Čukić authored
      Summary:
      The favourites are based on KAStats (already released version) **and kactivitymanagerd master (to be released with the next Plasma release)**. It allows favourites to be set to all activities, or the user can choose which activities to show a specific favourite application on.
      
      This change covers applications, files and contacts, other favourites are still based on the old model (now named SimpleFavoritesModel).
      
      {F1028047}
      
      Test Plan:
      Tested in Kicker, Dashboard and Kickoff the following:
      
      Transitioning mechanism:
      
       - load default favorites for the blank user
       - load custom default favorites set in the plasmoidsetupscripts script for Kicker
       - transition old results - when transitioning, merge the favourites from all launchers. The ordering for each launcher is kept separate (newly added items due to the merge go to the end)
      
      Favorite manipulation:
      
       - right-click add favorite to all activities
       - right-click remove favorite from all activities
       - right-click add favorite to specific activity (current)
       - right-click remove favorite from specific activity (current)
       - right-click add favorite to specific activity (not current)
       - right-click remove favorite from specific activity (not current)
       - right-click move from all to specific
       - right-click move from specific to all
       - right-click move from one activity to another
       - dnd reorder items in the model (up)
       - dnd reorder items in the model (down)
       - dnd add to favorites at a specific position
      
      Other:
       - launch the application
       - ordering persists after restart
       - ordering from the previous is kept on the activity that has no ordering
      
      Reviewers: mart, hein
      
      Reviewed By: hein
      
      Subscribers: Zren, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3805
      c311339e