1. 25 Oct, 2020 2 commits
  2. 24 Oct, 2020 2 commits
  3. 20 Oct, 2020 3 commits
  4. 17 Oct, 2020 1 commit
  5. 16 Oct, 2020 5 commits
    • Nate Graham's avatar
      [applets/devicenotifier] Don't offer to unmount non-removable devices · 59ce9a3e
      Nate Graham authored
      The previous check for whether a device was non-removable in the
      delegate was faulty and was doing too much work, which caused it to miss
      non-root internal disks. In fact, we can already get this data straight
      from the data engine. This fixes the bug and removes code in net.
      
      BUG: 427176
      FIXED-IN: 5.20.1
      
      
      (cherry picked from commit 677d5dd8)
      59ce9a3e
    • Nate Graham's avatar
      [applets/systemtray] Fix icon size for 24px panels · 8e3de778
      Nate Graham authored
      We were using a > when we should have been using a >=, so there was one
      panel thickness that would make icons be too large for their panel and
      get squeezed together uncomfortably.
      
      BUG: 427690
      FIXED-IN: 5.20.1
      (cherry picked from commit afd1b432)
      8e3de778
    • Heiko Becker's avatar
      Make Prison a required dependency · 38ced581
      Heiko Becker authored
      7bd9bea0 started using Prison
      unconditionally via QML import. So if Prison isn't installed the
      clipboard applet stops working, complaining that "org.kde.prison is
      not installed".
      While it would certainly be possible to add another call to
      "find_package(KF5Prison)" with TYPE RUNTIME, the result in
      feature_summary would be very confusing, because OPTIONAL has a higher
      priority and the runtime hint would vanish if you build with e.g.
      -DCMAKE_DISABLE_FIND_PACKAGE_KF5Prison=TRUE.
      
      (cherry picked from commit 63f1b860)
      38ced581
    • Nate Graham's avatar
      [notifications] Fix margins of close button timeout indicator · 6d2ef8e2
      Nate Graham authored
      The previous calculation multiplied the DPR by `units.smallSpacing`, which was not correct; we wanted DPR added to the existing margin, not multiplied by it.
      
      Also using Math.floor is safer since Math.round sometimes rounds up (e.g. in case DPR is 2.501) which can cause undesirable effects.
      
      BUG: 425911
      
      
      (cherry picked from commit 07992bc4)
      6d2ef8e2
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · f25948d7
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      f25948d7
  6. 14 Oct, 2020 1 commit
    • Kai Uwe Broulik's avatar
      [Notifications] Also check transient parent for whether it's a dialog · 684bc806
      Kai Uwe Broulik authored
      In case a context menu is opened, we want to check the dialog it came from.
      This fixes the case of notifications dancing around when opening a context menu in
      System Tray but does not fix the case when opening a context menu in the notification
      itself since there it cannot know that the still open System Tray popup is the one
      we should evade and not the popup with the menu in it.
      
      CCBUG: 426187
      
      
      (cherry picked from commit bc12c6ca)
      684bc806
  7. 13 Oct, 2020 1 commit
  8. 11 Oct, 2020 1 commit
  9. 10 Oct, 2020 1 commit
  10. 09 Oct, 2020 2 commits
  11. 08 Oct, 2020 4 commits
  12. 07 Oct, 2020 1 commit
    • Eike Hein's avatar
      [kicker] Don't add invalid actions to the system action model · d80f738f
      Eike Hein authored
      The system actions model recently changed behavior to always present all
      possible actions, with `AbstractEntry::isValid` driving the model role
      `Kicker::DisabledRole` so that views can e.g. grey out unavailable
      actions.
      
      This was perceived as a regression by users who are annoyed at e.g.
      `Hibernate` being visible when their system setup precludes it more or
      less permanently.
      
      This patch reverts this behavior.
      
      Note that the dynamic approach we had permanently wasn't very great
      anyway, as the associated favorites models would remove entries when
      they became invalid, and they wouldn't come back automatically when the
      entry were to become valid again. In effect that means when you added one
      of these actions to e.g. the Kicker sidebar and it became unavailable
      it would disappear until re-added anyways.
      
      I can imagine use cases where dynamic behavior would be useful to have -
      let's say disabling Shutdown/Reboot while a critical system update is
      being performed. But in that case we'd need to fix the favorites
      behavior and add some way to inform the user why the action is disabled
      for a good user experienced anyhow.
      
      BUG:426645
      
      
      (cherry picked from commit fcdbbda3)
      d80f738f
  13. 06 Oct, 2020 2 commits
  14. 05 Oct, 2020 6 commits
  15. 04 Oct, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Set list sizes correctly · 04b89630
      Nate Graham authored
      1. Use Kirigami, not PlasmaCore, since this is a config window
      2. Remove PlasmaCore import now that it's no longer used
      3. Set implicitWidth/height on Kirigami.Icon, not width/height
      4. Use SmallMedium icon sizes, which is typical for list items like this
      
      (cherry picked from commit e43c766d)
      04b89630
  16. 03 Oct, 2020 2 commits
  17. 02 Oct, 2020 4 commits
    • Nate Graham's avatar
      [applets/systemtray] Fix size of grid on really thick panels · a54d1901
      Nate Graham authored
      Now the grid can have more than 2 rows/columns on really thick panels,
      just like in Plasma 5.19 and earlier.
      
      BUG: 427251
      FIXED-IN: 5.20
      
      
      (cherry picked from commit 649b50cd)
      a54d1901
    • Nate Graham's avatar
      [applets/systemtray] Fix closing active applet by clicking it again · bbce3c93
      Nate Graham authored
      This was removed by mistake in !285
      
      
      (cherry picked from commit bd2fcb05)
      bbce3c93
    • Vlad Zahorodnii's avatar
      [Shell Corona] Work around popup dismissal bug on Wayland · 329db2a6
      Vlad Zahorodnii authored
      A popup needs to grab the keyboard and the pointer in order to dismiss
      itself when another window is clicked. It works perfectly on X11.
      
      On Wayland though, the compositor is responsible for dismissing popups
      if some surface of another application has been clicked. Note that I
      said "of another application." If user clicks some surface of the same
      application, the compositor won't dismiss the popup.
      
      If the application uses only QtWidgets, then the popup will be closed
      as expected in both cases. But if the application uses both Qt Quick and
      Qt Widgets, e.g. plasmashell, then the popup won't be dismissed if a
      QQuickItem has been clicked.
      
      It is a Qt bug, but for the time being, this change introduces an event
      filter that monitors Qt::MouseButtonPress events and when needed closes
      the active popup widget. This is a workaround.
      
      CCBUG: 379635
      
      
      (cherry picked from commit 6689abaf)
      329db2a6
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 2907cb04
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      2907cb04
  18. 01 Oct, 2020 1 commit