Aleix Pol Gonzalez authored Jul 28, 2022 and Aleix Pol Gonzalez committed Jul 28, 2022

It's already checked by the line right above.

Any older version does not make sense, even Ubuntu 20.04 ships 2.6

This is the same version KDE Neon provides

CCBUG: 429892

Jin Liu authored Jul 27, 2022 and Nate Graham committed Jul 27, 2022

This allows the user to choose between automatically determined font size
(the default, and the current behavior), and completely manual font settings.

The UI refactor and layout code changes necessary for this feature also
happily fix a few bugs along the way.
 
BUG: 413394
BUG: 421548
BUG: 395468
FIXED-IN: 5.26

This saves about 2MiB memory.

Test Plan:
Open Krunner and type ?
Scroll though the list of results until one has a configure button
Click that button and check if systemsettings opens and the runner's KCM is opened

Carl Schwan authored Jan 28, 2022 and Fushan Wen committed Jul 27, 2022

Co-authored-by: Janet Blackquill <uhhadd@gmail.com>

Instead of complex and broken custom logic

That way we don't need to manually create the mimedata any more

Carl Schwan authored Jan 28, 2022 and Fushan Wen committed Jul 26, 2022

Should be tested with frameworks/plasma-framework!441
but doesn't require it

Read it first and then we can consider reading it correctly.

Currently we are very inconsistent with how we handle our various X11 dependencies.

Some places check whether specific sub-libraries are found and disable parts of the code accordingly.

Sometimes this is controlled by whether X11 is found at all, sometimes it depends on the sublibrary being present.

Some of this is obviously broken, e.g. in one like we check whether X11 is there and then use it unconditionally a few lines down.

Instead of the current system of optional deps and deps being conditional on other deps I propose that we introduce an explicit build option that controls the X11 support.

If on (the default) then all X11 libs are required.

If off then no X11 libs are searched for. Currently this results in a broken build since some places use X11 stuff unconditionally, but it gives us an easier way to test and fix those cases.

and also reformat CMakeLists in a more consistent way.

Amends 6ba01a55.

See https://github.com/Qalculate/libqalculate/issues/442 for the code snippets.
I have only adjusted those to compile inside of the plugin.

BUG: 454132

Shared contexts allow us to share textures and vertex buffers between
contexts (windows) this allows us to reduce memory in popups and alike.

To fully make use of this requires some follow up work in
ManagedTextureNode for FrameSVG, but we should sitll get some OOTB.

If shared contexts are not supported this fails gracefully - though we
are relying on shared contexts within kwin for a release without issue.

It also should fix WebGL inside WebViews.

BUG: 448299

Length turned out to be not what it claimed to be, which caused a bug to
sneak into the panel configuration's ruler handles.

See also: plasma-desktop!1059

These two code paths for vertical and horizontal orientations used two
different functions to clamp values. This commit makes them consistent.

Amends a3943400.

This menu item will open Activities KCM, which makes the configuration
easier to be found.

The current UI does not communicate to the user at what times these UI
elements will be shown, leading to confusion. People are thinking that
unchecking the Clock checkbox always hides it, but this is not the
case; instead it hides the clock only when the main UI is invisible.

To address this, the wordings of the checkbox labels are changed to
indicate what the opposite states will do as well.

BUG: 429468
FIXED-IN: 5.26

Ref: plasma-desktop#41

mainText is a property in `PlasmaCore.ToolTipArea`.

This uses the plasmoid name as Accessible.name, and uses tooltip text as
Accessible.description.

So a screen reader can read the name of a slider, and the percent sign.

This uses the plasmoid name as Accessible.name, and uses tooltip text as
Accessible.description.

This uses the plasmoid name as Accessible.name, and makes the
description more human-readable.

Jan Blackquill authored Dec 04, 2021 and Jan Blackquill committed Jul 23, 2022

Setting unchanged values may falsely trigger an authentication
prompt in the case that the changed value doesn't need authentication
to change, but the unchanged ones do, leading to an authentication prompt
to show up.

Adding a little bit of original vs new comparison lets us only send over
DBus what got changed.

BUG: 437286

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Nicolas Fella authored Jul 23, 2022 and Nate Graham committed Jul 23, 2022

It hasn't been a thing for an entire Qt major version

Ahmad Samir authored Jul 12, 2022 and Nate Graham committed Jul 23, 2022

Remove an un-used method.

GIT_SILENT

Ahmad Samir authored Jul 12, 2022 and Nate Graham committed Jul 23, 2022

BUG: 442298
FIXED-IN: 5.26

Ahmad Samir authored Jul 12, 2022 and Nate Graham committed Jul 23, 2022

Its manual page says it's insecure and should be avoided. Instead just
check the file exists.