1. 19 Mar, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Implement all the things · 35c575be
      Kai Uwe Broulik authored
      - Notification action buttons
      - Custom icon pixmaps in notifications
      - Popup handling
      - Notification urgency (low isn't shown as popup TBD, critical always no matter what)
      - History stuff (only expired notifications end up there, none that were closed or revoked)
      - Text selection and copy for body text
      - Basic tray icon support
      and many other things
      
      Application jobs are shown as part of regular notifications:
      - They show up as little popup that can be hidden in the history
      - When finished progress popup turns into a notification
      
      There's still some glitches and missing features, notably
      - Screenshot thumbnails
      - "Open" functionality for finished jobs
      - History layout
      - code cleanup
      - and basically every configuration option
      35c575be
  2. 19 Dec, 2018 2 commits
  3. 18 Dec, 2018 3 commits
    • Eike Hein's avatar
      Port the "Switch Desktop" containment action to libtaskmanager · 6e41b8d9
      Eike Hein authored
      Summary:
      This:
      * Makes it work on Wayland.
        Depends on D13745.
      * Cleans up includes and linkage.
      * Fixes some pre-existing bugs like cached actions not updating
        to changed desktop names.
      
      Reviewers: mart, davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: zzag, broulik, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T4457
      
      Differential Revision: https://phabricator.kde.org/D15599
      6e41b8d9
    • Eike Hein's avatar
      Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem · c64fc469
      Eike Hein authored
      Summary:
      This makes it work on Wayland. And probably fixes bugs, the code,
      especially the next/prev window stuff, was pretty wonky.
      
      Also some general cleanup.
      
      Depends on D13745.
      
      Reviewers: mart, davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T4457
      
      Differential Revision: https://phabricator.kde.org/D15642
      c64fc469
    • Eike Hein's avatar
      Implement support for virtual desktops on Wayland · 52d760c5
      Eike Hein authored
      Summary:
      Includes, among other things:
      * A refactoring towards supporting more than one desktop per window,
        for an eventual virtual desktops / activities merge
      * A scheme for process-internal window ids on Wayland as DND payload
        so DND in and to the Pager works in the shell
      * Implemented various previously missing behavior in WaylandTasksModel
        such as implicit moves of windows to the current desktop on various
        actions
      * Expanded VirtualDesktopInfo API so the Pager can better abstract
        over windowing systems
      * Implicit internal sharing of VirtualDesktopInfo since there are many
        more instances now
      * Various cleanups
      
      Still missing:
      * Fixing the VirtualDesktops data role in the grouping proxy
      * The protocol doesn't have desktop creation/destruction yet, so some
        of the related logic is still missing
      * Some FIXME TODOs in the code when I was unhappy with the current
        KWayland API
      
      This code is largely untested and subject to change.
      
      Depends on D12820 and relates to T4457.
      
      Reviewers: mart, mvourlakos, davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: alexde, anthonyfieroni, zzag, ngraham, abetts, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T4457
      
      Differential Revision: https://phabricator.kde.org/D13745
      52d760c5
  4. 14 Dec, 2018 2 commits
  5. 13 Dec, 2018 2 commits
  6. 12 Dec, 2018 5 commits
  7. 11 Dec, 2018 1 commit
  8. 08 Dec, 2018 1 commit
  9. 07 Dec, 2018 1 commit
  10. 06 Dec, 2018 1 commit
  11. 04 Dec, 2018 3 commits
  12. 03 Dec, 2018 2 commits
  13. 29 Nov, 2018 1 commit
    • Nate Graham's avatar
      [Login and Lock screens] Improve UI elements' contrast a bit · d9532e80
      Nate Graham authored
      Summary:
      As requested in D16031, tweak the login and lock screens in only fairly non-controversial ways:
      - Add a dark background behind the user avatar and a shadow behind the username
      - Tweak the clock shadow to make it a tiny bit stronger
      - Reduce clock shadow redundancy by moving it into the `Clock` item and out of the clients
      - Don't use hardcoded shadow colors anymore
      
      With the existing UI, these are very subtle changes that should barely be visible.
      
      This diff does **NOT** include the following changes from D16031:
      - Blur-less login screen
      - New icons for the buttons
      - Horizontal bar on the bottom to hold the buttons for the virtual keyboard, session chooser, and battery status
      
      Test Plan:
      Login screen:
      {F6424115, size=full}
      
      Lock screen:
      {F6435507, size=full}
      
      {F6435506, size=full}
      
      {F6435519, size=full}
      
      {F6435518, size=full}
      
      {F6435517, size=full}
      
      {F6435516, size=full}
      
      {F6435515, size=full}
      
      {F6435514, size=full}
      
      {F6435513, size=full}
      
      {F6435512, size=full}
      
      {F6435511, size=full}
      
      {F6435510, size=full}
      
      {F6435523, size=full}
      
      {F6435522, size=full}
      
      {F6435521, size=full}
      
      {F6435509, size=full}
      
      {F6424114, size=full}
      
      Reviewers: davidedmundson, #vdg, #plasma
      
      Reviewed By: davidedmundson, #plasma
      
      Subscribers: mart, rooty, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16879
      d9532e80
  14. 27 Nov, 2018 1 commit
  15. 26 Nov, 2018 1 commit
    • David Edmundson's avatar
      Set error if a kjob host disappears from kuiserver with active jobs · 2beb1a0a
      David Edmundson authored
      Summary:
      If the host of a kjob crashes or is killed kuiserver currently reports
      that the job has been completed successfully. This is seriously wrong as
      it could lead a user to perform a potentially destructive operation.
      
      Setting any error (that's not 0 or 1) will cause plasmashell, the main
      kuiserver view, to show a persistent notification that a job has failed.
      
      For master I will use a more correct new enum, new error text, and a way
      to tell for KIO operations to report to the uiserver if the host
      crashing is important or not.
      
      CCBUG: 352761
      
      Test Plan:
      Whilst copying a million files killed dolphin
      Got a persistent error instead of a success message on the last file it was on
      
      Moving files successfully then killing the app remained fine
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17171
      2beb1a0a
  16. 23 Nov, 2018 1 commit
    • Michail Vourlakos's avatar
      global menu,rename menuHidden to visible · 5779dde8
      Michail Vourlakos authored
      Summary:
      --as @mart requested we can rename "menuHidden" property
      to "visible" in order to follow Qt naming
      
      Test Plan:
      --check that global menu applet is functioning the same
      way as when using removed menuHidden property
      
      Reviewers: #plasma, mart, davidedmundson
      
      Reviewed By: #plasma, mart
      
      Subscribers: mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17107
      5779dde8
  17. 22 Nov, 2018 1 commit
    • Michail Vourlakos's avatar
      mage global menu screen aware · 3fa1cc6b
      Michail Vourlakos authored
      Summary:
      --a new screenGeometry property is added in the
      AppMenuModel in order to be used for filtering
      windows based on their geometry.
      
      BUG: 384895, 395853
      
      Test Plan:
      --validate that when moving a window between different screens the global menu applet is updated accordingly
      --checkout that nothing has broke because of this new behavior
      
      Reviewers: #plasma, broulik, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: mart, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16768
      3fa1cc6b
  18. 20 Nov, 2018 1 commit
    • Kevin Funk's avatar
      Perf: Do expensive regexp construction earlier · a46179d9
      Kevin Funk authored
      Summary:
      SystemTray::serviceRegistered is called tons of times; the regexp
      construction inside the for-loop is expensive and should be avoided.
      Thus construct the regexp once, and re-use the regexp object each time.
      
      Test Plan:
      Before:
      {F6432674}
      
      After:
      {F6432675}
      
      Reviewers: davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17025
      a46179d9
  19. 19 Nov, 2018 5 commits
    • Kevin Funk's avatar
      Fix a few memory leaks · e2ba40a4
      Kevin Funk authored
      ASAN: Fix leak in XWindowTasksModel
      
      Summary:
      Trace:
      Direct leak of 24 byte(s) in 3 object(s) allocated from:
          #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
          #1 0x7fe4f0e82df9 in TaskManager::XWindowTasksModel::Private::windowInfo(unsigned long long) /home/kfunk/devel/src/kf5/plasma-workspace/libtaskmanager/xwindowtasksmodel.cpp:419:25
          #2 0x7fe4f0e87e69 in TaskManager::XWindowTasksModel::data(QModelIndex const&, int) const /home/kfunk/devel/src/kf5/plasma-workspace/libtaskmanager/xwindowtasksmodel.cpp:646:38
          ...
      
      ASAN: Fix leak in ShellCorona
      
      Trace:
      Indirect leak of 48 byte(s) in 1 object(s) allocated from:
          #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
          #1 0x5e1a95 in ShellCorona::checkAddPanelAction(QStringList const&) /home/kfunk/devel/src/kf5/plasma-workspace/shell/shellcorona.cpp:1728:27
          #2 0x5dac7e in ShellCorona::ShellCorona(QObject*) /home/kfunk/devel/src/kf5/plasma-workspace/shell/shellcorona.cpp:180:5
          #3 0x65c31d in ShellManager::loadHandlers() /home/kfunk/devel/src/kf5/plasma-workspace/shell/shellmanager.cpp:93:21
          ...
      
      Reviewers: davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17032
      e2ba40a4
    • Kevin Funk's avatar
      ASAN: Fix leak in XWindowTasksModel · 38a50ce7
      Kevin Funk authored
      Trace:
      Direct leak of 24 byte(s) in 3 object(s) allocated from:
          #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
          #1 0x7fe4f0e82df9 in TaskManager::XWindowTasksModel::Private::windowInfo(unsigned long long) /home/kfunk/devel/src/kf5/plasma-workspace/libtaskmanager/xwindowtasksmodel.cpp:419:25
          #2 0x7fe4f0e87e69 in TaskManager::XWindowTasksModel::data(QModelIndex const&, int) const /home/kfunk/devel/src/kf5/plasma-workspace/libtaskmanager/xwindowtasksmodel.cpp:646:38
          ...
      38a50ce7
    • Laurent Montel's avatar
      Use new syntax · 38e6e0a0
      Laurent Montel authored
      38e6e0a0
    • Kai Uwe Broulik's avatar
      Merge branch 'Plasma/5.14' · aa80881a
      Kai Uwe Broulik authored
      aa80881a
    • Kai Uwe Broulik's avatar
      [DBusMenuImporter] Don't call removeAction() to avoid an empty QMenu · 73339208
      Kai Uwe Broulik authored
      As soon as QMenu becomes empty it is closed. This can happen when the application completely reloads its menu.
      Instead, call deleteLater which will destroy the QAction later at which point it is automatically removed from the menu.
      
      BUG: 399975
      FIXED-IN: 5.14.4
      
      CHANGELOG: Fixed global menu misbehaving and unexpectedly closing with certain applications
      
      Differential Revision: https://phabricator.kde.org/D16297
      73339208
  20. 15 Nov, 2018 5 commits