1. 19 Sep, 2018 1 commit
  2. 17 Sep, 2018 3 commits
  3. 16 Sep, 2018 2 commits
  4. 14 Sep, 2018 3 commits
  5. 13 Sep, 2018 15 commits
  6. 12 Sep, 2018 7 commits
    • Oleg Solovyov's avatar
      Plasmashell freezes when trying to get free space info from mounted remote... · e1c19ce4
      Oleg Solovyov authored
      Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it
      
      Summary:
      BUG: 397537
      
      Earlier plasmashell assumed that you'll get free space info immediately (which is not true in case of losing connection to server containing a mounted filesystem - statfs will wait for response forever and freeze everything since it's happening in main thread)
      
      I moved obtaining that info into different thread so that case won't freeze anything anymore.
      It creates exactly one thread per one path. If a path is already being processed, new thread won't be created.
      Also I implemented a timer used to notify about broken connection after 15 seconds.
      
      Reviewers: broulik, ngraham, davidedmundson
      
      Reviewed By: broulik
      
      Subscribers: ngraham, anthonyfieroni, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D14895
      e1c19ce4
    • Eike Hein's avatar
      Add back comment and fix indentation. · 2949e7c4
      Eike Hein authored
      2949e7c4
    • Eike Hein's avatar
      Do ignore-filtered-siblings properly · c81205cc
      Eike Hein authored
      Summary:
      Turns out c8358c20 only worked accidentally. We can't do this
      via filterModel->mapFromSource, because in a lambda connected to
      its source model's rowsInserted signal, the proxy hasn't seen that
      row yet.
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15462
      c81205cc
    • Eike Hein's avatar
      Re-filter launcher when a window changes identity · a057edc7
      Eike Hein authored
      Summary:
      LibreOffice reuses the same main window for both its start center and
      sub-apps like Writer launched from it, changing the window metadata on
      the fly. This ensures we hide e.g. a launcher for Writer when picking
      it in the LO start center.
      
      Reviewers: broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15458
      a057edc7
    • Eike Hein's avatar
      Handle clients which change window metadata during early startup · b15eaf38
      Eike Hein authored
      Summary:
      Some apps initially show their window with bogus/useless window
      metadata and then update to useful metadata during early startup.
      For example, LibreOffice sets WM_CLASS to soffice/Soffice and
      then updates to libreoffice-writer/libreoffice. This leads to
      a poor user experience on particular the Icons-only Task Manager,
      but also the regular Task Manager depending on settings.
      
      Depending on its configuration (and Icons-only Task Manager is
      a particular set of configuration options, as far as the model
      is concerned), TasksModel will try to sort a new window task
      adjacent to its launcher task. The appearance of a new window
      task also causes matching (in terms of identification) launcher
      or startup tasks to be filtered out. To the user, this forms a
      lifecycle of the launcher being replaced by the window in-place
      (and a startup state inbetween, optionally but by default).
      
      Prior to this patch, this sorting decision was only done once,
      when a new window enters the source model stack. This meant the
      LibreOffice window would initially be sorted into the "wrong"
      spot (the bogus metadata doesn't allow us to relate it to its
      launcher) and then, following the metadata change, stick to the
      wrong position.
      
      Simply changing the code to sort things again on any metadata
      change would not have been good enough: Metadata changes can
      occur at any time, and things should not just move around on
      the user - this sort mode is called "Manual" for a reason. Also,
      the visual result would still be poor: The window would initially
      appear at the wrong position, then move to the right one a bit
      later.
      
      This patch takes the following approach:
      * It adds a new config key to taskmanagerrulesrc for listing
        ids of matching tasks to completely hide, and of course the
        code needed to implement this.
      * It adds LibreOffice' bogus initial metadata to this key, so
        the tasks is initially hidden.
      * The sort code skips over hidden window tasks in the sort
        insert queue instead of moving them. The queue is marked as
        stale then, and cleared on unrelated windowing system changes.
      * It resorts when tasks are unhidden (i.e. once the metadata
        update has occured and the task no longer matches the above
        config key).
      
      The visual result is that the startup notification on the
      launcher spins a little bit longer than before, even though the
      window has already appeared (although LO lags in filling in its
      contents anyway), and then morphs into the window task
      representation once the client has completed the window metadata
      change. This happens in such a short order as to be more or less
      imperceptible.
      
      If startup notifications are turned off it's broadly the same,
      minus the spinning.
      
      BUG:396871
      
      Reviewers: davidedmundson, broulik, ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15410
      b15eaf38
    • Kai Uwe Broulik's avatar
      Open Web Shorcuts KCM from Web Shortcut Runner config · 4b4439fe
      Kai Uwe Broulik authored
      The runner doesn't have any config on its own but uses the Web Shortcuts configuration.
      Add a "configure" button that opens that KCM straight away.
      
      BUG: 398242
      FIXED-IN: 5.14.0
      
      Differential Revision: https://phabricator.kde.org/D15430
      4b4439fe
    • Kai Uwe Broulik's avatar
      [libdbusmenuqt] Port to categorized logging · 1e1ce733
      Kai Uwe Broulik authored
      And make it less chatty overall, none of these are real "warnings"
      
      Differential Revision: https://phabricator.kde.org/D15447
      1e1ce733
  7. 11 Sep, 2018 1 commit
  8. 10 Sep, 2018 2 commits
  9. 09 Sep, 2018 3 commits
    • Nate Graham's avatar
      Use consistent "Suspend" terminology · 4500ff9d
      Nate Graham authored
      Summary: We use "Suspend" and "Hibernate" in most places except for KRunner, where we currently use more technical terms that expose the implementation details (suspend to ram vs suspend to disk). Let's be consistent.
      
      Reviewers: #plasma, #vdg, davidedmundson, broulik
      
      Reviewed By: #plasma, davidedmundson, broulik
      
      Subscribers: sudhirkhanger, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15386
      4500ff9d
    • Stefan Brüns's avatar
      [Bookmarks Runner] Remove unused define · 9be8c3c7
      Stefan Brüns authored
      Test Plan: make
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15384
      9be8c3c7
    • Stefan Brüns's avatar
      Fix Firefox profile location lookup after location has changed · dda9aaba
      Stefan Brüns authored
      Summary:
      When the profile has initially been looked up, the location is saved to
      the global config. Afterwards, the location is never updated even if
      the profile has been replaced, due to an inverted exits() check.
      
      Test Plan:
      1. Check dbfile in kdeglobals is pointing to a valid profile
      2a. Change the dbfile setting - or -
      2b. Remove the existing profile and create a new one
      3. Restart krunner - it should fix the config entry/use the new profile
      
      Reviewers: #plasma, apol
      
      Reviewed By: apol
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15254
      dda9aaba
  10. 08 Sep, 2018 1 commit
    • Stefan Brüns's avatar
      [Bookmarks Runner] Filter out empty urls, simplify, fix comment · 08895fd7
      Stefan Brüns authored
      Summary:
      Bookmarks may have no title, the user is free to delete it when creating
      a bookmark.
      A bookmark without URL would be useless (there were nothing to refer to),
      so ignore any bookmark with an empty URL.
      Simplify check for Firefox specific "place:" URLs.
      
      Test Plan:
      Search for "Recent" or "place"
      "Recent Tags" is still filtered out
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15356
      08895fd7
  11. 07 Sep, 2018 2 commits