1. 18 Nov, 2020 2 commits
  2. 10 Nov, 2020 1 commit
    • Konrad Materka's avatar
      Fix Connections warnings · 5abed2dd
      Konrad Materka authored
      Qt 5.15 introduced new syntax for defining Connections. Fix warnings like this one:
      QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
      5abed2dd
  3. 28 Jul, 2020 1 commit
  4. 04 May, 2020 1 commit
  5. 13 Feb, 2020 1 commit
  6. 14 Jan, 2020 1 commit
    • Dan Leinir Turthra Jensen's avatar
      Switch to KNSQuick for getting new wallpapers · 47a1091b
      Dan Leinir Turthra Jensen authored
      Summary:
      This switches the image plugin to using KNewStuffQuick instead of
      launching the widget dialog through that ol' widget dialog hack.
      It further uses the big preview mode by default, which just seems
      to make a lot of sense for wallpapers.
      
      Test Plan:
      Without: Uses the old dialog
      With: Uses the new dialog, as seen below
      {F7882885}
      
      Reviewers: mart, #plasma, ngraham
      
      Reviewed By: mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26665
      47a1091b
  7. 12 Jan, 2020 1 commit
    • Yuri Chornoivan's avatar
      Load localization catalog for slideshow config window · 025387c9
      Yuri Chornoivan authored
      Summary: It was reported by Victor Ryzhykh that this patch fixes localization of the wallpaper slideshow config window.
      
      Test Plan:
      1. Open the config window in some ~100%-translated locale (ca, pt, sv, uk).
      2. All messages should be translated.
      
      Reviewers: #plasma, #localization, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26584
      025387c9
  8. 10 Jan, 2020 3 commits
    • Nate Graham's avatar
      [wallpapers/image] Disambiguate identical folder names in paths list · c3242c1d
      Nate Graham authored
      Summary:
      When multiple paths that end in the same folder name are added (for example with D26483),
      currently the list shows multiple identical entries distinguished only by their different
      tooltips. This patch improves the situation by putting the path to the folder in a
      subtitle.
      
      Test Plan:
      Before: {F7868784}
      
      After: {F7868785}
      
      Reviewers: #vdg, #plasma, mart
      
      Reviewed By: #vdg, #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26510
      c3242c1d
    • Nate Graham's avatar
      [wallpapers/image] Put spinbox labels inside the spinboxes · 276eac85
      Nate Graham authored
      Summary: They look a little nicer this way, and can be localized more easily.
      
      Test Plan:
      Before: {F7871094, size=full}
      After:{F7871093, size=full}
      
      Reviewers: #vdg, #plasma, mart
      
      Reviewed By: #vdg, #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26529
      276eac85
    • Nate Graham's avatar
      [wallpapers/image] Add placeholder labels when wallpaper lists are empty · b79f9967
      Nate Graham authored
      Summary:
      Right now, when there are no configured wallpaper slideshow paths or wallpapers in the
      slideshow, the list and grid (respectively) are just empty. This patch adds some
      placeholder labels to let the user know that it's not broken, just like we do in the
      Thunderbolt KCM.
      
      See one `FIXME:` in the code that I could use a hand with.
      
      Test Plan: {F7870947}
      
      Reviewers: #vdg, #plasma, mart
      
      Reviewed By: #vdg, #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26528
      b79f9967
  9. 28 Nov, 2019 1 commit
    • Kevin Ottens's avatar
      Repair the wallpaper config dialog · 3600bebc
      Kevin Ottens authored
      Summary:
      This is full of mixed bindings/signal handlers for properties and of
      broken references in here!
      
      There's likely more to do, but those were the most obvious ones when
      working on the screenlocker KCM.
      
      Reviewers: #plasma, mart, davidedmundson, crossi, bport
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25567
      3600bebc
  10. 25 Jul, 2019 1 commit
    • David Redondo's avatar
      [Image Wallpaper Slideshow] Allow setting of different sorting orders · ea32a761
      David Redondo authored
      Summary:
      Allows setting of other sorting orders like alphabetical or last modified date.
      To enable this a new ProxyModel is introduced which handles the sorting and
      filtering (as indicated by the checkboxes). This is backed by the slideshowModel
      whcih previously as only used for the configutation. The lists of slides and  unseen
      slides are dropped as now the slides that are shown are taken from the model.
      
      FEATURE: 186181
      FIXED-IN: 5.17.0
      
      Test Plan:
      {F6938259}
      {F6938260}
      {F6938261}
      {F6938263}
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D22121
      ea32a761
  11. 03 Apr, 2019 1 commit
    • Filip Fila's avatar
      [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts · 4516ab53
      Filip Fila authored
      Summary:
      Porting to Kirigami.FormLayout and using twinFormLayouts in order to ensure alignment with the main layout.
      
      NOTE: Vertical spacing is still clearly wrong, but I could fix that as well if someone could offer a suggestion on how to do it.
      
      Test Plan:
      D19932 needed before testing.
      
      Before:
      {F6707737}
      
      After:
      {F6707739}
      
      Before:
      {F6707742}
      
      After:
      {F6707740}
      
      Everything still worked.
      
      Reviewers: #plasma, ngraham, mart, hein
      
      Reviewed By: #plasma, ngraham, mart, hein
      
      Subscribers: hein, davidre, mart, abetts, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19873
      4516ab53
  12. 01 Apr, 2019 1 commit
    • David Redondo's avatar
      Allow single images to be excluded from the slideshow · b1ae890a
      David Redondo authored
      Summary:
      This allows to exlude single images from the slideshow by unchecking the little checkbox in the top right corner.
      Feature or todo?: If a folder is removed I don't touch the unchecked Slides. So the list could get very big but if a formerly removed folder is
      added again an excluded image will be excluded again.
      
      Test Plan:
      {F6684113}
      - Uncheck some images
      - They don't appear in the slideshow
      
      Reviewers: #plasma, #vdg, ngraham, davidedmundson
      
      Reviewed By: #plasma, #vdg, ngraham, davidedmundson
      
      Subscribers: davidedmundson, filipf, abetts, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19687
      b1ae890a
  13. 09 Mar, 2019 2 commits
    • David Redondo's avatar
      Image Wallpaper Slideshow - display the list of images that will be shown · 2003b267
      David Redondo authored
      Summary:
      This shows all the pictures inside the folders added to the Folders list. I also tried to make single pictures excludable via a checkbox on the thumbnail. This is the first time for me programming with QT/QML/Singals-Slots and I tried to use as much existing code as possible. The thumbnail view is the same as for single images and I simply subclassed the listmodel. However even if I tried to do everything like the code for slidePaths it doesn't work correctly. The checking/unchecking of images only applies on restart of plasmashell. Maybe it's a single mistake that is easily spotted by a more experienced programmer otherwise if the thumbnail view is accepted I can also revert all the checkbox stuff.
      
      FEATURE: 403703
      FIXED-IN: 5.16.0
      
      {F6595564}
      
      Reviewers: #vdg, ngraham, davidedmundson
      
      Reviewed By: #vdg, ngraham, davidedmundson
      
      Subscribers: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D18809
      2003b267
    • Laurent Montel's avatar
      Fix warning == vs === · 19144ab0
      Laurent Montel authored
      19144ab0
  14. 28 Jan, 2019 1 commit
  15. 18 Jan, 2019 1 commit
    • Nate Graham's avatar
      [wallpapers/image] Port wallpaper plugins (mostly) to QQC2 · 7e6d0c0b
      Nate Graham authored
      Summary:
      BUG: 400549
      FIXED-IN: 5.15.0
      
      Test Plan:
      On the lock screen KCM at 1.2x scale, before: {F6554037}
      
      After: {F6554040}
      
      All functionality continues to work on the lock screen and SDDM KCMs and desktop containment window.
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D18343
      7e6d0c0b
  16. 03 Dec, 2018 1 commit
    • Marco Martin's avatar
      Port to QQC2 and FormLayout · 76eba93b
      Marco Martin authored
      Summary: No big visible changes, but simplifies and modernizes the code
      
      Test Plan: used all functionality of the systray config dialog
      
      Reviewers: #plasma, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: ngraham, abetts, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17212
      76eba93b
  17. 18 Apr, 2018 1 commit
  18. 16 Apr, 2018 1 commit
    • Marco Martin's avatar
      update the wallpaper dialog to the new design · c66e998d
      Marco Martin authored
      Summary:
      update the wallpaper dialog to the same design as the new KCMS
      for consistency
      
      Test Plan:
      dialog loads with proper wallpaper selected, and both clicking on one
      works and the attached toolbuttons work too
      
      Reviewers: #plasma, #vdg, davidedmundson, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: davidedmundson, broulik, abetts, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D12148
      c66e998d
  19. 24 Mar, 2018 1 commit
  20. 23 Mar, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      Rename wallpaper translation catalogs to follow pattern · f945ad4b
      Friedrich W. H. Kossebau authored
      Summary:
      The wallpaper loading code expects the catalogs to follow the pattern
      "plasma_wallpaper_" + pluginid. While in config QML the domain needs
      to be explicitly set using i18nd, as the default textdomain is set to
      that of the config container, it is not needed in the wallpaper QML.
      
      While using a catalog with plasma_applet_* prefix works if setting
      the domain explicitly, the usage goes against the design of the
      naming patterns. So to give a good example and also properly marking
      the usage of the catalog, the names are switched.
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10850
      f945ad4b
  21. 09 Jan, 2018 1 commit
  22. 17 Nov, 2017 1 commit
  23. 05 Nov, 2017 1 commit
    • Nate Graham's avatar
      Change "Open..." to "Add Image..." in Wallpaper chooser · 1be6aecf
      Nate Graham authored
      Summary:
      Changes the button in the wallpaper chooser marked "Open..." to say "Add Image..". This matches the text style for the button in slideshow mode, which says, "Add Folder"
      
      Also added ellipses to "Add Folder"; it's now "Add Folder..."
      
      Test Plan:
      Tested in KDE Neon.
      
      Before:
      {F5473479}
      
      After:
      {F5473507}
      
      Reviewers: #plasma, broulik, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: aspotashev, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8658
      1be6aecf
  24. 24 Oct, 2017 1 commit
  25. 04 Oct, 2017 2 commits
  26. 15 Aug, 2017 1 commit
  27. 07 Aug, 2017 2 commits
  28. 14 Apr, 2017 1 commit
    • Eike Hein's avatar
      Fix losing wallpaper selection when clicking "Apply". · 1a26abe5
      Eike Hein authored
      Summary:
      Currently the selected wallpaper is deselected when the "Apply"
      button is clicked, as if no wallpaper is selected. This patch
      fixes that. I didn't understand what the original restoreIndex
      thing was trying to do by passing the count, so I gutted it and
      wrote code that makes more sense to me.
      
      Reviewers: #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D5440
      1a26abe5
  29. 23 Feb, 2017 3 commits
    • Marco Martin's avatar
      try harder to make the selected wallpaper visible · ff602030
      Marco Martin authored
      Summary:
      qml gridview don't have an official way to ensure the
      current index is visible when the view is first instantiated,
      the only way we have is to do positionViewAtIndex when we know the
      proper space has already been allocated (Component.onCompleted
      is way too early) we used to do that on onCountChanged, but that
      too seems to early sometimes, as the selected wallpaper
      is visible only sometimes, attaching it to onContentHeightChanged
      seems to be more reliable (for all branches)
      
      Test Plan: proper wallpaper is visible every time the window opens
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: hein, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4648
      ff602030
    • Marco Martin's avatar
      try harder to make the selected wallpaper visible · 0eab04a3
      Marco Martin authored
      Summary:
      qml gridview don't have an official way to ensure the
      current index is visible when the view is first instantiated,
      the only way we have is to do positionViewAtIndex when we know the
      proper space has already been allocated (Component.onCompleted
      is way too early) we used to do that on onCountChanged, but that
      too seems to early sometimes, as the selected wallpaper
      is visible only sometimes, attaching it to onContentHeightChanged
      seems to be more reliable (for all branches)
      
      Test Plan: proper wallpaper is visible every time the window opens
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: hein, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4648
      0eab04a3
    • Marco Martin's avatar
      try harder to make the selected wallpaper visible · ed2f9de7
      Marco Martin authored
      Summary:
      qml gridview don't have an official way to ensure the
      current index is visible when the view is first instantiated,
      the only way we have is to do positionViewAtIndex when we know the
      proper space has already been allocated (Component.onCompleted
      is way too early) we used to do that on onCountChanged, but that
      too seems to early sometimes, as the selected wallpaper
      is visible only sometimes, attaching it to onContentHeightChanged
      seems to be more reliable (for all branches)
      
      Test Plan: proper wallpaper is visible every time the window opens
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: hein, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4648
      ed2f9de7
  30. 25 Jan, 2017 1 commit
  31. 08 Jan, 2017 1 commit
    • Kai Uwe Broulik's avatar
      [Image Wallpaper] Simplify width/height management · f6ce9149
      Kai Uwe Broulik authored
      Directly expose "targetSize" as property. The wallpaper is already initialized with
      the correct size for some time now but the fact that we had two properties width and height
      in there had it still do unneccessary work when it emitted "sizeChanged(2560, 0)" and
      then the final "sizeChanged(2560, 1440)" afterwards.
      
      Also, I didn't really see a point in storing the wallpaper size in its config,
      it's overwritten by the wallpaper anyway and only used in the wallpaper config dialog
      for the aspect ratio. We can just ask the view directly then.
      
      BUG: 374689
      FIXED-IN: 5.9.0
      
      Differential Revision: https://phabricator.kde.org/D4001
      f6ce9149
  32. 29 Nov, 2016 1 commit
    • Marco Martin's avatar
      Select correct index without timer · 5434e4bc
      Marco Martin authored
      Summary:
      select the correct index upon loading when the count changes.
      this removes the flicker at startup and the view is at the correct
      wallpaper since the first frame. Also, now when a wallpaper is
      downloaded with knewstuff, the old wallpaper stays selected,
      it doesn't get resetted to the first wallpaper anymore
      
      Test Plan:
      open wallpaer dialog, no more flicker
      install a new wallpaper, the currently selected one stays selected
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3532
      5434e4bc