1. 23 Oct, 2020 1 commit
  2. 11 May, 2020 2 commits
  3. 01 May, 2020 1 commit
  4. 14 Apr, 2020 1 commit
  5. 07 Feb, 2020 1 commit
  6. 21 Jan, 2020 1 commit
  7. 22 Dec, 2019 1 commit
    • Kai Uwe Broulik's avatar
      [Notifications] Add quick reply feature · 5f6f4634
      Kai Uwe Broulik authored
      This adds a quick reply feature with a text field inline in the notification popup.
      An action named "inline-reply" will spawn the text field and a NotificationReplied signal is emitted then.
      There's additional kde hints for changing the placeholder text (defaults to "Type a reply..."),
      submit button text (defaults to "Send") and submit button icon name (defaults to "document-send",
      that paper aeroplane icon).
  8. 20 Dec, 2019 1 commit
    • Kai Uwe Broulik's avatar
      [Notifications] Add hint for a notification being response to explicit user interaction · 8dc1db04
      Kai Uwe Broulik authored
      This can be useful for notifications that confirm direct user interaction, such as successful Bluetooth pairing,
      Screenshot creation, or plasmoid removal.
      It only overrules filtering based on urgency, disabling notifications for that application altogether will still hide them.
      Such a notification also won't increase the unread counter as it can be assumed when they do something, e.g. click on "Pair",
      they will notice that the pairing progress dialog went away and a confirmation notification is shown.
      Differential Revision: https://phabricator.kde.org/D25935
  9. 16 Sep, 2019 1 commit
    • Kai Uwe Broulik's avatar
      [Notifications] Introduce dedicated "read" state for notification · 083e9409
      Kai Uwe Broulik authored
      Currently, a notification is considered "unread" when it was created or updated after the last time the user opened the history.
      To alleviate this, when the notification popup is hovered, e.g. because the user wanted to drag an image out, select some text,
      or open the "More" menu, it is considered read. It will still end up in the history but will not needlessly show the "unread notification" bell icon.
      Moreover, job finished notifications are always considered read, as they are either from long-standing jobs which the user is likely aware of,
      or confirmation of short tasks the user doesn't need explicit confirmation about. For example, extracting an archive in Dolphin,
      I get an "Extracting (Finished)" but I don't want to explicitly acknowledge that notification because I can just enter the folder that was just created in Dolphin.
      This surely doesn't fix the underlying problem of notification expiration and history, and the user might just interact wiht some
      tray icons or the clock and not actually deal with the notification popup but this is imho an acceptable stopgap until a proper
      solution is found, which won't happen in time for Plasma 5.17 anyway.
      Differential Revision: https://phabricator.kde.org/D23977
  10. 23 Jun, 2019 1 commit
  11. 29 May, 2019 2 commits
  12. 13 May, 2019 1 commit
  13. 07 May, 2019 1 commit
  14. 06 May, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Address review comments and other clean up · 86260aba
      Kai Uwe Broulik authored
      * Use index(n, m, parent) instead of parent.child(n, m)
      * Update unity count when job is closed without stopping it first
      * Iterate whole dataChanged range [topLeft, bottomRight] when group is resolved
      * Generate roleNames from meta object
      * Use checkIndex()
      * Increase default timeout for notifications with thumbnail
      * Improved keyboard nav, support Home/End, let Return open thumbnail
  15. 12 Apr, 2019 1 commit
    • Kai Uwe Broulik's avatar
      More cleanups and finish · 789eedc5
      Kai Uwe Broulik authored
      * Ship some more default rules in plasmanotifyrc
      * Improved do not disturb menu (add "for 4 hours" and "until disabled")
      * Expand unread notifications by default, overall improved expansion/collapse handling
      * Show unread count in panel and reset when plasmoid is closed again
      * Move notification sanitizer and its test from dataengine to lib
      * Load pixmaps into model also for files and limit their physical size
      * Enforce maximum limit for notifications (1000...)
  16. 04 Apr, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Final touches · 2d1b66fb
      Kai Uwe Broulik authored
      - Rename some of the classes:
        NotificationServer -> Server (there's namespaces, you know)
        NotificationModel -> NotificationsModel (so it's plural like JobsModel)
      - Introduce NotificationGroupingCollapse
      - Wire up PulseAudio-qt for eventual notification silence in dnd mode
      - Touch up notification looks
        - Add indentation and "line" for grouped plasmoids
        - Rethink "show more" button to be at the end
        - Fix buttons overlapping
        - Remove NotificationDelegate item and do those few adjustments in FullRepresentation
      - Cleanup job details, handle when processed > total
      - Use States {} more
      - Show low urgency popups by default but don't add them to history
  17. 03 Apr, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Implement do not disturb mode and grouping collapse · 9cee05eb
      Kai Uwe Broulik authored
      - Rework compact representation animations a bit
        For some reason they often got stuck
      - Implement do not disturb mode for applications
      - Add fallback timeout to ensure notifications eventually timeout
        Otherwise when disabling dnd mode you will get spammed
        and we would also keep apps running indefinitely waiting for the notification to close
      - Install plasmanotifyrc with some sane defaults
        So far only lets Spectacle show its screenshot notifications in dnd mode
      - Introduce Closable role rather than hardcoding that behavior everywhere in the view
      - Better app identification/grouping for jobs
      - Be more lenient about app identification (firefox will match Firefox, too)
      - Cleanups
  18. 02 Apr, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Implement do not disturb mode, more history work, cleanup · 54b4fc09
      Kai Uwe Broulik authored
      - Add basic do not disturb mode
        Can set a time until it enabled, persisted across reboots
        Whitelist for apps missing right not
        Inhibition API not wired up yet
      - d-pointer JobDetails
      - Use KFilePlacesModel for prettier destUrl reporting "Copying to Home"
      - Expose default action in history as button
      - Improved right-to-left language support
      - Let NotificationServer just lurk (without registering a service)
      - Catch when plasmoid is deleted and stick to another one
  19. 01 Apr, 2019 2 commits
    • Kai Uwe Broulik's avatar
      Completely wire up old dataengine and further touches · 723b6d13
      Kai Uwe Broulik authored
      - Old dataengine is fully functional now
        Except the inhibition stuff but I'm not sure if this is worth keeping the way it is
      - "More" menu opens on press now and highlights
      - Invoking any action closes the notification now
        KNotification explicitly does that for us but e.g. GTK does not
      - Add clear button for history
      - Restore kbroadcastnotification support
      - Allow forgetting seen application (for KCM)
      - Let users "create" notifications by calling NotificationServer::add
      - When no application name is provided look up the sender's process name as last resort
      - Add kdebugsettings categories file
    • Kai Uwe Broulik's avatar
      Improvements and cleanups all over the place · 1c4de1d4
      Kai Uwe Broulik authored
      - Improve compact reprsentation
      - Keep popup open during interaction (context menu, drag)
      - Improve "ago" label (e.g. show "Last Sunday")
      - Improve group visuals (still pretty much WIP)
      - Hide popups when interacted (opened file, triggered file action, etc)
        Closing when having invoked an action isn't implemented yet but is probably neccessary
      - Make autohide job popup setting work
      - Set critical AlwaysOnTop (requires KWin patch)
      - Improve error handling in ThumbnailStrip
        Show file icon if thumbnail generation failed instead of a blank space
      - Add heuristic for popup placement and make custom setting work
      - Add deviceName and displayApplicationName (for KDE Connect)
        So it can show from which device and which app this notification originally came from
      - Improved service discovery (and defaultComponent handling)
        Quite a few notifications, e.g. DrKonqi crashes are in plasma_workspace.notifyrc
        When we get an event like this, show the original app instead
      - Make blacklist for popup and history work
      - Add "lastRead" property for "unread" handling vs "expired" (latter likely to be dropped)
      - Add sortMode so history is strictly sorted by date (it's grouped after all)
      - Begin work on do not disturb UI in plasmoid
  20. 26 Mar, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Begin on inhibition / do not disturb stuff · eab83389
      Kai Uwe Broulik authored
      - Also moe the NotificationPopup item back to the root folder
      - Implement tracking of unknown apps, ie. once an app shows a notificaton it will show up
        in the KCM so it can be configured
      - Make blacklisting of notification popups (via setting in KCM) work
      - Start on inhibition stuff (DBus API proposal sent to XDG mailing list)
  21. 25 Mar, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Begin settings stuff and further cleanup · ff9ca8e4
      Kai Uwe Broulik authored
      - Introduces a Settings item that can be used to query and write settings
        Used from both the applet and the KCM and in the future Task Manager and others
      - Wire up delegate to make FullRepresentation somewhat work
      - Fix text selection in NotificationItem (workaround QQC1 ScrollView bug)
      - Make model writable where it makes sense (rather than having a dedicated setter)
      - Let JobsModel also notice jobs that were present at the time of its creation
  22. 23 Mar, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Cleanup, export, and start on settings and inhibition API · 79427e3d
      Kai Uwe Broulik authored
      - Cleanup, pimpl NotificationServer and Notification for export
      - Wire the old dataengine up to use it for compat:
        it shows notifications but is otherwise pretty broken right now
      - Start writing kconfigxt and Settings code (no real code yet)
      - Add a Inhibition DBus interface (no actual server-side code yet)
      - Group notifications by application
        Pretty much tasks grouping model from libtaskmanager slightly adjusted
      - Let widget take full height when expanded in vertical panel "side bar usecase"
      - Fix bugs here and there
  23. 21 Mar, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Implement more missing stuff and be more spec-compliant · 3251c280
      Kai Uwe Broulik authored
      - Support replacing notifications properly
        - Now that we have nice models we can finally do the replacing in the way the spec
        asks for "atomically (ie with no flicker or other visual cues)"
      - Catch some more cases in notification details text (trash:/ stuff)
      - Prefer notifyrc name over desktop entry name in case a service within another app sends
        an event (e.g. Discover notifier in Plasma, KNotification automatically sends desktop-entry
        of the parent app)
      - Implement x-kde-urls thumbnailer with drag and drop and fancy blur
        Originally intended to be able to show multiple files but in practise only used for
        single pictures, so the code is significantly simplified for that usecase
      - Add "Open" feature for finished job notification, offers a context menu as well with
        all the KFileItemActions (component from the Thumbnailer)
      - Copy description labels to clipboard
        Once menu opens the update is paused so the text you copy is what you see
      - Fixup sanitizer so we can properly collapse notifications without body text
      ... and more
  24. 19 Mar, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Implement all the things · 35c575be
      Kai Uwe Broulik authored
      - Notification action buttons
      - Custom icon pixmaps in notifications
      - Popup handling
      - Notification urgency (low isn't shown as popup TBD, critical always no matter what)
      - History stuff (only expired notifications end up there, none that were closed or revoked)
      - Text selection and copy for body text
      - Basic tray icon support
      and many other things
      Application jobs are shown as part of regular notifications:
      - They show up as little popup that can be hidden in the history
      - When finished progress popup turns into a notification
      There's still some glitches and missing features, notably
      - Screenshot thumbnails
      - "Open" functionality for finished jobs
      - History layout
      - code cleanup
      - and basically every configuration option
  25. 27 Jul, 2018 1 commit
    • Kai Uwe Broulik's avatar
      WIP: libnotificationmanager and new notification applet · 73c55284
      Kai Uwe Broulik authored
      libnotificationmanager provides a proper notification model situation similar
      to libtaskmanager. There is also a new notification applet implementing the
      suggestions and VDG mockups in the wiki
      NOTE: the notification dataengine is defunct in this branch, so while the applet
      (for now) installs as "new notifications", the old applet will stop working when
      you use this. The dataengine will eventually be restored (famous last words)
      for compatibility but using the NotificationServer singleton introduced in
      The applet can show notifications, they expire, can be closed, and their
      default action invoked. Still heavily WIP and API subject to change.
      [1] https://community.kde.org/Plasma/Notifications