1. 21 Jan, 2021 1 commit
  2. 11 Jan, 2021 1 commit
  3. 29 Dec, 2020 1 commit
  4. 07 Nov, 2020 1 commit
  5. 05 Nov, 2020 2 commits
  6. 28 Sep, 2020 1 commit
    • andy salerno's avatar
      [applets/systemtray] Only show back button when the hidden items view has any items · eb411f7b
      andy salerno authored and Nate Graham's avatar Nate Graham committed
      Today on master, the system tray menu *always* shows a back button, regardless of the context.
      
      But when all items are visible, the back button simply acts as a "close" button, since we are
      only "one layer" deep and there is nowhere to go back to. This commit fixes that issue by only
      displaying the back button hen the hidden items view has any items in it such that you could go
      back to it.
      eb411f7b
  7. 14 Jul, 2020 1 commit
  8. 27 Jun, 2020 1 commit
  9. 25 Jun, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Add a button in the hidden view to show the config window · 80c737cb
      Nate Graham authored
      Without this, the only way to show the config window for the System Tray
      itself is by right-clicking, and as we all know, this is a no-no because
      many users don't right-click on stuff and you can't right-click at all on
      touch and we want our stuff to work on convertible devices with
      touchscreens. So let's add a big beautiful button that people can click
      on and touch.
      80c737cb
  10. 10 Jun, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Use a grid for the hidden items view · 1669197b
      Nate Graham authored
      This improves the applet in a variety of ways:
      - Much more touch friendly than the current skinny list view
      - Many more items can be displayed without needing to scroll
      - Substantial code simplification
      - UI improvement from no longer sometimes showing an awkward vertical
        strip of icons that was invisibly scrollable but some of whose items
        ate scroll events, and which pushed the header over to the left in a
        somewhat random-looking way
      
      BUG: 402681
      FIXED-IN: 5.20
      1669197b
  11. 21 May, 2020 3 commits
  12. 12 May, 2020 1 commit
  13. 26 Apr, 2020 1 commit
    • Niccolò Venerandi's avatar
      Add footer support to systray · 0f28094f
      Niccolò Venerandi authored
      Summary: This adds a footer element that will replace with a possible footer that the contained plasmoid could have, given that they are using a Page.
      
      Test Plan: {F8258401}
      
      Reviewers: ngraham
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10470
      
      Differential Revision: https://phabricator.kde.org/D29142
      0f28094f
  14. 16 Apr, 2020 1 commit
    • Niccolò Venerandi's avatar
      Make headings of systray and applet merge · 1a6b40cb
      Niccolò Venerandi authored
      Summary:
      When the applet is a page with a plasmoidHeading as header, merge it with systray one.
      {F8215920}
      
      The only big problem is that it looks bad when you open said applet while in sidebar view, see:
      {F8215916}
      
      I'd like to solve that by removing the sidebar and adding a back button, but that would be for another patch in the future.
      
      Test Plan: To be tested together with D28467
      
      Reviewers: #plasma, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: mart, manueljlin, ognarb, ngraham, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10470
      
      Differential Revision: https://phabricator.kde.org/D28575
      1a6b40cb
  15. 23 Mar, 2020 1 commit
    • Nate Graham's avatar
      Make Pin buttons consistently sized in System Tray and Clock pop-ups · 3a44e360
      Nate Graham authored
      Summary:
      The Pin buttons in the System Tray and Clock pop-ups are very small. This has
      always felt slightly odd to me, and the recent change to add a defined header
      area for the System Tray pop-up makes it even odder in my opinion, as the icon
      is now much smaller than the area it visibly inhabits. This patch makes both icons
      in both applets use the standard size with no local overrides. The clock pop-up's
      pin button is ported to PC3 in the process.
      
      Depends on D28228
      
      Test Plan:
      Before: {F8194101}
      After: {F8194100}
      
      Reviewers: #vdg, #plasma, ognarb, mart
      
      Reviewed By: #vdg, #plasma, ognarb, mart
      
      Subscribers: mart, ndavis, broulik, ognarb, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10470
      
      Differential Revision: https://phabricator.kde.org/D28211
      3a44e360
  16. 17 Mar, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Fix expanded representation's internal margins · 695fec4a
      Nate Graham authored
      Summary:
      This is a pre-existing problem, but became much more visible with D27189 (thus exposing
      one of the reasons why I like visually separating dissimilar elements so much).
      Essentially the dialog's bottom and right margins were not being properly mirrored on
      the top and left, leading to the applet's content view looking off-center. Various apps
      were locally adding their own extra top margins to compensate for this, which can be
      removed once this patch lands.
      
      This patch fixes that by explicitly using the default dialog margins for those edges.
      
      I will submit follow-up patches to fix applets that were adding extra padding that is
      now unnecessary.
      
      Test Plan:
      It was especially noticeable with D27160.
      
      Before: {F8180273}
      
      After: {F8180272}
      
      Reviewers: #vdg, #plasma, cblack
      
      Reviewed By: #vdg, #plasma, cblack
      
      Subscribers: cblack, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28089
      695fec4a
  17. 14 Mar, 2020 1 commit
    • Niccolò Venerandi's avatar
      Created a top area based on widgets/toparea.svg · f4195688
      Niccolò Venerandi authored
      Summary:
      This add a top area based on the current theme. If the file is not in the current theme, said area is not shown.
      
      Problem: the header is moved to the right by the Svg element, and I'm not sure how to align it correctly anymore.
      
      Depends on D27695
      
      Test Plan: {F8088058}
      
      Reviewers: #vdg, #plasma, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: mart, ngraham, ndavis, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10470
      
      Differential Revision: https://phabricator.kde.org/D27189
      f4195688
  18. 04 Mar, 2020 1 commit
  19. 06 Feb, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Bunch of fixes and improvements in QML · a79f80ed
      Konrad Materka authored
      Summary:
      Few unrelated fixes, bunched together:
      * move some code from main.qml to PlasmoidItem where it belongs
      * easier to understand item size calculation
      * where possible, replace parent.parent comparisons with a property in AbstractItem
      * get rid of marginHints
      * Qt 5.14 compatibility fix in configuration
      * formatting etc
      
      Test Plan: Everything should work as before, this is just refactoring.
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27085
      a79f80ed
  20. 09 Jan, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Set maximum size to block tiling · 4a65dcef
      Konrad Materka authored
      Summary:
      System tray dialog/popup can be tiled. This should not be allowed, in this case expanded representaiton should have fixed size. When tiled, it is no longer possible to restore original size.
      This also applies to other plasmoids.
      
      BUG: 386551
      FIXED-IN: 5.18.0
      
      Test Plan:
      1. Open any applet from system tray (for example Clipboard or hidden items)
      2. Use shortcut to tile window (by default Meta + Left/Righ/...)
      3. Applet will change size and tile at the borded of the screen
      4. Expected:
      a) before fix: allowed and not possible to restore size
      b) after fix: not allowed or restores size on next open
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26545
      4a65dcef
  21. 02 Dec, 2019 1 commit
  22. 29 Nov, 2019 1 commit
  23. 08 Nov, 2019 1 commit
  24. 03 Nov, 2019 1 commit
    • Filip Fila's avatar
      [applets/systemtray] Rewrite popups with layouts · 5b3f5bd9
      Filip Fila authored
      Summary:
      Currently the code that draws plasmoid popups utilizes an anchor based approach.
      
      I think layouts are a more elegant solution so this patch makes use of them.
      
      Test Plan:
      {F7616902}
      
      {F7616901}
      
      {F7640510}
      
      Reviewers: #plasma, #vdg, ngraham, mart
      
      Reviewed By: #plasma, #vdg, ngraham, mart
      
      Subscribers: safaalfulaij, manueljlin, ognarb, ngraham, kmaterka, mart, GB_2, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24720
      5b3f5bd9
  25. 07 Jul, 2019 1 commit
  26. 20 May, 2019 1 commit
    • ivan tkachenko's avatar
      Fix system tray UI/UX & refactor · a73aa330
      ivan tkachenko authored and Nate Graham's avatar Nate Graham committed
      Summary:
      System tray widget had the following UX problem:
      Icons are laid out in a Flow QML layout, using minimal amount of
      space, thus not filling the height/width of the task bar. In other
      words: user can only click directly on an icon, not over or under it.
      
      Consider the following scenario:
      
      Given icon size X and task bar of height 1.5 * X located at the bottom;
      User moves pointer down to the limit and tries to click the icon.
      Expected outcome: applet is activated.
      Actual outcome: nothing happens, because icon (together with mouse
      area) floats slightly above the bottom.
      
      Which is inconvenient, especially when most other widgets tend to fill
      up the space.
      
      This patch fixes aforementioned problem by refactoring layouts using
      modern GridLayout, RowLayout et al., so that icons are arranged in
      rows and columns based on their number, and each one fills up its
      cell. I also made a handful of minor internal refactorings and fixes.
      Unfortunately, due to tight coupling, almost all files needed changes
      anyway.
      
      Special note on 'CompactApplet.location': it didn't seem to affect
      anything at all, so removed it.
      
      At the end of the day no visual changes should be noticeable. Layout
      works in both vertical and horizontal form-factor an all four sides of
      the desktop.
      
      Test Plan: Please, check whether 'LayoutMirroring' works properly.
      
      Reviewers: #vdg, #plasma, broulik, mart, hein, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19745
      a73aa330
  27. 14 Dec, 2018 1 commit
  28. 12 Dec, 2018 1 commit
  29. 23 Feb, 2018 1 commit
    • Marco Martin's avatar
      parent full representation to the proper window at start · b17fa4be
      Marco Martin authored
      Summary:
      this avoids some unwanted scene changes and speeds up the
      first open a bit, also initialize the size of the dialog main item
      so there is a resize less when the Dialog is first shown
      
      Test Plan:
      difference in show time is already visible, tough still not perfect,
      something else needs to improve as well
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: apol, broulik, hein, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10692
      b17fa4be
  30. 13 Oct, 2017 1 commit
  31. 08 Jun, 2017 1 commit
  32. 04 Apr, 2017 1 commit
    • David Edmundson's avatar
      Keep system tray sidebar y position independent of current applet heading · 882fc8d0
      David Edmundson authored
      Summary:
      In the system tray we have a header at the top and the icons on the
      left.
      
      When there is no applet selected we want the icons to take up the full
      width, because of this they have to start off under the title.
      
      When an applet is selected we want these icons to dock to the left, but
      not change their y position. The title then becomes the title of the
      active applet.
      
      If the active applet's title wraps this results in the icons moving all
      over the place. See image in bug report.
      
      This patch uses two text fields and toggles visibility so that we can
      always align the icons to a consistent point
      
      BUG: 378194
      
      Test Plan:
      Opened system tray with the arrow
      Clicked on an applet and back
      Opened system tray by clicking on applet
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D5300
      882fc8d0
  33. 30 Jun, 2016 1 commit
  34. 10 May, 2016 1 commit
  35. 19 Jan, 2016 1 commit
    • David Edmundson's avatar
      Remove completely duplicated function · e67f33a8
      David Edmundson authored and David Edmundson's avatar David Edmundson committed
      Remove almost completely duplicated function.
      One was used for right clicking on expanded items, the other for full
      compact items.
      
      A missing action for expanded items is added so the two menus are now
      consistent.
      
      Global co-ordinates are used as args for menus everywhere so we can
      share the mapping code SNIs currently use.
      
      REVIEW: 125973
      e67f33a8
  36. 13 Dec, 2015 1 commit
  37. 26 Oct, 2015 1 commit