1. 31 Jan, 2020 2 commits
    • Kai Uwe Broulik's avatar
      [System Tray] Initially set correct category for plasmoids · 50f9c3cf
      Kai Uwe Broulik authored
      The category was only used for proper Plasma::Applet instances but not unloaded plasmoids from pure metadata.
      
      BUG: 416947
      FIXED-IN: 5.18.0
      
      Differential Revision: https://phabricator.kde.org/D27068
      50f9c3cf
    • Kai Uwe Broulik's avatar
      [Task Manager] Remove strict URL handling · bb573b83
      Kai Uwe Broulik authored
      The code tried hard to ignore garbage URLs, as Qt is quite lenient, e.g. QUrl("Garbage Url") is still valid.
      There is no way to change the strictness of a QUrl after creation,
      so the code would enforce it by doing QUrl strictUrl(inputUrl.toString(), QUrl::StrictMode).
      However, toString() defaults to PrettyDecoded which avoids percent-encoding and keeps spaces
      in tact which is not a valid thing to have in a strict URL.
      Effectively, we want to ensure a URL is either a valid path to a local file,
      or one of the special applications (for menu ids), or preferred for preferred applications, like web browser,
      
      BUG: 385727
      FIXED-IN: 5.18.0
      
      Differential Revision: https://phabricator.kde.org/D26941
      bb573b83
  2. 30 Jan, 2020 6 commits
  3. 29 Jan, 2020 4 commits
    • Marco Martin's avatar
      search for a default wallpaper in lookandfeel · ecea557f
      Marco Martin authored
      Summary:
      now look and feel packages can specify a default image wallpaper.
      when a new containment is created at first plasma start or at activity creation
      search for a default wallpaper inthe order:
      look and feel package
      if fails, from the plasma theme
      
      we are sure to find a default after it as if neither of those specify one,
      the wallpaper specified by the breeze plasma theme (Next) will be used
      
      D21225 takes care of setting the wallpaper when a lnf theme is selected by the kcm
      
      Test Plan:
      tested to start plasma with an empty config file with different themes
      that do or don't include wallpapers
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: kossebau, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21226
      ecea557f
    • Kai Uwe Broulik's avatar
      [startkde] Export LC_TIME again · bc34f232
      Kai Uwe Broulik authored
      BUG: 416670
      FIXED-IN: 5.18.0
      
      Differential Revision: https://phabricator.kde.org/D26981
      bc34f232
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 9d18ac6b
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      9d18ac6b
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · ebb2761b
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      ebb2761b
  4. 28 Jan, 2020 1 commit
  5. 27 Jan, 2020 1 commit
  6. 26 Jan, 2020 2 commits
    • Konrad Materka's avatar
      [SystemTray] Fix model update in settings (missing icon) · 3ba955f4
      Konrad Materka authored
      Summary:
      Fixes a bug, when system tray settings is opened and new application is opened, view is not correctly refreshed and icon is missing. Caused by duplicated role names. Related to: D26586
      
      BUG: 416400
      FIXED-IN: 5.18.0
      
      Test Plan:
      1. Open system tray settings
      2. Open an app with systray icon
      Expected:
      Icon, title etc are correctly rendered.
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
      
      Reviewed By: #plasma_workspaces, #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26850
      3ba955f4
    • Konrad Materka's avatar
      [SystemTray] Remove scrollbar paddings · 82d7fd7a
      Konrad Materka authored
      Summary: Removes additional paddings. Not needed when scrollbar is no longer overlaying content. See: D26530
      
      Test Plan:
      1. Open configuration window
      2. No paddings
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, nicolasfella
      
      Reviewed By: nicolasfella
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26924
      82d7fd7a
  7. 22 Jan, 2020 2 commits
  8. 21 Jan, 2020 3 commits
  9. 20 Jan, 2020 1 commit
  10. 19 Jan, 2020 2 commits
  11. 18 Jan, 2020 1 commit
  12. 16 Jan, 2020 8 commits
  13. 15 Jan, 2020 7 commits
    • Tranter Madi's avatar
      Fix wallpaper destination path · 2212a9af
      Tranter Madi authored
      Summary:
      - Correct the destination path when downloading images.
      - Switch from FileCopyJob to CopyJob to allow showing file overwrite dialog.
      
      BUG: 379469
      
      Test Plan: Drop files from Firefox to the desktop to set the wallpaper successfully.
      
      Reviewers: #plasma, mart, ngraham
      
      Reviewed By: #plasma, mart, ngraham
      
      Subscribers: mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26525
      2212a9af
    • Konrad Materka's avatar
      [SystemTray] Rework system tray settings · e2bfeb16
      Konrad Materka authored
      Summary:
      Combines settings of SNI icons and plasmoids in one list. Ability to disable whole section is removed.
      
      Initial idea was proposed by Nicolas Fella (D22176).
      
      BUG: 360307
      FIXED-IN: 5.18.0
      
      {F7880936}
      
      Test Plan:
      1. Disable/enable plasmoids
      2. Set Shown/Hidden for plasmoid
      3. Set shortcut for plasmoid
      4. Previously hidden categories are shown
      5. Show all icons and revert
      6. Set Auto/Shown/Hidden for SNI icons
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, mart
      
      Reviewed By: #plasma_workspaces, #plasma, ngraham, mart
      
      Subscribers: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26586
      e2bfeb16
    • David Edmundson's avatar
      [sddm-theme] Don't have a broken reveal password button · 505ce992
      David Edmundson authored
      Summary:
      sddm-greeter will have a button for the reveal password button, but due
      to sddm-greeter not loading a relevant QPT has no code to force it to
      load the breeze icon set.
      
      Without the breeze icon set, the clear button does not show.
      
      There are ways to solve this, but none are trivial or reliable.
      
      I threatened to do a revert in 5.12 (https://phabricator.kde.org/D9040)
      but the bug has still not been fixed since.
      
      BUG: 396039
      CCBUG: 387418
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26675
      505ce992
    • David Edmundson's avatar
      [kcms/feedback] Fix default button not showing · e1324b0f
      David Edmundson authored
      Reviewers: ngraham
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26679
      e1324b0f
    • David Edmundson's avatar
      [kcms/feedback] Implement setRepresentsDefaults · 1f75ac80
      David Edmundson authored
      Test Plan:
      Moved slider
      Defaults button enabled/disabled appropriately
      
      Reviewers: #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: meven, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26680
      1f75ac80
    • David Edmundson's avatar
      [kcms/feedback] Fix slider value · e5ef7ea3
      David Edmundson authored
      Summary:
      If the kcm's property changes externally we don't update the slider
      after the initial load, which is before KConfigModule::load which actually sets
      the property.
      
      Whilst there is an alternative fix calling load() a second time, we need
      this anyway for default and reset buttons to work correctly.
      
      I also think the original code was broken, I don't see why we would map
      the value back to modeOptions[idx], we want the slider value to be the
      index of the array, not the enum value. They just happen to be the same.
      
      Test Plan: Opened KCM changed it, opened KCM repeat
      
      Reviewers: #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26678
      e5ef7ea3
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 4cb2eae9
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      4cb2eae9