1. 17 Oct, 2019 1 commit
  2. 09 Mar, 2019 1 commit
  3. 17 Jan, 2019 1 commit
    • Thomas Surrel's avatar
      [Device Notifier] Add a button to unmount all devices · 81db7443
      Thomas Surrel authored
      When at least two removable devices are mounted, a button shows
      up that will allow to unmount all mounted removable devices.
      This is convenient for removable drives with several partitions,
      each of which have to be unmounted to be able to safely plug the
      device out.
      FEATURE: 395644
      Test Plan:
      Plug and mount two devices.
      Click on the new 'unmount all' button.
      Reviewers: #plasma, #vdg, ngraham, broulik
      Reviewed By: #plasma, #vdg, ngraham, broulik
      Subscribers: abetts, broulik, ngraham, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D16212
  4. 09 Jan, 2019 1 commit
    • Thomas Surrel's avatar
      [Device Notifier] Restore busy indicator · a7b2ecdb
      Thomas Surrel authored
      This patch fixes two issues:
      - the 'state' of the device now propagates correctly, that makes the busy indicator be displayed again, device emblems are also updated correctly
      - there is no more delay between the moment when the device is actually mounted and the moment the device notifier says it is. The worst case used to be 5 seconds.
      BUG: 354321
      BUG: 399986
      Reviewers: #plasma, #vdg, broulik, bruns, ngraham, davidedmundson
      Reviewed By: #plasma, #vdg, ngraham, davidedmundson
      Subscribers: mart, cfeck, ngraham, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D16170
  5. 08 Oct, 2018 1 commit
    • Thomas Surrel's avatar
      [Device Notifier] Auto-hide popup after device is unmounted · 58188935
      Thomas Surrel authored
      When unmounting a removable device from dolphin, the device notifier
      will popup saying the device can now be safely removed. But the popup
      never auto-hides.
      Test Plan:
      Plug a USB pen drive
      Unmount it from dolpin
      Device notifier should popup and hide itself after 3 seconds
      Reviewers: #plasma, #vdg, broulik
      Reviewed By: #plasma, broulik
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D16045
  6. 24 Sep, 2018 1 commit
    • Stefan Brüns's avatar
      [Device Notifier] Avoid accessing attributes of stale UDIs · 61b2b173
      Stefan Brüns authored
      When a Solid device is removed (e.g. a CD is ejected) the notifier tries
      to read the attributes although the Source for the UDI has just vanished.
      Fixes several QML error messages, i.e. "TypeError: Cannot read property
      '...' of undefined" and "Unable to assign [undefined] to QString".
      Apparently these errors also have the effect of items showing outdated
      state, i.e. optical media still being shown after ejecting it.
      CCBUG: 394348
      Test Plan:
      1. insert optical medium
      2. eject
      Without the changes, the item was stuck
      Now, the item is removed as soon as the medium is ejected
      Also, no more errors are logged for the devicenotifier
      Reviewers: #frameworks, broulik
      Reviewed By: broulik
      Subscribers: ngraham, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D15687
  7. 01 Mar, 2018 1 commit
    • Marco Martin's avatar
      auto hide popup when it opened itself · 2da603f9
      Marco Martin authored
      when the device notifier pops up automatically, leave it open
      if there is no user activity, if there is any, close after around
      3 seconds. Suspend the countdown if the notifier window either has
      focus or the mouse cursor is over it, leaving the user the time to
      go interact. if it doesn't have focus and the mouse leaves, resume
      the countdown
      replaces D10591
      Test Plan:
      tested for a while in a real world usage, it behaves in a fairly natural
      Reviewers: #plasma, broulik
      Reviewed By: #plasma, broulik
      Subscribers: ngraham, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D10921
  8. 21 Sep, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Device Notifier] Only ever pop up if device is visible in the list · b28ea53b
      Kai Uwe Broulik authored
      When a device notification arrives, such as "you can now safely unmount" or "failed to unmount"
      device notifier would unconditionally open showing an empty list.
      Since we now show device notifications only connected to the device they're about, it makes no
      sense to expand it for invisible devices. Applications where mounting or unmounting can fail
      for non-removable devices, like Dolphin, already show the error message within the UI anyway,
      making the popup redundant.
      BUG: 368894
      FIXED-IN: 5.8.0
      Differential Revision: https://phabricator.kde.org/D2823
  9. 01 Jul, 2016 1 commit
  10. 15 Jun, 2016 1 commit
  11. 13 Jun, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Device Notifier] Be more declarative · 6c0b1e54
      Kai Uwe Broulik authored
      Instead of having a bunch of handlers in various places messing with various settings,
      try to use declarative bindings where possible.
      * Remove separate passive timer, instead re-use the pendingDelegateRemoval property
        which has its own timer. This way, when a device is unmounted, device notifier stays
        active until the notification has cleared, however, when the device is yanked out manually,
        it disappears right away
      * Don't break binding on Plasmoid.active to ensure its state is always proper depending on
        whether a device or not is present (the linked bug)
      * Create tooltip declaratively rather than imperatively
      BUG: 362992
      FIXED-IN: 5.7.0
      Differential Revision: https://phabricator.kde.org/D1793
  12. 07 Jun, 2016 1 commit
  13. 24 Jan, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Device Notifier] Provide inline feedback · 1ed7209f
      Kai Uwe Broulik authored
      Instead of showing a detached status bar with the device name, show the message
      below the device in the list.
      When removing a device, device notifier will pop up and a "You can now safely remove
      this device" message will show up with a highlight gradually fading away until 5 seconds
      later the device is removed from the list.
      REVIEW: 126688
  14. 09 Jan, 2016 1 commit
  15. 07 Oct, 2015 2 commits
  16. 17 May, 2015 1 commit
  17. 25 Nov, 2014 1 commit
  18. 07 Nov, 2014 1 commit
  19. 16 Jun, 2014 1 commit
  20. 12 Jun, 2014 1 commit
    • Marco Martin's avatar
      don't expand on not "added" devices · 36e6d89c
      Marco Martin authored
      behavior from plasma1: the engine has an "added" value in devices
      if false, means the device was already there when plasma started
      therefore the applet shouldn't expand itself
      this should fix the systray annoyingly opening
      itself on each plasma startup
  21. 02 Jun, 2014 1 commit
  22. 23 May, 2014 1 commit
  23. 08 May, 2014 2 commits
  24. 01 Apr, 2014 1 commit
  25. 30 Mar, 2014 1 commit
    • Aleix Pol Gonzalez's avatar
      Initial import from the monolithic kde-workspace. · da27b276
      Aleix Pol Gonzalez authored
      This is the beginning of revision history for this module. If you
      want to look at revision history older than this, please refer to the
      techbase wiki for how to use Git history grafting. At the time of
      writing, this wiki is located here:
      If you have already performed the grafting and you don't see any
      history beyond this commit, try running "git log" with the "--follow"
      Branched from the monolithic repo kde-workspace, frameworks  branch, at commit