GitLab

(seen during plasma-bigscreen startup)

(cherry picked from commit 13616ee1)

Noticed this while refactoring something in the area.

Differential Revision: https://phabricator.kde.org/D28905

This mutates the source array.
In practice actions don't really change in existing notifications but still better to not do that.

Differential Revision: https://phabricator.kde.org/D28650

Summary:
launchersOrder and the actual url data can be different:
in case of preferred:/ urls launcherorder will have that for
(for serialization) and the actual appdata url will be decoded as for
instance Applications:firefox.desktop.
this url is the one that needs to be compared to know the actual
launcher order

BUG:418483

Test Plan: firefox stays in first position when pinned as preferred://browser

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28632

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GHNS Quick Button signals changedEntriesChanged initially even if nothing changed.
While this is a bug that should be fixed in GHNS, the wallpaper model didn't handle the case well,
when the model was reloaded while a preview was being generated.

It looks up whether a preview exists by QUrl and stores a QPersistentModelIndex.
However, when the model is reloaded and it accesses data for the same QUrl, the job might still be in-flight,
but the QPersistentModelIndex is invalid as the model has been reset.

This fixes it by performing all lookups exclusively on QPersistentModelIndex.
The hash lookup is optimized for data() (loads of accesses) with the slower key() lookup being done only
when the less frequently occurring thumbnail generation finishes/fails.
It will now do two preview jobs initially, but at least it shows something again...

BUG: 419234
FIXED-IN: 5.18.4

Differential Revision: https://phabricator.kde.org/D28420

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
It's possible to have a .desktop file in your recent documents list as
you were editing it. Either as a .desktop file or masquerading as
something else.

By default we would process the .desktop file like a .desktop file.

You do get a prompt if the .desktop file is not executable like in
dolphin.

Given we know from context that we're showing recent "Documents" we may
as well turn that behaviour off without risk of ill effects.

BUG: 419310

Test Plan:
Created .desktop file (masquerading as something else)
Had it in my recent documents after opening in another format
Loaded the file from krunner. It now opened in my text editor instead of running
the Exec line

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28369

Plasma 5.18 depends on Qt 5.12, but configTimeZones.qml was
unnecessarily requiring 5.13 by importing QtQuick 2.13.

Summary:
Else the entry is still in cfg_shownItems/cfg_hiddenItems and the config UI will display it as shown instead of disabled.

BUG: 419197

Reviewers: #plasma, kmaterka, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28311

Summary:
This patch fixes several errors in the code:
- The property is named `font.minimumPixelSize`, not `minimumPixelSize`
- The calculation in `minimumPixelSize` did not make sense
- Setting the height to `dateLabel.paintedHeight` is nonsensical

BUG: 417852
FIXED-IN: 5.18.4

Test Plan: {F8186873}

Reviewers: #vdg, #plasma, cblack, davidedmundson

Reviewed By: #vdg, #plasma, cblack, davidedmundson

Subscribers: davidedmundson, cblack, muesli, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28172

Rather than relying on KWin to have reconfigured, which isn't the case when merely changing the number of rows.

BUG: 408783
FIXED-IN: 5.18.4

Differential Revision: https://phabricator.kde.org/D28216

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: The property currentValue is conflicting making the qml file not run.

Reviewers: #plasma_workspaces, davidedmundson

Reviewed By: #plasma_workspaces, davidedmundson

Subscribers: kmaterka, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26923

GIT_SILENT

Instead of comparing the state of the action to the action name, compare it to the argument the action will invoke it with.
In contrast to checkboxes, which are independent actions with a boolean state, radio menu items all refer
to the same action (e.g. "Zoom") and then pass the new state ("zoom-100", "zoom-200", etc) as target when invoking the action.

CCBUG: 418385

Differential Revision: https://phabricator.kde.org/D27885

According to documentation [1] a menu item has a target attribute, which is "the parameter to pass when activating the action".
Furthermore, the action "Activate" method specifies "If the action activation requires a parameter then this parameter must
be given in the second parameter (av).". Also implements a TODO in the code.

[1] https://wiki.gnome.org/Projects/GLib/GApplication/DBusAPI

CCBUG: 418385

Differential Revision: https://phabricator.kde.org/D27884

It just adds noise.

Differential Revision: https://phabricator.kde.org/D27879

HelperMatch type was used to identify them in run but this also causes them to score way higher than anything else (except ExactMatch).

CCBUG: 418529

Differential Revision: https://phabricator.kde.org/D27886

Aleksei Nikiforov authored Mar 06, 2020 and David Edmundson committed Mar 06, 2020

Summary:
Otherwise, setLayout function might be called for
already destructed instance of ItemContainer,
leading to double reference counter decrement of m_layout QPointer,
eventually invalidating such pointers prematurely.

BUG: 417603

Test Plan:
1) Unlock widgets via command: qdbus org.kde.plasmashell /PlasmaShell evaluateScript "lockCorona(false)"
2) On desktop push right mouse button and select menu item 'Add Widgets...'
3) Add various widgets to desktop using drag'n'drop on desktop.
   I've added at least following widgets on same desktop screen:
   Audio Volume, Battery and Brightness, Binary Clock, Clipboard, Color Picker, Grouping Plasmoid, Quick Chat
4) Remove just added widgets in random order
5) If necessary, repeat steps 3 and 4 a few times
   If widgets aren't appearing on desktop despite adding them via drag'n'drop, it's bugged and ready to crash. But it's not a requirement for crash.
6) lock widgets via command: qdbus org.kde.plasmashell /PlasmaShell evaluateScript "lockCorona(true)"
7) repeat steps 1-6 multiple times
8) plasmashell shouldn't crash

Reviewers: ngraham, davidedmundson, mart

Reviewed By: davidedmundson

Subscribers: cfeck, anthonyfieroni, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27650

GIT_SILENT

Summary: CCBUG: 412114

Test Plan:
{F8116018}

(The icon size is too large by default but that's not a bug in this patch)

Reviewers: #plasma, davidedmundson, meven, ndavis

Reviewed By: meven, ndavis

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27530

Summary: Else the content will overflow the frame when scrolling

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27570

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

BUG: 417747
FIXED-IN: 5.18.2

Oleg Solovyov authored Feb 18, 2020 and Nate Graham committed Feb 18, 2020

Summary:
Activity runner is now useless:

m_activities is always nullptr in ActivityRunner::run because ActivityRunner::down is called after ActivityRunner::match which makes activity changing impossible

Reviewers: broulik, ngraham, davidedmundson

Reviewed By: ngraham, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27367

GIT_SILENT

Summary:
If for some reason a service is started before StartServiceJob runs, we
will end up blocking forever.

Test Plan: Logged in

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27471

Summary:
BUG: 417747
FIXED-IN: 5.18.1

Test Plan:
Better default size when showing the most info: {F8107763}

However window is too now big when showing the least amount of info: {F8107762}

...But that seems kind of unavoidable unless we want to dynamically resize the window,
which people seem to hate.

Reviewers: #plasma, #vdg, apol

Reviewed By: apol

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27448

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Yes this is an i18n break, but i18n is broken anyway when using downloadNewWhat

Patch by Victor Ryzhykh

Summary:
Instead of loading the model and then showing the last shown image, we can show
it early so that we signal "wallpaper.loading = false" earlier.
CCBUG: 371455

Test Plan: Have massive slideshow, login

Reviewers: davidedmundson, broulik, #plasma

Reviewed By: davidedmundson, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27084

Avoids repeatedly resizing the dialog when copying many files.
It will still resize when the speed label comes and goes but at least when copying many tiny files it won't be as obnoxious.

BUG: 417489
FIXED-IN: 5.18.1

Differential Revision: https://phabricator.kde.org/D27344

Summary:
VirtualDesktopInfo::Private is ref counted and shared between N
VirtualDesktopInfo's.

We were passing the first VirtualDesktopInfo as a parent to
VirtualDesktopInfo::Private which didn't manage the lifespan or do
anything useful.

The wayland backend incorrectly used this 'q' object and spanned
mulitple internal objects and connections to the first object that
created the shared private instance, leaving us with dangly objects
inside.

BUG: 415200
(and possibly several other bugs of wayland task manager not updating
correctly)

Test Plan:
Compiles
Plasma still loads

Reviewers: #plasma, zzag

Reviewed By: #plasma, zzag

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27266

Summary: According to Qt docs, QUuid() creates a null UUID object.

Test Plan: N/A, plasmashell is very unstable with Qt 5.15.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27237

Summary:
plasma.kde.org doesn't exist anymore and causes the appstream test to
to fail.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27304