1. 01 Sep, 2018 4 commits
    • David Edmundson's avatar
      Restore initial setting of ksmserver dialogActive · 66ab5f3e
      David Edmundson authored
      The boolean dialogActive isn't only used by the switchUser screen, but
      also the logout dialog.
      
      Fixes regression from 084b9a40
      66ab5f3e
    • David Edmundson's avatar
      Further cleanup · d57e530f
      David Edmundson authored
      d57e530f
    • David Edmundson's avatar
      Merge switch user dialog into lockscreen · 084b9a40
      David Edmundson authored
      Summary:
      This reduces a bunch of code, both hidden in the backend as well as the
      mostly duplicated front end UI, making it more consistent for users too.
      
      There is a behavioural change that switching user then cancelling will
      require your own password.
      
      KSMServer still has the same DBus slot for compatibility which then
      proxies over to the screensaver. This could be calling itself, it might
      be calling kwin when we're on wayland.
      
      Depends on D15186
      
      Test Plan:
      Pressed switch user from the UI
      Got a swich user dialog
      
      Reviewers: #plasma, mart
      
      Reviewed By: #plasma, mart
      
      Subscribers: ngraham, mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15187
      084b9a40
    • David Edmundson's avatar
      Fix kscreenlocker_greet --switchuser · 74713563
      David Edmundson authored
      Summary:
      Years ago support was added for the lockscreen to default into switch user
      mode. The goal being to simplify one more task from ksmserver.
      
      It got postponed because it clashed with a change Kai made at the time.
      Now I'm restoring that.
      
      The code broke in the lockscreen rewrite.
      
      Test Plan:
      Called the switchUser DBus method
      Lockscreen spawned on the right page
      Locked screen normally, got the normal page
      
      Reviewers: #plasma, mart
      
      Reviewed By: #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15185
      74713563
  2. 31 Aug, 2018 3 commits
  3. 30 Aug, 2018 2 commits
    • Robert Hoffmann's avatar
      Fix setting primary connector if primary output changed · ea19f9b6
      Robert Hoffmann authored and Nate Graham's avatar Nate Graham committed
      Summary:
      If a user logged in with one screen connected plugs in
      a second screen, which becomes the new primary screen,
      this screen would stay black or behave weird.
      
      Unplugging the screen again would mess up plasmashell.
      
      Added to ScreenPool::setPrimaryConnector():
      In the case primary output changed m_idForConnector
      doesn't contain the new primary, so a screen mapping
      is created for it.
      
      Test Plan:
      Testing on virtualbox or vmware player seems impossible, because
      these don't allow disabling the first display (VGA-1) and booting
      with the second (VGA-2) only.
      
      1. Boot machine with one screen connected to HDMI-3 (primary output).
      2. Log in
      3. Plug in second screen to HDMI-2:
      --> primary output changes from HDMI-3 to HDMI-2
      4. OSD appears: extend to right
      --> Without this patch, the new screen (HDMI-2) would stay blank.
      --> With this patch applied, the screen content moves to the new
         second screen.
      
      5. Unplug second screen (HDMI-2)
      --> Without this patch, the background would get black, control panel
         would disappear, could only be restored by restart of plasmashell
      --> With this patch applied, screen content moves to the right and
         works
      
      Reviewers: #plasma, mart, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D13853
      ea19f9b6
    • David Edmundson's avatar
      Allow wallpaper slideshow blur config to persist · 26050397
      David Edmundson authored
      Summary:
      Slideshow wallpapers use the same Blur/Color selector that single image
      wallpapers use.  However, the Blur config entry was added to the image
      xml but not the slideshow xml.  The result was that the selection was
      never persisted and reverted to the default on restart.  This allows the
      slideshow blur config to persist.
      
      Test Plan:
      Configure the desktop backgrounds.
      Select slideshow with one or more images that are smaller than the screen.
      Choose fill with solid color.  Apply and exit.
      Note that the background fill takes on the solid color
      Restart
      Note that the background fill is still the solid color
      Configure desktop background
      Choose fill with blur.  Apply and exit
      Note that the background fill is a blur
      Restart
      Note that the background fill is still a blur.
      
      Reviewers: #plasma_workspaces, davidedmundson
      
      Reviewed By: #plasma_workspaces, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D13555
      26050397
  4. 29 Aug, 2018 1 commit
  5. 28 Aug, 2018 1 commit
  6. 27 Aug, 2018 2 commits
  7. 23 Aug, 2018 4 commits
  8. 22 Aug, 2018 1 commit
    • Fabian Vogt's avatar
      Use QJSValue as method parameter type for the scripting interface · 6e5c9e9b
      Fabian Vogt authored
      Summary:
      If a slot or Q_INVOKABLE has a QVariant as parameter and gets called
      from a QJSEngine's script, it receives a QJSValue wrapped as QVariant.
      To get a QVariant with the actual value wrapped, calling QJSValue::toVariant
      is necessary.
      
      I'm not entirely sure whether this is intentional behaviour of QJSEngine, but
      even if it's a bug we'll have to workaround it.
      
      BUG: 397338
      
      Test Plan: I have favorites in kickoff again.
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D14822
      6e5c9e9b
  9. 21 Aug, 2018 1 commit
  10. 20 Aug, 2018 1 commit
  11. 17 Aug, 2018 1 commit
  12. 15 Aug, 2018 2 commits
  13. 11 Aug, 2018 1 commit
  14. 08 Aug, 2018 3 commits
  15. 07 Aug, 2018 3 commits
  16. 06 Aug, 2018 6 commits
  17. 02 Aug, 2018 2 commits
  18. 31 Jul, 2018 1 commit
  19. 30 Jul, 2018 1 commit