1. 13 May, 2020 1 commit
    • Filip Fila's avatar
      [sddm-theme] Prevent the logo from leaking in after a fadeout · 68601675
      Filip Fila authored
      Even when the vendor logo is turned off it can be briefly seen when the login screen changes from the fadeout state back into normal.
      Comments in other code say that "OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)" so this patch replaces it with NumberAnimation.
      There's also a minor fix included - placing the drop shadow sooner in the hierarchy because it should be drawn underneath an object, not in front of it.
      Test Plan:
      Reduce the fadeout time to something small and then:
      `sddm-greeter --test-mode --theme /usr/share/sddm/themes/breeze`
      Reviewers: ngraham, cblack, #plasma, mart
      Reviewed By: ngraham, #plasma, mart
      Subscribers: mart, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29351
  2. 10 May, 2020 1 commit
  3. 06 May, 2020 1 commit
  4. 05 May, 2020 2 commits
  5. 04 May, 2020 2 commits
    • Konrad Materka's avatar
      [systemtray] Fix SNI icon not rendering · 77975468
      Konrad Materka authored
      In some rare situations SNI icons are not rendered. It happens randomly, only some users are affected. It does not happen on every login.
      Only SNI icons are not rendered, Plasmoids are fine. Restarting plasmashell or re-adding systemtray applet helps.
      In QML all roles need to be defined before model is used. When data engines is used a a source for a data model, all roles has to be defined and proper value assigned (not a null QVariant). StatusNotifierItemSource does this properly, but in some situations it sets null QVariant for Icon. Setting empty/null QVariant removes key/role from the date set (DataConteiner implementation). If data model was loaded earlier or later when Icon has proper value it will work properly. In some rare situation it is possible that data model is loaded when Icon has null value assigned (in other words - removed), role is removed from the data model and not avaiable to system tray applet.
      This fix makes sure that there is always a value for Icon role. To check if icon is null native method has to be used - QML does not understand that QIcon can be null.
      BUG: 419305
      FIXED-IN: 5.18.5
      Test Plan: I don't have any reliable method to reproduce this issue.
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
      Reviewed By: ngraham
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29386
    • Kai Uwe Broulik's avatar
      [KRunner] Watch config with KConfigWatcher · 6db69ae0
      Kai Uwe Broulik authored
      Rather than using a KDirWatch that points to the wrong place.
      Differential Revision: https://phabricator.kde.org/D29411
  6. 01 May, 2020 1 commit
  7. 27 Apr, 2020 1 commit
  8. 25 Apr, 2020 1 commit
  9. 22 Apr, 2020 1 commit
  10. 19 Apr, 2020 3 commits
  11. 17 Apr, 2020 1 commit
  12. 14 Apr, 2020 1 commit
  13. 06 Apr, 2020 2 commits
    • Marco Martin's avatar
      use the decoded url for launcherPosition · ac0124c4
      Marco Martin authored
      launchersOrder and the actual url data can be different:
      in case of preferred:/ urls launcherorder will have that for
      (for serialization) and the actual appdata url will be decoded as for
      instance Applications:firefox.desktop.
      this url is the one that needs to be compared to know the actual
      launcher order
      Test Plan: firefox stays in first position when pinned as preferred://browser
      Reviewers: #plasma, ngraham
      Reviewed By: ngraham
      Subscribers: ngraham, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D28632
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 7a7b489b
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
  14. 05 Apr, 2020 1 commit
  15. 31 Mar, 2020 2 commits
    • Jonathan Esk-Riddell's avatar
      Update version number for 5.18.4 · 31d7d62d
      Jonathan Esk-Riddell authored
    • Kai Uwe Broulik's avatar
      [Image Wallpaper] Fix thumbnail generation when model is reloaded in-flight · 49230140
      Kai Uwe Broulik authored
      GHNS Quick Button signals changedEntriesChanged initially even if nothing changed.
      While this is a bug that should be fixed in GHNS, the wallpaper model didn't handle the case well,
      when the model was reloaded while a preview was being generated.
      It looks up whether a preview exists by QUrl and stores a QPersistentModelIndex.
      However, when the model is reloaded and it accesses data for the same QUrl, the job might still be in-flight,
      but the QPersistentModelIndex is invalid as the model has been reset.
      This fixes it by performing all lookups exclusively on QPersistentModelIndex.
      The hash lookup is optimized for data() (loads of accesses) with the slower key() lookup being done only
      when the less frequently occurring thumbnail generation finishes/fails.
      It will now do two preview jobs initially, but at least it shows something again...
      BUG: 419234
      FIXED-IN: 5.18.4
      Differential Revision: https://phabricator.kde.org/D28420
  16. 30 Mar, 2020 1 commit
  17. 29 Mar, 2020 1 commit
    • David Edmundson's avatar
      [runners/recentdocuments] disable executables or .desktop files · 97bf7d77
      David Edmundson authored
      It's possible to have a .desktop file in your recent documents list as
      you were editing it. Either as a .desktop file or masquerading as
      something else.
      By default we would process the .desktop file like a .desktop file.
      You do get a prompt if the .desktop file is not executable like in
      Given we know from context that we're showing recent "Documents" we may
      as well turn that behaviour off without risk of ill effects.
      BUG: 419310
      Test Plan:
      Created .desktop file (masquerading as something else)
      Had it in my recent documents after opening in another format
      Loaded the file from krunner. It now opened in my text editor instead of running
      the Exec line
      Reviewers: #plasma, ngraham
      Reviewed By: ngraham
      Subscribers: ngraham, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D28369
  18. 28 Mar, 2020 1 commit
  19. 26 Mar, 2020 1 commit
  20. 24 Mar, 2020 2 commits
  21. 21 Mar, 2020 1 commit
  22. 17 Mar, 2020 1 commit
  23. 13 Mar, 2020 1 commit
  24. 10 Mar, 2020 1 commit
  25. 09 Mar, 2020 4 commits
  26. 06 Mar, 2020 1 commit
    • Aleksei Nikiforov's avatar
      ItemContainer: disconnect signals in destructor · 8f0da90f
      Aleksei Nikiforov authored and David Edmundson's avatar David Edmundson committed
      Otherwise, setLayout function might be called for
      already destructed instance of ItemContainer,
      leading to double reference counter decrement of m_layout QPointer,
      eventually invalidating such pointers prematurely.
      BUG: 417603
      Test Plan:
      1) Unlock widgets via command: qdbus org.kde.plasmashell /PlasmaShell evaluateScript "lockCorona(false)"
      2) On desktop push right mouse button and select menu item 'Add Widgets...'
      3) Add various widgets to desktop using drag'n'drop on desktop.
         I've added at least following widgets on same desktop screen:
         Audio Volume, Battery and Brightness, Binary Clock, Clipboard, Color Picker, Grouping Plasmoid, Quick Chat
      4) Remove just added widgets in random order
      5) If necessary, repeat steps 3 and 4 a few times
         If widgets aren't appearing on desktop despite adding them via drag'n'drop, it's bugged and ready to crash. But it's not a requirement for crash.
      6) lock widgets via command: qdbus org.kde.plasmashell /PlasmaShell evaluateScript "lockCorona(true)"
      7) repeat steps 1-6 multiple times
      8) plasmashell shouldn't crash
      Reviewers: ngraham, davidedmundson, mart
      Reviewed By: davidedmundson
      Subscribers: cfeck, anthonyfieroni, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D27650
  27. 25 Feb, 2020 1 commit
  28. 24 Feb, 2020 1 commit
  29. 22 Feb, 2020 2 commits