1. 24 May, 2020 1 commit
    • Konrad Materka's avatar
      [applets/mediacontroller] Don't use Album Art for icon · 6f826a1b
      Konrad Materka authored
      Icon of Media Player applet is missing in the System Tray settings when
      the media playing has a cover. Such icon is present when nothing is playing.
      Fix by not using album art in any case - icon is not longer used in
      tooltip, can be static.
      BUG: 420197
      FIXED-IN: 5.19.0
      Test plan:
      1. play audio/video with a player compatible with Media Player applet
      2. open system tray settings during playback
      3. Icon of Media Player applet is always present in system tray
      settings, regardless of state.
  2. 21 May, 2020 2 commits
  3. 20 May, 2020 2 commits
  4. 19 May, 2020 1 commit
  5. 18 May, 2020 2 commits
  6. 15 May, 2020 3 commits
  7. 14 May, 2020 2 commits
  8. 13 May, 2020 6 commits
  9. 12 May, 2020 6 commits
  10. 11 May, 2020 10 commits
    • Eugene Popov's avatar
      [applets/notifications] Remain visible after removing all notifications while... · e6ed4a88
      Eugene Popov authored and Nate Graham's avatar Nate Graham committed
      [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open
      When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself.
      BUG: 421344
      Reviewers: ngraham, plasma-devel, broulik
      Reviewed By: ngraham, broulik
      Subscribers: broulik
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29651
    • Konrad Materka's avatar
      [applets/systemtray] Show base icon when AttentionIcon not set · 00e64bdb
      Konrad Materka authored
      If status is set to NeedsAttention it tries to use Attention Icon. If Attention Icon is not set, empty/null QIcon is set. QML can't check if QIcon is null or not, as a result it tries to use empty icon and nothing is rendered.
      Set null QVariant if AttentionIcon is not valid so that QML check will work correctly.
      Test Plan:
      * Set NeedsAttention as a status and with no Attention Icon
      * Base Icon should render correctly
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, mart
      Reviewed By: #plasma_workspaces, #plasma, mart
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29544
    • Nate Graham's avatar
      [applets/icon] Remove icon from tooltip · 65f06786
      Nate Graham authored
      CCBUG: 420934
      Ref T12778
    • Arjen Hiemstra's avatar
      Use the right targets for KSysGuard · 8ae9b561
      Arjen Hiemstra authored
      Summary: Otherwise the build fails when things try to link to KF5::SysGuard etc.
      Test Plan: Builds again
      Reviewers: #plasma, meven
      Reviewed By: meven
      Subscribers: meven, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29628
    • David Redondo's avatar
      Improve StatusNotifierTest · 5459a533
      David Redondo authored
      Allows to set Icon, AttentionIcon and OverlayIcon either by name or pixmap.
      Makes it easier to test combinations of those.
      Reviewers: kmaterka, apol
      Reviewed By: kmaterka, apol
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29619
    • Marco Martin's avatar
      Redesign of system monitor plasmoids · c8deafbb
      Marco Martin authored
      Those plasmoids are intended to replace the old systemmonitor plasmoids
      They are based upon the new ksysguard daemon: see D28333 and D28141
      It has pluggable presets and sensor "faces" which are available from the KDE store
      Every preset is available as a separate plasmoid.
      By default are installed ones to replace
      roughly one by one the existing systemmonitor plasmoids so systems that use it
      will get the new ones in the updates
      Depends on D28922
      Test Plan: {F8209642}
      Reviewers: #plasma
      Subscribers: alexde, ngraham, davidedmundson, mmustac, ahiemstra, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D28487
    • Méven Car's avatar
      Fix Warning about KF5::KSysGuard target being deprecated · d2c57378
      Méven Car authored
      Warnings such as:
      CMake Warning at /usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:37 (me
        The KF5:: namespace for KSysGuard targets is deprecated.  Please use
         KSysGuard as namespace.
       Call Stack (most recent call first):
         /usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package)
         CMakeLists.txt:55 (find_package)
      Test Plan: cmake does not output those warnings
      Reviewers: #plasma, ahiemstra, davidedmundson
      Reviewed By: #plasma, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29623
    • Marco Martin's avatar
      force systemsettings for kcms · e67e8d6d
      Marco Martin authored
      as we can't kill completely kcmshell just yet, hack intothe services runner to
      replace on the fly the exec line of the service to systemsettings
      BUG: 402790
      FIXED-IN: 5.19.0
      Test Plan:
      search and launch directly for a module, systemsettings is launched wit hthe
      proper module loaded
      Reviewers: #plasma, ngraham
      Reviewed By: ngraham
      Subscribers: broulik, ngraham, davidre, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29157
    • Bhushan Shah's avatar
      libnotificationmanager: fix the checkIndex after moving around functions · dbc7bd3c
      Bhushan Shah authored
      Fix in the f2e34dbb got partially reverted by introduction
      of AbstractNotificationsModel in 2357e6f2.
    • Bhushan Shah's avatar
      [libnotificationmanager] introduce the WatchedNotificationsModel · 2357e6f2
      Bhushan Shah authored
      Summary: This allows one to subscribe to notifications from notification server.
      Test Plan:
      tested using very simple QML
      import QtQuick 2.0
      import org.kde.notificationmanager 1.1 as Notifications
      Notifications.NotificationWatchedModel {
          id: model
      Reviewers: #plasma, broulik, davidedmundson
      Reviewed By: #plasma, broulik
      Subscribers: nicolasfella, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D28509
  11. 10 May, 2020 3 commits
  12. 08 May, 2020 1 commit
  13. 07 May, 2020 1 commit
    • Konrad Materka's avatar
      [applets/systemtray] Hide/show expander arrow - regression fix · b34e88da
      Konrad Materka authored
      Expander arrow should hide when all icons are visible and no icon is hidden. When dialog with hidden items is hidden ListView does not update its count property - property is update on redraw. As a result expander arrow is still visible/hidden until user clicks on any plasmoid to show dialog.
      BUG: 420924
      Test Plan:
      * select/deselect "Show all items" in settings, save, expander arrow should hide/show imidiatelly
      * select almost all items to "Always shown", leave "Keyboard indicator" as "Shown when relevant". Press Casp Lock, expander arrow should hide/show correctly
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
      Reviewed By: #plasma_workspaces, #plasma, broulik, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D28180