GitLab

Summary:
Icon of Media Player applet is missing in the System Tray settings when
the media playing has a cover. Such icon is present when nothing is playing.
Fix by not using album art in any case - icon is not longer used in
tooltip, can be static.

BUG: 420197

FIXED-IN: 5.19.0

Test plan:
1. play audio/video with a player compatible with Media Player applet
2. open system tray settings during playback
3. Icon of Media Player applet is always present in system tray
settings, regardless of state.

We don't show icons on tooltips anymore.
And the System Tray config doesn't show images.

BUG: 420197
FIXED-IN: 5.19.0

Differential Revision: https://phabricator.kde.org/D28917

Summary:
The media controller has been adjusted visually. Note that this is marked as WIP due to the fact that the system tray displays margins around the applet, which doesn't look too good.
Co-authored-by: Ismael Asensio <isma.af@gmail.com>

Depends on D28089

Test Plan:
Before:
{F8085938}
After:
{F8089034}

Reviewers: #vdg, #plasma, manueljlin, ngraham, broulik!

Reviewed By: #vdg, #plasma, ngraham

Subscribers: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel

Tags: #plasma

Maniphest Tasks: T10470

Differential Revision: https://phabricator.kde.org/D27160

Denis Sheremet authored Oct 18, 2019 and Kai Uwe Broulik committed Oct 18, 2019

According to the spec, xesam:artist should be a string array, but
majority of players uses string instead. This patch adds support for
both string array and string options to allow new software development
according to the spec but also maintain compatibility with existing
solutions.

BUG: 405762
FIXED-IN: 5.17.1

Differential Revision: https://phabricator.kde.org/D24740

Summary:
Add simple volume control to Media Controller applet. Volume can by changed by:

- mouse wheel on applet icon (3 % step), and
- new global shortcuts (5 % step, unbound by default).

There is no mute support currently (mpris interface does not have a mute method so we would have to keep
track of old volume).

BUG: 386588

Test Plan: Tested in daily use with Cantata and SMPlayer. There is no UI change.

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, nicolasfella, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11021

Summary:
Instead of using the action icons to indicate the current state use
the new media playback status icons.

This is an alternative solution to the problem that the mediacontroller applet
icon in the system tray and the play/pause controll in the player are always
the opposite.

While it is still the opposite icon there is now a slight visual difference
to show that these icons mean different things.

This is meant as a solution to the problem discussed in D10032.

{F5741436}

{F5741437}

Reviewers: #plasma, andreask, broulik

Reviewed By: #plasma, andreask, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11056

Summary:
Currently the media controller only works with MPRIS services which support
the PlayPause command. By the MPRIS spec this is an optional feature though.
While most players out there support this, the MPRIS support in Gwenview
currently worked on does not (would need some more rewrite of internals).
Which makes the Media controller applet and/or Gwenview look broken :)

To keep the current design with a central Play/Not Play button, this patch
changes its behaviour depending on the CanPause flag:
CanPause=true ->  show either Play or Pause
CanPause=false -> show Play enabled/disabled

Reviewers: broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10973

Summary:
The lockscreen uses the MPRIS dataengine. This leads to two applications
registring the service using the same component name which leads to the
shortcuts not working when the lock screen closes.

We want to have the applet register the shortcuts, but not every
dataengine user.

Ideally this shouldn't be in the dataengine either because DataEngines
are read only. This moves the logic to the service which is writable and
registers the shortcuts for the multiplexer there when requested from
the applet.

BUG: 380526
FIXED-IN: 5.10.1

Test Plan:
Opened media player.
Used play/pause shortcut. (the only one my keyboard has)

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6100

This way we disable the play/pause button and context menu entry if player claims it cannot.

Differential Revision: https://phabricator.kde.org/D5582

Unfortunately doesn't apply to toolTipMainText

Both CanRaise and CanQuit are required only for the context menu whose actions
are updated before it is shown. Avoids some needless binding re-evaluations.

Previously, we would show "paused" only when explicitly paused, not when there isn't even
media loaded. "Paused" should always be the icon when nothing's playing, obviously.

This also avoids a weird sequence of "paused - playing - hidden" when stopping a paused track.

Depending on the kind of media, e.g. network stream, or slow player with huge
collection, it can take a considerable amount of time for it to start playing.

Avoid having panel contents jumping around because of this.

BUG: 367807
FIXED-IN: 5.9.0

When playing a song, it's either the artist or empty. However, when nothing's playing
we would have a main text of "No media playing" with the applet description as
subtext "allows to control media" which is out of place

Ensures the arrows always point outwards

This visually associates the action to "this will bring you the player"

Makes it consistent with the other applets

[Media Controller] Allow going to previous/next track by clicking the icon with mouse back/forward keys

Allows to open the player window, quit the player, go to previous and next song,
play/pause, and stop playback, just like most player tray icons.

This way we only clear and re-populate actions on demand

When the applet is opened you can press the following keys to control it:
* Space (and K): Play/Pause
* P: Previous song
* N: Next song
* S: Stop playback
* Left key (or J): seek back 5s
* Right key (or L): seek forward 5s
* Home: Go to beginning of track
* End: Go to end of track (ie. basically goes to next track)
* 0..9: Jump to 0%, 10%, 20%, etc of track's length depending on the number

Of course there's still the global shortcuts so you don't actually need this.
While at it I made the slider a bit more reliable while manipulating it so it
wouldn't twitch around.

BUG: 351146
FIXED-IN: 5.6.0

If more than one player is currently running, a ComboBox will allow to choose
the player to control. Doing so will make all controls (ie. the slider, album art,
player buttons as well as the tooltip and system tray icon, active state) reflect
the current player's state.

By default the "@multiplex" source is still used which tries to choose the player
automatically (I guess...) and it also reverts to that if the current player quits.

Systray is really broken when you have a DBus activated task that starts
passively. It adds it to some model and then moves it around and then eventually
everything will just break. This needs fixing in the systray, since there
will eventually be plasmoids which should start passively but atm the
mediacontroller is the only one. So I'm trying to make it look okay here.

We can just use onStateChanged directly instead of having a superfluous property.
Also now the plasmoid becomes active immediately but goes passive only after
250ms. Amarok really takes an insanely long time to load the next track.
100ms wasn't enough to prevent flickering all the time. I guess for users without
SSD 250 will also be scarce.

This way you can easily bring your player to the front without needing it to have a
system tray icon and without opening the mediacontroller first

Unfortunately VLC player doesn't support being raised via mpris :(

This way we don't present the user with a percent encoded filename,
if there happens to be single quotes and the like in the path

Amarok takes quite a while to load the next track and this avoids having the
plasmoid jump between panel and popup every time you change the track

Since passive status and stuff is already set, no need to explicitly declare an "off" state

It either shows "No media playing", the title plus artist, or the title plus artist with "pause" appended