1. 24 May, 2020 1 commit
    • Konrad Materka's avatar
      [applets/mediacontroller] Don't use Album Art for icon · 6f826a1b
      Konrad Materka authored
      Summary:
      Icon of Media Player applet is missing in the System Tray settings when
      the media playing has a cover. Such icon is present when nothing is playing.
      Fix by not using album art in any case - icon is not longer used in
      tooltip, can be static.
      
      BUG: 420197
      
      FIXED-IN: 5.19.0
      
      Test plan:
      1. play audio/video with a player compatible with Media Player applet
      2. open system tray settings during playback
      3. Icon of Media Player applet is always present in system tray
      settings, regardless of state.
      6f826a1b
  2. 17 Apr, 2020 1 commit
  3. 12 Apr, 2020 1 commit
  4. 18 Oct, 2019 1 commit
  5. 06 Sep, 2018 1 commit
  6. 03 Apr, 2018 1 commit
    • Radek Hušek's avatar
      [Media controller] Add simple volume control · bd5619e0
      Radek Hušek authored
      Summary:
      Add simple volume control to Media Controller applet. Volume can by changed by:
      
      - mouse wheel on applet icon (3 % step), and
      - new global shortcuts (5 % step, unbound by default).
      
      There is no mute support currently (mpris interface does not have a mute method so we would have to keep
      track of old volume).
      
      BUG: 386588
      
      Test Plan: Tested in daily use with Cantata and SMPlayer. There is no UI change.
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: broulik, nicolasfella, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D11021
      bd5619e0
  7. 21 Mar, 2018 1 commit
  8. 07 Mar, 2018 1 commit
    • Roman Gilg's avatar
      [mediacontroller applet] Use media playback status icons · 04dc4c9d
      Roman Gilg authored
      Summary:
      Instead of using the action icons to indicate the current state use
      the new media playback status icons.
      
      This is an alternative solution to the problem that the mediacontroller applet
      icon in the system tray and the play/pause controll in the player are always
      the opposite.
      
      While it is still the opposite icon there is now a slight visual difference
      to show that these icons mean different things.
      
      This is meant as a solution to the problem discussed in D10032.
      
      {F5741436}
      
      {F5741437}
      
      Reviewers: #plasma, andreask, broulik
      
      Reviewed By: #plasma, andreask, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D11056
      04dc4c9d
  9. 06 Mar, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      [media controller applet] Support MPRIS services where CanPause==false · 06913fc2
      Friedrich W. H. Kossebau authored
      Summary:
      Currently the media controller only works with MPRIS services which support
      the PlayPause command. By the MPRIS spec this is an optional feature though.
      While most players out there support this, the MPRIS support in Gwenview
      currently worked on does not (would need some more rewrite of internals).
      Which makes the Media controller applet and/or Gwenview look broken :)
      
      To keep the current design with a central Play/Not Play button, this patch
      changes its behaviour depending on the CanPause flag:
      CanPause=true ->  show either Play or Pause
      CanPause=false -> show Play enabled/disabled
      
      Reviewers: broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10973
      06913fc2
  10. 05 Jun, 2017 1 commit
    • David Edmundson's avatar
      Only enable MPRIS global shortcuts on demand · 7bd909fa
      David Edmundson authored
      Summary:
      The lockscreen uses the MPRIS dataengine. This leads to two applications
      registring the service using the same component name which leads to the
      shortcuts not working when the lock screen closes.
      
      We want to have the applet register the shortcuts, but not every
      dataengine user.
      
      Ideally this shouldn't be in the dataengine either because DataEngines
      are read only. This moves the logic to the service which is writable and
      registers the shortcuts for the multiplexer there when requested from
      the applet.
      
      BUG: 380526
      FIXED-IN: 5.10.1
      
      Test Plan:
      Opened media player.
      Used play/pause shortcut. (the only one my keyboard has)
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D6100
      7bd909fa
  11. 26 Apr, 2017 1 commit
  12. 19 Apr, 2017 1 commit
  13. 02 Jan, 2017 2 commits
  14. 01 Jan, 2017 2 commits
  15. 22 Aug, 2016 1 commit
  16. 11 Aug, 2016 1 commit
  17. 01 Aug, 2016 3 commits
  18. 16 Jun, 2016 1 commit
  19. 28 Feb, 2016 2 commits
    • Kai Uwe Broulik's avatar
      [Media Controller] Use Plasmoid.onContextualActionsAboutToShow to populate menu · 3429579c
      Kai Uwe Broulik authored
      This way we only clear and re-populate actions on demand
      3429579c
    • Kai Uwe Broulik's avatar
      [Media Controller] Add keyboard shortcuts to the applet itself · df37fc86
      Kai Uwe Broulik authored
      When the applet is opened you can press the following keys to control it:
      * Space (and K): Play/Pause
      * P: Previous song
      * N: Next song
      * S: Stop playback
      * Left key (or J): seek back 5s
      * Right key (or L): seek forward 5s
      * Home: Go to beginning of track
      * End: Go to end of track (ie. basically goes to next track)
      * 0..9: Jump to 0%, 10%, 20%, etc of track's length depending on the number
      
      Of course there's still the global shortcuts so you don't actually need this.
      While at it I made the slider a bit more reliable while manipulating it so it
      wouldn't twitch around.
      
      BUG: 351146
      FIXED-IN: 5.6.0
      df37fc86
  20. 19 Jan, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Media Controller] Support multiple players · f2f25289
      Kai Uwe Broulik authored
      If more than one player is currently running, a ComboBox will allow to choose
      the player to control. Doing so will make all controls (ie. the slider, album art,
      player buttons as well as the tooltip and system tray icon, active state) reflect
      the current player's state.
      
      By default the "@multiplex" source is still used which tries to choose the player
      automatically (I guess...) and it also reverts to that if the current player quits.
      f2f25289
  21. 04 Jan, 2015 1 commit
  22. 13 Sep, 2014 1 commit
  23. 11 Sep, 2014 1 commit
    • Kai Uwe Broulik's avatar
      Don't start Passive · 3d43de12
      Kai Uwe Broulik authored
      Systray is really broken when you have a DBus activated task that starts
      passively. It adds it to some model and then moves it around and then eventually
      everything will just break. This needs fixing in the systray, since there
      will eventually be plasmoids which should start passively but atm the
      mediacontroller is the only one. So I'm trying to make it look okay here.
      3d43de12
  24. 31 Aug, 2014 4 commits
  25. 25 Aug, 2014 1 commit
  26. 17 Aug, 2014 7 commits