1. 01 Apr, 2019 2 commits
    • Kai Uwe Broulik's avatar
      Completely wire up old dataengine and further touches · 723b6d13
      Kai Uwe Broulik authored
      - Old dataengine is fully functional now
        Except the inhibition stuff but I'm not sure if this is worth keeping the way it is
      - "More" menu opens on press now and highlights
      - Invoking any action closes the notification now
        KNotification explicitly does that for us but e.g. GTK does not
      - Add clear button for history
      - Restore kbroadcastnotification support
      - Allow forgetting seen application (for KCM)
      - Let users "create" notifications by calling NotificationServer::add
      - When no application name is provided look up the sender's process name as last resort
      - Add kdebugsettings categories file
      723b6d13
    • Kai Uwe Broulik's avatar
      Improvements and cleanups all over the place · 1c4de1d4
      Kai Uwe Broulik authored
      - Improve compact reprsentation
      - Keep popup open during interaction (context menu, drag)
      - Improve "ago" label (e.g. show "Last Sunday")
      - Improve group visuals (still pretty much WIP)
      - Hide popups when interacted (opened file, triggered file action, etc)
        Closing when having invoked an action isn't implemented yet but is probably neccessary
      - Make autohide job popup setting work
      - Set critical AlwaysOnTop (requires KWin patch)
      - Improve error handling in ThumbnailStrip
        Show file icon if thumbnail generation failed instead of a blank space
      - Add heuristic for popup placement and make custom setting work
      - Add deviceName and displayApplicationName (for KDE Connect)
        So it can show from which device and which app this notification originally came from
      - Improved service discovery (and defaultComponent handling)
        Quite a few notifications, e.g. DrKonqi crashes are in plasma_workspace.notifyrc
        When we get an event like this, show the original app instead
      - Make blacklist for popup and history work
      - Add "lastRead" property for "unread" handling vs "expired" (latter likely to be dropped)
      - Add sortMode so history is strictly sorted by date (it's grouped after all)
      - Begin work on do not disturb UI in plasmoid
      1c4de1d4
  2. 26 Mar, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Begin on inhibition / do not disturb stuff · eab83389
      Kai Uwe Broulik authored
      - Also moe the NotificationPopup item back to the root folder
      - Implement tracking of unknown apps, ie. once an app shows a notificaton it will show up
        in the KCM so it can be configured
      - Make blacklisting of notification popups (via setting in KCM) work
      - Start on inhibition stuff (DBus API proposal sent to XDG mailing list)
      eab83389
  3. 25 Mar, 2019 3 commits
  4. 23 Mar, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Cleanup, export, and start on settings and inhibition API · 79427e3d
      Kai Uwe Broulik authored
      - Cleanup, pimpl NotificationServer and Notification for export
      - Wire the old dataengine up to use it for compat:
        it shows notifications but is otherwise pretty broken right now
      - Start writing kconfigxt and Settings code (no real code yet)
      - Add a Inhibition DBus interface (no actual server-side code yet)
      - Group notifications by application
        Pretty much tasks grouping model from libtaskmanager slightly adjusted
      - Let widget take full height when expanded in vertical panel "side bar usecase"
      - Fix bugs here and there
      79427e3d
  5. 22 Mar, 2019 2 commits
  6. 21 Mar, 2019 2 commits
    • Kai Uwe Broulik's avatar
      Implement more missing stuff and be more spec-compliant · 3251c280
      Kai Uwe Broulik authored
      - Support replacing notifications properly
        - Now that we have nice models we can finally do the replacing in the way the spec
        asks for "atomically (ie with no flicker or other visual cues)"
      - Catch some more cases in notification details text (trash:/ stuff)
      - Prefer notifyrc name over desktop entry name in case a service within another app sends
        an event (e.g. Discover notifier in Plasma, KNotification automatically sends desktop-entry
        of the parent app)
      - Implement x-kde-urls thumbnailer with drag and drop and fancy blur
        Originally intended to be able to show multiple files but in practise only used for
        single pictures, so the code is significantly simplified for that usecase
      - Add "Open" feature for finished job notification, offers a context menu as well with
        all the KFileItemActions (component from the Thumbnailer)
      - Copy description labels to clipboard
        Once menu opens the update is paused so the text you copy is what you see
      - Fixup sanitizer so we can properly collapse notifications without body text
      
      ... and more
      3251c280
    • Kai Uwe Broulik's avatar
      fb620e07
  7. 20 Mar, 2019 3 commits
  8. 19 Mar, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Implement all the things · 35c575be
      Kai Uwe Broulik authored
      - Notification action buttons
      - Custom icon pixmaps in notifications
      - Popup handling
      - Notification urgency (low isn't shown as popup TBD, critical always no matter what)
      - History stuff (only expired notifications end up there, none that were closed or revoked)
      - Text selection and copy for body text
      - Basic tray icon support
      and many other things
      
      Application jobs are shown as part of regular notifications:
      - They show up as little popup that can be hidden in the history
      - When finished progress popup turns into a notification
      
      There's still some glitches and missing features, notably
      - Screenshot thumbnails
      - "Open" functionality for finished jobs
      - History layout
      - code cleanup
      - and basically every configuration option
      35c575be
  9. 18 Mar, 2019 2 commits
    • Harald Sitter's avatar
      Merge branch 'Plasma/5.15' · 14671459
      Harald Sitter authored
      14671459
    • Harald Sitter's avatar
      [service runner] throw out kde3 "compat" code · 1f3ab6f7
      Harald Sitter authored
      Summary:
      Desktop files such as kde/foo.desktop are identified as kde-foo.desktop
      because of the menu spec
      
      ```
      If the directory contains sub-directories then these sub-directories should be (recursively) scanned as well. The name of the subdirectory should be added as prefix to the desktop-file id together with a dash character ("-")
      ```
      
      the runner therefore broadly assumed that kde-foo.desktop is always
      the desktop file kde/foo.desktop and since kde/ was only used up to KDE3
      this assumption formed the basis for sepcial KDE3 compat handling. that is
      of course wrong because a service might just as well actually have a
      prefix and be actually called kde-foo.desktop rather than
      kde/foo.desktop. Specific example: kde-gtk-config.desktop
      
      seeing as this is ancient compatibility code that is actually wrong,
      the easiest solution seems to be dropping the code entirely (and thus no
      longer assume kde- has some special meaning).
      
      (also I didn't find a way to get the underlying filename of a kservice,
       so making the code not wrong seems non-trivial)
      
      CHANGELOG: the GTK+ settings module now correctly appears in krunner and kickoff
      BUG: 383287
      
      Test Plan: gtk kcm correctly shows up in both kickoff and krunner searches
      
      Reviewers: broulik
      
      Reviewed By: broulik
      
      Subscribers: GB_2, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19788
      1f3ab6f7
  10. 17 Mar, 2019 1 commit
  11. 16 Mar, 2019 5 commits
    • Krešimir Čohar's avatar
      [sddm-theme/lock screen] Use QQC2 for the clock labels · d7654042
      Krešimir Čohar authored
      Summary:
      This patch replaces the PlasmaComponents labels in Clock.qml with QQC2 ones. This resolves the issue of the clock letters/numbers getting clipped.
      
      BUG: 404651
      FIXED-IN: 5.15.3
      
      Test Plan:
      Before and after
      {F6680490}
      
      Reviewers: #plasma, #vdg, filipf, ngraham, hein
      
      Reviewed By: #plasma, #vdg, ngraham, hein
      
      Subscribers: mart, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10325
      
      Differential Revision: https://phabricator.kde.org/D19647
      d7654042
    • Krešimir Čohar's avatar
      [sddm-theme/lock screen] Overhaul font sizes · d3aa8b07
      Krešimir Čohar authored
      Summary:
      This patch:
      - tells the login screen to modify the font size specified in theme.conf and the lock screen to modify the user's default theme's font size instead
      - makes sure that the login screen session and keyboard buttons take this new approach too
      - raises the font size of "Start New Session" on the lock screen (to match the rest)
      - raises the artist/track font sizes (to match the password field)
      
      Test Plan:
      This patch resolves the problem of
      
      (1) The fonts on the login screen and
      
      {F6676520}
      
      (2) the fonts on the lock screen
      
      {F6676524}
      
      not having matching sizes.
      
      Reviewers: #vdg, #plasma, ngraham, filipf
      
      Reviewed By: #vdg, ngraham, filipf
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10325
      
      Differential Revision: https://phabricator.kde.org/D19631
      d3aa8b07
    • Kai Uwe Broulik's avatar
      [KSplashQML] Update stages comment and make code clearer · f899ccdc
      Kai Uwe Broulik authored
      There's an kcminit stage that wasn't documented.
      Also change m_stage and then check it so the number here matches the number of stages in the comment.
      
      CCBUG: 405446
      
      Differential Revision: https://phabricator.kde.org/D19801
      f899ccdc
    • Kai Uwe Broulik's avatar
      Merge branch 'Plasma/5.15' · d4b5eda1
      Kai Uwe Broulik authored
      d4b5eda1
    • Kai Uwe Broulik's avatar
      [KSplashQML] Register DBus before loading the splash theme · 9a4bb220
      Kai Uwe Broulik authored
      Loading the theme and setting everything up can take a while.
      Ensure that we catch all setStage calls that might have been emitted before we were fully up.
      
      CCBUG: 405444
      
      CHANGELOG: Reduced likelihood of KSplash not being dismissed properly and only timing out after 30s
      
      Differential Revision: https://phabricator.kde.org/D19753
      9a4bb220
  12. 14 Mar, 2019 4 commits
  13. 13 Mar, 2019 4 commits
  14. 12 Mar, 2019 1 commit
  15. 11 Mar, 2019 2 commits
  16. 09 Mar, 2019 5 commits
    • Krešimir Čohar's avatar
      Merge branch 'Plasma/5.15' · 4ede2e10
      Krešimir Čohar authored
      4ede2e10
    • Krešimir Čohar's avatar
      [notifications] Lift up notification content if one line of body text droops · 23f3345a
      Krešimir Čohar authored
      Summary:
      This patch lifts up the text content of notifications in which the combination of a single line of body text and its heading are taller than their icon and thereby prevents the notification content from drooping too far down and having too much of a bottom margin if it should become much larger than the icon. Seeing as the icon and its margins are never going to be taller than the content in question and the icon is always going to have 1 units.smallSpacing above it, this patch adjusts the height accordingly (0.5 units of smallSpacing above + 0.5 for the spacing below the heading + 0.5 below the content, accommodating the text) to achieve more even padding.
      This patch should also improve padding with fonts greater than 10 pt in size.
      
      BUG: 404407
      FIXED-IN: 5.15.3
      
      Test Plan:
      Before (left) and after (right):
      {F6616780}
      
      Reviewers: #plasma, #vdg, broulik, ngraham, filipf
      
      Reviewed By: #vdg, ngraham, filipf
      
      Subscribers: cfeck, anthonyfieroni, filipf, ngraham, abetts, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19036
      23f3345a
    • David Redondo's avatar
      Image Wallpaper Slideshow - display the list of images that will be shown · 2003b267
      David Redondo authored
      Summary:
      This shows all the pictures inside the folders added to the Folders list. I also tried to make single pictures excludable via a checkbox on the thumbnail. This is the first time for me programming with QT/QML/Singals-Slots and I tried to use as much existing code as possible. The thumbnail view is the same as for single images and I simply subclassed the listmodel. However even if I tried to do everything like the code for slidePaths it doesn't work correctly. The checking/unchecking of images only applies on restart of plasmashell. Maybe it's a single mistake that is easily spotted by a more experienced programmer otherwise if the thumbnail view is accepted I can also revert all the checkbox stuff.
      
      FEATURE: 403703
      FIXED-IN: 5.16.0
      
      {F6595564}
      
      Reviewers: #vdg, ngraham, davidedmundson
      
      Reviewed By: #vdg, ngraham, davidedmundson
      
      Subscribers: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D18809
      2003b267
    • Laurent Montel's avatar
      Fix warning == vs === · 19144ab0
      Laurent Montel authored
      19144ab0
    • Krešimir Čohar's avatar
      [sddm-theme/lock screen] Improve appearance in software rendering mode (outlines and icons) · aca7fd38
      Krešimir Čohar authored
      Summary: This patch improves the appearance of the sddm theme and the lock screen with software rendering in place (QT_QUICK_BACKEND=software) by adding an outline to the action buttons, correcting the error that prevented the username outline from appearing and by adding a background to the action buttons that are otherwise impossible to see on top of a very bright background in software rendering mode.
      
      Test Plan:
      Before (white background):
      {F6673579}
      After (white background):
      {F6673580}
      Before (Next):
      {F6673581}
      After (Next):
      {F6673582}
      
      Reviewers: #plasma, #vdg, ngraham, filipf
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10325
      
      Differential Revision: https://phabricator.kde.org/D19609
      aca7fd38
  17. 08 Mar, 2019 1 commit