1. 11 Mar, 2019 1 commit
  2. 03 Jan, 2019 1 commit
    • David Edmundson's avatar
      Fix model updates in RunnerMatchesModel · 892b1b9e
      David Edmundson authored
      Summary:
      RunnerMatchesModel is backed by a list. When this list changes
      RunnerManagerModel add/removes the new number of rows then called
      dataChanged on everything that remained.
      
      It's a common pattern, but not a great one. Especially with QtQuick
      where moving a delegate is faster than updating all the properties of an
      existing one - unfortunately I can't find a nice solution to do this
      properly in linear time.
      
      The problem with the current code is we update the entire list in the
      insert/remove rows. This is a violation of the model rules as we're
      updating rows outside the rows listed inside begin/remove rows.
      
      It works, but Qt's model test fails.
      
      We also have a lot of duplicates of a crash in QtQuick after runner
      model changes, bug 369430. I think it could be related, but can't
      prove anything.
      
      This patch updates the rows that exist in both the before and after
      models before adding/removing the remaining rows.
      
      BUG: 402439
      
      Test Plan:
      Added Qt model tester in https://phabricator.kde.org/P283
      It now passes.
      
      Reviewers: #plasma, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: hein, apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17725
      892b1b9e
  3. 29 Nov, 2018 1 commit
  4. 27 Nov, 2018 1 commit
  5. 26 Nov, 2018 2 commits
    • Kevin Funk's avatar
      Minor: Fix -Wextra-semi warning · 35ac6472
      Kevin Funk authored
      35ac6472
    • Kevin Funk's avatar
      ASAN: Fix leak in KAStatsFavoritesModel · 49676fe2
      Kevin Funk authored
      Summary:
      Trace:
      Direct leak of 336 byte(s) in 6 object(s) allocated from:
          #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
          #1 0x7fbad15cddaf in KAStatsFavoritesModel::Private::entryForResource(QString const&) const /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:171:24
          #2 0x7fbad15b2d8e in KAStatsFavoritesModel::Private::addResult(QString const&, int, bool) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:280:22
          #3 0x7fbad15b044f in KAStatsFavoritesModel::Private::Private(KAStatsFavoritesModel*, QString) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:233:13
          #4 0x7fbad15a78ea in KAStatsFavoritesModel::initForClient(QString const&) /home/kfunk/devel/src/kf5/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:485:13
          ...
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17039
      49676fe2
  6. 16 Nov, 2018 2 commits
  7. 27 Sep, 2018 2 commits
  8. 27 Aug, 2018 1 commit
  9. 08 Aug, 2018 1 commit
  10. 07 Aug, 2018 1 commit
  11. 06 Aug, 2018 1 commit
  12. 25 Jul, 2018 1 commit
  13. 11 Jul, 2018 5 commits
  14. 03 Jul, 2018 3 commits
  15. 01 Jun, 2018 3 commits
  16. 28 May, 2018 1 commit
  17. 21 May, 2018 1 commit
    • Nate Graham's avatar
      [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager · f753da05
      Nate Graham authored
      Summary:
      Users get confused by the difference between "Pin to Task Manager" and "Add to Panel (Widget)", and we get bugs about this.
      
      This patch resolves that confusion by only showing "Add to Panel (Widget)" when there's no Task Manager widget.
      
      BUG: 390817
      FIXED-IN: 5.14.0
      
      Test Plan:
      Dragging-and-dropping an app from Kicker or Kickoff pins it to the Task Manager if there's a Task Manager, or creates a Panel launcher if there's no Task Manager.
      
      Context menu items:
      
      Task Manager, widgets unlocked:
      {F5856628}
      
      Task Manager, Widgets locked:
      {F5856629}
      
      No Task Manager, Widgets unlocked:
      {F5856630}
      
      Task Manager, Widgets unlocked:
      {F5856631}
      
      Reviewers: #plasma, davidedmundson, mart
      
      Reviewed By: #plasma, mart
      
      Subscribers: mart, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D12969
      f753da05
  18. 18 May, 2018 3 commits
  19. 14 May, 2018 1 commit
    • Алексей Шилин's avatar
      Remove D10890 workaround · 3f52824b
      Алексей Шилин authored
      Summary:
      D10890 was a workaround related to KRecentDocument::add() bug (see D10863)
      which is fixed in Frameworks 5.46. Given that Plasma 5.13 depends on that
      Frameworks version, it's safe to remove this no longer needed workaround
      without breaking anything.
      
      Reviewers: #plasma, broulik, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D12701
      3f52824b
  20. 11 May, 2018 1 commit
  21. 18 Apr, 2018 1 commit
  22. 17 Apr, 2018 2 commits
  23. 05 Apr, 2018 2 commits
  24. 08 Mar, 2018 2 commits
    • Алексей Шилин's avatar
      Merge branch 'Plasma/5.12' · 4ed79745
      Алексей Шилин authored
      4ed79745
    • Алексей Шилин's avatar
      Don't skip certain recent documents in kicker and taskmanager · e64f95fe
      Алексей Шилин authored
      Summary:
      Due to KRecentDocument::add() bug, application name '<app>' could
      be stored for recent documents instead of its desktop entry name
      'org.kde.<app>'. This issue mostly affects items opened from apps
      themselves, while items opened from e.g. Dolphin are not affected.
      (The bug is fixed by D10863, but we depend on Frameworks 5.42 which
      doesn't include it.)
      
      Kicker and taskmanager used to query for '<app>' agent only, thus
      excluding items with correct 'org.kde.<app>' agent.
      
      This commit makes kicker and taskmanager query for both '<app>' and
      'org.kde.<app>' agents in order to get all recent documents for the
      application.
      
      Test Plan:
        # Create 'test1' and 'test2' text files.
        # Open 'test1' in Kate from Dolphin.
        # Open 'test2' from Kate itself.
        # Right-click Kate in Kicker/Kickoff and Task Manager and check
          that both files are present there.
      
      Reviewers: #plasma, broulik, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: anthonyfieroni, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10890
      e64f95fe