1. 15 Mar, 2021 3 commits
  2. 14 Mar, 2021 3 commits
    • Kai Uwe Broulik's avatar
      [Notifications] Support persistency · 5890aa64
      Kai Uwe Broulik authored
      This allows a client to mark a notification as "resident" which means it will
      not be closed by the sever when expired or an action is invoked, thus transferring
      full control over notification life time to the client.
      
      A notification popup still times out as normal (unless persistent, of course)
      but the notification remains alive until the client revokes it or a user
      explicitly closes it.
      
      It is opt-in so that a client can expect the notification lifetime to be
      indefinite and explicitly close it when an action is invoked on its end.
      5890aa64
    • Kai Uwe Broulik's avatar
      [Notifications] Emit dataChanged in setData call · d840c5dc
      Kai Uwe Broulik authored
      Ensures the role is properly signalled to have changed.
      
      CCBUG: 429862
      d840c5dc
    • Nicolas Fella's avatar
      Make krdb a proper library · c3e629df
      Nicolas Fella authored
      Making it a library instead of including the source from multiple places
      has several advantages. We get proper dependency and include path
      propagation. We can specify the krdb dependencies once instead of
      repeating them for each kcm. This allows for a better separation between
      the KCM's actual dependencies and krdb's dependencies.
      c3e629df
  3. 13 Mar, 2021 1 commit
    • Albert Astals Cid's avatar
      Don't extract QML as Java · 2d6b8da1
      Albert Astals Cid authored
      Doing so causes some trouble for our translators since %1% is marked as
      "this is a java printf" and then they can't translate it properly since
      well, this is not really a java printf
      2d6b8da1
  4. 12 Mar, 2021 1 commit
  5. 09 Mar, 2021 1 commit
  6. 08 Mar, 2021 4 commits
    • Nicolas Fella's avatar
      Remove dead cmake code · 4850e89b
      Nicolas Fella authored
      QT_DEFINITIONS is from the Qt4 era and does not contain anything these days
      4850e89b
    • Nicolas Fella's avatar
      Fix cmake coding style · dbddfbfe
      Nicolas Fella authored
      dbddfbfe
    • Kai Uwe Broulik's avatar
      [Notifications] Show which app will open a file when job finishes · e738abba
      Kai Uwe Broulik authored
      For example, show "Open with Gwenview" with its icon after downloading
      an image file, and "Open with..." in case there is no associated application.
      While at it also give an icon to the "Open Containing Folder" button.
      
      Also, port it to use a `KIO::mimetypeJob` to make it asynchronous
      and work on remote locations. To make for a less jarring transition (icon suddenly
      appearing, causing text reflow and the dialog to resize), take an initial
      guess about the mimetype using the file extension while the job is running.
      
      Furthermore, hide the "Open" actions in case the job fails which likely means
      the file doesn't exist anymore or cannot be accessed, and as as result
      probably cannot be opened anyway.
      e738abba
    • Chandradeep Dey's avatar
      Use a bigger image for lock screen avatar · 1c0c824c
      Chandradeep Dey authored and Méven Car's avatar Méven Car committed
      Lock screen avatar is blurry when using HiDPI scaling. This fixes that
      by adding a multiplication factor to the size of the retrieved image.
      
      CCBUG: 418546
      1c0c824c
  7. 07 Mar, 2021 6 commits
  8. 06 Mar, 2021 1 commit
  9. 05 Mar, 2021 4 commits
    • Nate Graham's avatar
      Remove "Show KRunner" item from desktop context menu · 1cb25441
      Nate Graham authored
      In the past, this was considered to be a way to make KRunner more
      discoverable by users.
      
      However today Kickoff exposes all the same runners as KRunner, so its
      full functionality is therefore more discoverable in a different way,
      so making the KRunner UI itelf more discoverable is not as important.
      
      Furthermore, this was always a questionable way to increase
      discoverability in the first place, because the menu item did not expose
      the keyboard shortcut, which is the typical way that people show
      KRunner. Also, context menus are generally considered shortcuts for
      experts; novice users don't tend to use context menus very much. But
      experts are the people more likely to already know about KRunner and its
      keyboard shortcut, and would never invoke it using the desktop context
      menu.
      
      Removing this menu item de-clutters the desktop context menu a bit, and
      we do get complaints that the menu is overwhelming because it has too
      many things in it. This is a fairly unimportant item that we can remove
      without any real consequences.
      
      Finally, Marco didn't like the change to refer to KRunner using the
      actual term "KRunner" in the main UI, so this change removes one of the
      two places where that happened. :)
      1cb25441
    • Nate Graham's avatar
      Port to singleton Units · 2f4b27fc
      Nate Graham authored
      The context property version is slower to access and won't be supported
      in Qt6. Let's port away from it and use the singleton version instead.
      
      Here was my full process for making this change:
      
      1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
      2. Verified no more occurrences with `grep -r " units."`
      3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+   " | grep "//"`
      4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
      5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done`
      2f4b27fc
    • Nate Graham's avatar
      Use more standard duration values · c22feb74
      Nate Graham authored
      This lets these durations be scaled or disabled according to the user's
      preferences.
      
      CCBUG: 433948
      c22feb74
    • Marco Martin's avatar
      proper form factor filtering · 9dba1a78
      Marco Martin authored
      consider an applet acceptable for the formfactor if at least one
      of its formfactors are contained in KDeclarative::runtimePlatform
      
      or if either KDeclarative::runtimePlatform or applet formfactors
      are empty.
      (before informFactor failed if even one of the applet supported
      formfactors was not in runtimePlatform
      
      BUG:433983
      9dba1a78
  10. 04 Mar, 2021 3 commits
  11. 03 Mar, 2021 3 commits
    • David Redondo's avatar
      Krunner: Add icon to desktopfile · 12dadab7
      David Redondo authored
      Allows me to not longer hardcode the icon in the shortcuts kcm.
      12dadab7
    • David Edmundson's avatar
      Fix query of StartPlasma::hasSystemdService · 1c7e3064
      David Edmundson authored and Henri Chain's avatar Henri Chain committed
      ListUnitByNames did not quite work as the author (me) expected. Whilst a
      search for "adsfasf" yeilded an empty list a well-formed name like
      "asdfasdf.service" would return a result to say that service was not
      loaded.
      
      This means our runtime detection of xdg-autostart-generator failed.
      
      By using ListUnitFilesByPatterns we can filter on the status in the
      query, meaning this code works again. We also can query the case of it
      being available but explicitly disabled.
      
      BUG: 433333
      1c7e3064
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 9493c9a2
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      9493c9a2
  12. 02 Mar, 2021 5 commits
  13. 01 Mar, 2021 3 commits
  14. 28 Feb, 2021 1 commit
    • Xuetian Weng's avatar
      Roll forward of 49346b0b · e9c8b655
      Xuetian Weng authored
      This add fix to avoid session specific environement variable to be
      leaked into new session.
      
      Also, it will restore the old systemd session variable upon shutting
      down.
      e9c8b655
  15. 27 Feb, 2021 1 commit