1. 12 May, 2020 6 commits
  2. 11 May, 2020 10 commits
    • Eugene Popov's avatar
      [applets/notifications] Remain visible after removing all notifications while... · e6ed4a88
      Eugene Popov authored and Nate Graham's avatar Nate Graham committed
      [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open
      When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself.
      BUG: 421344
      Reviewers: ngraham, plasma-devel, broulik
      Reviewed By: ngraham, broulik
      Subscribers: broulik
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29651
    • Konrad Materka's avatar
      [applets/systemtray] Show base icon when AttentionIcon not set · 00e64bdb
      Konrad Materka authored
      If status is set to NeedsAttention it tries to use Attention Icon. If Attention Icon is not set, empty/null QIcon is set. QML can't check if QIcon is null or not, as a result it tries to use empty icon and nothing is rendered.
      Set null QVariant if AttentionIcon is not valid so that QML check will work correctly.
      Test Plan:
      * Set NeedsAttention as a status and with no Attention Icon
      * Base Icon should render correctly
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, mart
      Reviewed By: #plasma_workspaces, #plasma, mart
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29544
    • Nate Graham's avatar
      [applets/icon] Remove icon from tooltip · 65f06786
      Nate Graham authored
      CCBUG: 420934
      Ref T12778
    • Arjen Hiemstra's avatar
      Use the right targets for KSysGuard · 8ae9b561
      Arjen Hiemstra authored
      Summary: Otherwise the build fails when things try to link to KF5::SysGuard etc.
      Test Plan: Builds again
      Reviewers: #plasma, meven
      Reviewed By: meven
      Subscribers: meven, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29628
    • David Redondo's avatar
      Improve StatusNotifierTest · 5459a533
      David Redondo authored
      Allows to set Icon, AttentionIcon and OverlayIcon either by name or pixmap.
      Makes it easier to test combinations of those.
      Reviewers: kmaterka, apol
      Reviewed By: kmaterka, apol
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29619
    • Marco Martin's avatar
      Redesign of system monitor plasmoids · c8deafbb
      Marco Martin authored
      Those plasmoids are intended to replace the old systemmonitor plasmoids
      They are based upon the new ksysguard daemon: see D28333 and D28141
      It has pluggable presets and sensor "faces" which are available from the KDE store
      Every preset is available as a separate plasmoid.
      By default are installed ones to replace
      roughly one by one the existing systemmonitor plasmoids so systems that use it
      will get the new ones in the updates
      Depends on D28922
      Test Plan: {F8209642}
      Reviewers: #plasma
      Subscribers: alexde, ngraham, davidedmundson, mmustac, ahiemstra, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D28487
    • Méven Car's avatar
      Fix Warning about KF5::KSysGuard target being deprecated · d2c57378
      Méven Car authored
      Warnings such as:
      CMake Warning at /usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:37 (me
        The KF5:: namespace for KSysGuard targets is deprecated.  Please use
         KSysGuard as namespace.
       Call Stack (most recent call first):
         /usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package)
         CMakeLists.txt:55 (find_package)
      Test Plan: cmake does not output those warnings
      Reviewers: #plasma, ahiemstra, davidedmundson
      Reviewed By: #plasma, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29623
    • Marco Martin's avatar
      force systemsettings for kcms · e67e8d6d
      Marco Martin authored
      as we can't kill completely kcmshell just yet, hack intothe services runner to
      replace on the fly the exec line of the service to systemsettings
      BUG: 402790
      FIXED-IN: 5.19.0
      Test Plan:
      search and launch directly for a module, systemsettings is launched wit hthe
      proper module loaded
      Reviewers: #plasma, ngraham
      Reviewed By: ngraham
      Subscribers: broulik, ngraham, davidre, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29157
    • Bhushan Shah's avatar
      libnotificationmanager: fix the checkIndex after moving around functions · dbc7bd3c
      Bhushan Shah authored
      Fix in the f2e34dbb got partially reverted by introduction
      of AbstractNotificationsModel in 2357e6f2.
    • Bhushan Shah's avatar
      [libnotificationmanager] introduce the WatchedNotificationsModel · 2357e6f2
      Bhushan Shah authored
      Summary: This allows one to subscribe to notifications from notification server.
      Test Plan:
      tested using very simple QML
      import QtQuick 2.0
      import org.kde.notificationmanager 1.1 as Notifications
      Notifications.NotificationWatchedModel {
          id: model
      Reviewers: #plasma, broulik, davidedmundson
      Reviewed By: #plasma, broulik
      Subscribers: nicolasfella, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D28509
  3. 10 May, 2020 2 commits
  4. 08 May, 2020 1 commit
  5. 07 May, 2020 1 commit
    • Konrad Materka's avatar
      [applets/systemtray] Hide/show expander arrow - regression fix · b34e88da
      Konrad Materka authored
      Expander arrow should hide when all icons are visible and no icon is hidden. When dialog with hidden items is hidden ListView does not update its count property - property is update on redraw. As a result expander arrow is still visible/hidden until user clicks on any plasmoid to show dialog.
      BUG: 420924
      Test Plan:
      * select/deselect "Show all items" in settings, save, expander arrow should hide/show imidiatelly
      * select almost all items to "Always shown", leave "Keyboard indicator" as "Shown when relevant". Press Casp Lock, expander arrow should hide/show correctly
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
      Reviewed By: #plasma_workspaces, #plasma, broulik, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D28180
  6. 06 May, 2020 5 commits
  7. 05 May, 2020 2 commits
  8. 04 May, 2020 7 commits
    • Konrad Materka's avatar
      Merge branch 'Plasma/5.18' · bb053d8c
      Konrad Materka authored
    • Konrad Materka's avatar
      [systemtray] Fix SNI icon not rendering · 77975468
      Konrad Materka authored
      In some rare situations SNI icons are not rendered. It happens randomly, only some users are affected. It does not happen on every login.
      Only SNI icons are not rendered, Plasmoids are fine. Restarting plasmashell or re-adding systemtray applet helps.
      In QML all roles need to be defined before model is used. When data engines is used a a source for a data model, all roles has to be defined and proper value assigned (not a null QVariant). StatusNotifierItemSource does this properly, but in some situations it sets null QVariant for Icon. Setting empty/null QVariant removes key/role from the date set (DataConteiner implementation). If data model was loaded earlier or later when Icon has proper value it will work properly. In some rare situation it is possible that data model is loaded when Icon has null value assigned (in other words - removed), role is removed from the data model and not avaiable to system tray applet.
      This fix makes sure that there is always a value for Icon role. To check if icon is null native method has to be used - QML does not understand that QIcon can be null.
      BUG: 419305
      FIXED-IN: 5.18.5
      Test Plan: I don't have any reliable method to reproduce this issue.
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
      Reviewed By: ngraham
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29386
    • Nate Graham's avatar
      [applets/batterymonitor] Port inhibition message to Layouts and match notifications applet · d62fd2dd
      Nate Graham authored
      This makes it take up less vertical space in the header area and also match the similar
      message in the notifications applet.
      Test Plan: {F8274308}
      Reviewers: #vdg, #plasma, broulik, manueljlin, mart
      Reviewed By: #vdg, #plasma, mart
      Subscribers: plasma-devel
      Tags: #plasma
      Maniphest Tasks: T10470
      Differential Revision: https://phabricator.kde.org/D29315
    • Nate Graham's avatar
      [wallpapers/image] Port to BasicListItem+subtitle · 71f1ff8e
      Nate Graham authored
      This allows us to use the new consistent appearance introduced with D29074.
      Depends on D29074
      Test Plan: {F8273822}
      Reviewers: #plasma, #kirigami
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29075
    • Kai Uwe Broulik's avatar
      Merge branch 'Plasma/5.18' · 9289f85d
      Kai Uwe Broulik authored
    • Kai Uwe Broulik's avatar
      [KRunner] Watch config with KConfigWatcher · 6db69ae0
      Kai Uwe Broulik authored
      Rather than using a KDirWatch that points to the wrong place.
      Differential Revision: https://phabricator.kde.org/D29411
    • Konrad Materka's avatar
      [applets/systemtray] Fix invisible plasmoid icons when Media Player is added · 026a2917
      Konrad Materka authored
      After adding a new plasmoid (applet), for example a new Media Player, several empty icons are rendered in the system tray which hides existing icons.
      The bug occurs after opening Gwenview while the Media Player applet is NOT in use.
      The systray icons reappear when Gwenview is closed or another source starts playing.
      BUG: 418662
      Test Plan: Start Gwenview when Media Player is not in use. All icons should render correctly.
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, apol, davidedmundson, mart
      Reviewed By: #plasma_workspaces, #plasma, mart
      Subscribers: apol, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29344
  9. 03 May, 2020 2 commits
    • Filip Fila's avatar
      [System Tray] Always draw the highlight behind the icon · 3f063495
      Filip Fila authored
      There was a slight issue introduced with D28109: the systray highlight can now cover up the icons it's highlighting.
      This isn't really an issue with Breeze because it uses a line for a highlight, but it is for themes that use a filled-style highlight.
      I set a z value for the highlight that should ensure it's now drawn only behind the icon.
      Test Plan:
      Tested with the //Mondrian// Plasma theme
      Reviewers: kmaterka, #plasma
      Reviewed By: kmaterka
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29380
    • Konrad Materka's avatar
      [applets/systemtray] Fix value read in some onXyxChanged connections · efe4b603
      Konrad Materka authored
      Summary: Some `onXyzChanged` signals do not send value - fix connection to use value directly from the sender.
      Test Plan: Disable or enable plasmoid in System Tray setting - it should work correctly.
      Reviewers: #plasma_workspaces, #plasma, ngraham, apol, broulik, davidedmundson
      Reviewed By: apol
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D29356
  10. 01 May, 2020 4 commits