It makes it uniform with most other applets, and for some setups/editors
it makes it easier to locate this file.

Unfortunately, the list<> basic QML type is too primitive, it does not
even expose any kind of remove() functionality, so the only supported
way is to create a new list and assign it instead.

This fixes the bug when there may appear multiple empty or duplicating
actions in the expanded view due to the fact they they were only added
to but never cleaned up / removed from the list of contextual actions.

BUG: 449778

If the time between logout and relogin is short enough or a separate session
is open during that time, the systemd user instance keeps running. This means
that generators like the one for XDG autostart handling aren't run again, which
effectively means it's still using the configuration from the previous session.

Just reload systemd on every login to make sure its state is fresh.

A few KDE versions ago, the KCM and app results were provided by the same plugin.
To make sure they do not appear very far down the list, the plugin id is inserted right after the services runner.

CCBUG: 446239

A KPackage wallpaper containing a dark variant is added to the test
data.

CCBUG: 207976

CCBUG: 207976

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Dark wallpapers are put in contents/images_dark folder. The dark
wallpaper will be used when system color scheme is dark.

FEATURE: 207976
FIXED-IN: 5.26

Derek Christ authored Jun 06, 2022 and Nate Graham committed Jun 06, 2022

CCBUG: 453828

restore(...) will set the wallpaper type from the value of key "wallpaperplugin".

BUG: 454597
FIXED-IN: 5.24.6

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Fushan Wen authored Jun 06, 2022 and Nate Graham committed Jun 06, 2022

BUG: 454908
FIXED-IN: 5.26

Fushan Wen authored Jun 04, 2022 and Alexander Lohnau committed Jun 05, 2022

C-style pointer casting (CWE-398)

Fushan Wen authored Jun 04, 2022 and Alexander Lohnau committed Jun 05, 2022

Unused variable: list (CWE-563)

Fushan Wen authored Jun 04, 2022 and Alexander Lohnau committed Jun 05, 2022

Variable 'ksplash' is assigned a value that is never used. (CWE-563)

Fushan Wen authored Jun 04, 2022 and Alexander Lohnau committed Jun 05, 2022

Function parameter 'hint' should be passed by const reference. (CWE-398)

The formFactor has been set, either by `ShellCorona::addPanel` or the
ctor of `ContainmentPrivate::ContainmentPrivate`, so it's redundant to
set the default value here again, or the panel will be added to the top
edge again and again.

This prvents the file from being installed with the image package.

CCBUG: 358038

This fixes a crash when removing the digital applet from a new panel.

BUG: 454846
FIXED-IN: 5.26

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Enable the apply button after:

1. Drag and drop
2. Add an image using the file dialog
3. Delete an image that is not the currently selected one

Use url data type directly, no need to convert url to string.

The current shortcuts could conceivably override app shortcuts, since
they don't use the Meta key. The following changes are made:

Automatic Action Popup Menu:                 Ctrl+Alt+X -> Meta+Ctrl+X
Manually Invoke Action on Current Clipboard: Ctrl+Alt+R -> Meta+Ctrl+R

These are safe to change in the code rather than adding a new one and
keeping the old ones around for compatibility's sake because
KGlobalAccel::setGlobalShortcut by default preserves old shortcuts
when they are changed, and we aren't overriding that behavior here. So
only new installs will get the new shortcuts and existing user installs
will be untouched.

There's 4 unit (Items got added) now. Unlikely a job has all of them, however.

Fushan Wen authored May 31, 2022 and Nate Graham committed Jun 02, 2022

FEATURE: 403384
FIXED-IN: 5.26

ivan tkachenko authored Jun 01, 2022 and Nate Graham committed Jun 02, 2022

BUG: 434972

This reverts commit e26425e5.

The KCM does not always include the install folder in the search paths.

As discussed in !1233, a revert is
the best option for the time being.

BUG: 453765

Fushan Wen authored Jun 02, 2022 and Nate Graham committed Jun 02, 2022

In panelview.cpp, the old window focus is restored when switching to
Passive status. This fixes the behavior by setting the panel status to a
status that is not AcceptingInputStatus.

BUG: 454729
CCBUG: 352476
FIXED-IN: 5.25

This is a common snippet of code in applets. It prevents applet from
re-expanding again when user clicks on the compact representation when
the applet is already expanded and located on a desktop containment.

This is a common snippet of code in applets. It prevents applet from
re-expanding again when user clicks on the compact representation when
the applet is already expanded and located on a desktop containment.

This will be used to show all sections in "All Applications".

Otherwise the user needs to manually tab over to the Unlock button
first, which is annoying. And they may not even think to do it at all.

The `forceActiveFocus()` is because the stack view does not manually pass focus
to the item you push onto it; this needs to be handled manually.

BUG: 454707