1. 08 Jun, 2022 1 commit
  2. 08 Mar, 2022 1 commit
  3. 17 Dec, 2021 1 commit
  4. 20 Oct, 2021 1 commit
  5. 03 Sep, 2021 1 commit
  6. 14 Aug, 2021 1 commit
  7. 18 Jul, 2021 1 commit
  8. 25 May, 2021 1 commit
  9. 08 May, 2021 1 commit
    • Nate Graham's avatar
      [applets/devicenotifier] Open Automount KCM with configure button · ba3c4d49
      Nate Graham authored
      This applet no longer has a config window with any non-autogenerated
      content in it, so it doesn't make sense for the configure button to open
      that window rather than the Automount KCM. This is what most other
      applets do nowadays; the Disks & Devices applet should be consistent.
      ba3c4d49
  10. 05 Mar, 2021 1 commit
    • Nate Graham's avatar
      Port to singleton Units · 2f4b27fc
      Nate Graham authored
      The context property version is slower to access and won't be supported
      in Qt6. Let's port away from it and use the singleton version instead.
      
      Here was my full process for making this change:
      
      1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
      2. Verified no more occurrences with `grep -r " units."`
      3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+   " | grep "//"`
      4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
      5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done`
      2f4b27fc
  11. 15 Dec, 2020 1 commit
  12. 09 Nov, 2020 1 commit
  13. 05 Nov, 2020 1 commit
    • Marco Martin's avatar
      put selection of which items are visible in a popup menu · bfe0f301
      Marco Martin authored
      the comboboix of a very rarely used feature right
      in the header area is super noisy, looks misaligned and puts the feature
      in a too much prominent role.
      Put everything under a popup menu, mustually exclusive actions will be
      shown as radiobuttons
      bfe0f301
  14. 02 Nov, 2020 1 commit
  15. 03 Oct, 2020 1 commit
  16. 17 Aug, 2020 2 commits
    • Nate Graham's avatar
      [applets/devicenotifier] Remove UI to suppress popup for new device connection · ff544ed5
      Nate Graham authored
      This option is just too nerdy to show a UI for. We keep the logic for it
      in the code (it's just two lines) but it's now only available for people
      who know about this and manually add "popupOnNewDevice=false" to their
      plasma-org.kde.plasma.desktop-appletsrc file.
      
      This prevents the applet from being too cluttered with options with the
      new design.
      ff544ed5
    • Nate Graham's avatar
      [applets/devicenotifier] Move all settings into main UI itself and rename · b878a64c
      Nate Graham authored
      Right now the Device Notifier applet has two settings: what kind of
      devices to show, and whether or not to open on new device attachment.
      
      My sense is that nobody knows that these options exist because they're
      hidden away in a config window that you can only access by
      right-clicking on the item in the system tray.
      
      Furthermore, the setting for what kind of devices to show is more useful
      than we give it credit for; when set to "All devices", the applet functions
      as an always-visible way to access all of the machine's disks. This is
      quite handy.
      
      Accordingly, this commit removes the config window and moves all of the
      settings into the main UI of the applet using PlasmoidHeaders--one
      header and one footer, exactly like the plasma-pa applet.
      
      With this change, the "Show all devices" feature becomes discoverable:
      when you plug in a flash drive or whatever, the applet will pop open,
      showing you the combobox that chooses what it will display. In this moment,
      you can notice it, play with it, and configure it to show all devices if
      you'd like.
      
      Accordingly again, the name of the applet is renamed to "Disks &
      Devices" since "Device Notifier" is not an accurate name. It was only
      ever accurate when using the applet's default settings, and now that
      non-default settings are made more discoverable, it feels appropriate
      to give it a more generally appropriate name.
      b878a64c
  17. 07 Aug, 2020 1 commit
  18. 14 Jul, 2020 1 commit
    • Nate Graham's avatar
      [applets/devicenotifier] Port to ExpandableListItem · b16eee88
      Nate Graham authored
      Summary:
      Port the Device Notifier to use an ExpandibleListItem.
      
      Tested with:
      - Removable flash drive
      - Removable LUKS-encrypted hard disk drive
      - Android phone
      - iOS phone
      - Internal disks
      
      No regressions or departures from the current behavior were found.
      
      The only major UI change is the loss of the progress bar, which is difficult
      to display properly with an ExpandableListItem. It is replaced with a textual
      display of free space and total space in the subtitle, which is more consistent with the
      appearance of other ExpandableListItem-using applets, and IMO is more useful anyway.
      b16eee88
  19. 19 May, 2020 1 commit
    • Nate Graham's avatar
      [applets] Show KCMs in System Settings or Info Center, as appropriate · e8c72744
      Nate Graham authored
      Summary:
      CCBUG: 417836
      
      Depends on D29711
      
      As this will depend on Frameworks 5.71, it will be landed on master after branching,
      ending up in Plasma 5.20.
      
      Test Plan:
      Right-click on applets and activate their configure menu items
      Open applets and click on their settings buttons
      Observe that the KCMs are opened in System Settings or Info Center
      (depending on the context)
      
      Reviewers: mart, #plasma
      
      Reviewed By: mart, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29712
      e8c72744
  20. 17 Oct, 2019 1 commit
  21. 09 Mar, 2019 1 commit
  22. 17 Jan, 2019 1 commit
    • Thomas Surrel's avatar
      [Device Notifier] Add a button to unmount all devices · 81db7443
      Thomas Surrel authored
      Summary:
      When at least two removable devices are mounted, a button shows
      up that will allow to unmount all mounted removable devices.
      This is convenient for removable drives with several partitions,
      each of which have to be unmounted to be able to safely plug the
      device out.
      
      {F6330009}
      
      FEATURE: 395644
      
      Test Plan:
      Plug and mount two devices.
      Click on the new 'unmount all' button.
      
      Reviewers: #plasma, #vdg, ngraham, broulik
      
      Reviewed By: #plasma, #vdg, ngraham, broulik
      
      Subscribers: abetts, broulik, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16212
      81db7443
  23. 09 Jan, 2019 1 commit
    • Thomas Surrel's avatar
      [Device Notifier] Restore busy indicator · a7b2ecdb
      Thomas Surrel authored
      Summary:
      This patch fixes two issues:
      - the 'state' of the device now propagates correctly, that makes the busy indicator be displayed again, device emblems are also updated correctly
      - there is no more delay between the moment when the device is actually mounted and the moment the device notifier says it is. The worst case used to be 5 seconds.
      
      BUG: 354321
      BUG: 399986
      
      Reviewers: #plasma, #vdg, broulik, bruns, ngraham, davidedmundson
      
      Reviewed By: #plasma, #vdg, ngraham, davidedmundson
      
      Subscribers: mart, cfeck, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16170
      a7b2ecdb
  24. 08 Oct, 2018 1 commit
    • Thomas Surrel's avatar
      [Device Notifier] Auto-hide popup after device is unmounted · 58188935
      Thomas Surrel authored
      Summary:
      When unmounting a removable device from dolphin, the device notifier
      will popup saying the device can now be safely removed. But the popup
      never auto-hides.
      
      Test Plan:
      Plug a USB pen drive
      Unmount it from dolpin
      Device notifier should popup and hide itself after 3 seconds
      
      Reviewers: #plasma, #vdg, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16045
      58188935
  25. 24 Sep, 2018 1 commit
    • Stefan Brüns's avatar
      [Device Notifier] Avoid accessing attributes of stale UDIs · 61b2b173
      Stefan Brüns authored
      Summary:
      When a Solid device is removed (e.g. a CD is ejected) the notifier tries
      to read the attributes although the Source for the UDI has just vanished.
      
      Fixes several QML error messages, i.e. "TypeError: Cannot read property
      '...' of undefined" and "Unable to assign [undefined] to QString".
      
      Apparently these errors also have the effect of items showing outdated
      state, i.e. optical media still being shown after ejecting it.
      
      CCBUG: 394348
      
      Test Plan:
      1. insert optical medium
      2. eject
      Without the changes, the item was stuck
      Now, the item is removed as soon as the medium is ejected
      
      Also, no more errors are logged for the devicenotifier
      
      Reviewers: #frameworks, broulik
      
      Reviewed By: broulik
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15687
      61b2b173
  26. 01 Mar, 2018 1 commit
    • Marco Martin's avatar
      auto hide popup when it opened itself · 2da603f9
      Marco Martin authored
      Summary:
      when the device notifier pops up automatically, leave it open
      if there is no user activity, if there is any, close after around
      3 seconds. Suspend the countdown if the notifier window either has
      focus or the mouse cursor is over it, leaving the user the time to
      go interact. if it doesn't have focus and the mouse leaves, resume
      the countdown
      replaces D10591
      
      Test Plan:
      tested for a while in a real world usage, it behaves in a fairly natural
      way
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10921
      2da603f9
  27. 21 Sep, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Device Notifier] Only ever pop up if device is visible in the list · b28ea53b
      Kai Uwe Broulik authored
      When a device notification arrives, such as "you can now safely unmount" or "failed to unmount"
      device notifier would unconditionally open showing an empty list.
      
      Since we now show device notifications only connected to the device they're about, it makes no
      sense to expand it for invisible devices. Applications where mounting or unmounting can fail
      for non-removable devices, like Dolphin, already show the error message within the UI anyway,
      making the popup redundant.
      
      BUG: 368894
      FIXED-IN: 5.8.0
      
      Differential Revision: https://phabricator.kde.org/D2823
      b28ea53b
  28. 01 Jul, 2016 1 commit
  29. 15 Jun, 2016 1 commit
  30. 13 Jun, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Device Notifier] Be more declarative · 6c0b1e54
      Kai Uwe Broulik authored
      Instead of having a bunch of handlers in various places messing with various settings,
      try to use declarative bindings where possible.
      
      * Remove separate passive timer, instead re-use the pendingDelegateRemoval property
        which has its own timer. This way, when a device is unmounted, device notifier stays
        active until the notification has cleared, however, when the device is yanked out manually,
        it disappears right away
      * Don't break binding on Plasmoid.active to ensure its state is always proper depending on
        whether a device or not is present (the linked bug)
      * Create tooltip declaratively rather than imperatively
      
      BUG: 362992
      FIXED-IN: 5.7.0
      
      Differential Revision: https://phabricator.kde.org/D1793
      6c0b1e54
  31. 07 Jun, 2016 1 commit
  32. 24 Jan, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Device Notifier] Provide inline feedback · 1ed7209f
      Kai Uwe Broulik authored
      Instead of showing a detached status bar with the device name, show the message
      below the device in the list.
      
      When removing a device, device notifier will pop up and a "You can now safely remove
      this device" message will show up with a highlight gradually fading away until 5 seconds
      later the device is removed from the list.
      
      REVIEW: 126688
      1ed7209f
  33. 09 Jan, 2016 1 commit
  34. 07 Oct, 2015 2 commits
  35. 17 May, 2015 1 commit
  36. 25 Nov, 2014 1 commit
  37. 07 Nov, 2014 1 commit
  38. 16 Jun, 2014 1 commit