1. 05 Oct, 2020 2 commits
    • Eike Hein's avatar
      [libtaskmanager] Remove a poorly conceived optimization · 82b4b70f
      Eike Hein authored
      The LauncherTasksModel tried to avoid a model reset by making certain
      assumptions to save a few cycles. Ultimately this was misguided, in-
      correctly not evicting the internal app data cache as well as causing
      a lot more work in the view trying to compute layout deltas and some-
      times causing a few frames of ugly animations.
      
      There likely _is_ some optimization potential here, but it needs to
      be done smarter later on.
      
      (cherry picked from commit 40d7df21)
      82b4b70f
    • Eike Hein's avatar
      [libtaskmanager] Fix incorrect URL comparison when writing back a new launcher order · 21dce8da
      Eike Hein authored
      When computing the delta between the visible and the last saved launcher
      order state, following the reordering of launchers, the code was incorrectly
      comparing resolved and unresolved (i.e., for config storage) launcher URLs.
      This lead to an incorrect result and therefore pinned tasks jumping around
      in the Task Manager applet.
      
      BUG:426880
      (cherry picked from commit fa00ca6a)
      21dce8da
  2. 04 Oct, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Set list sizes correctly · 04b89630
      Nate Graham authored
      1. Use Kirigami, not PlasmaCore, since this is a config window
      2. Remove PlasmaCore import now that it's no longer used
      3. Set implicitWidth/height on Kirigami.Icon, not width/height
      4. Use SmallMedium icon sizes, which is typical for list items like this
      
      (cherry picked from commit e43c766d)
      04b89630
  3. 03 Oct, 2020 2 commits
  4. 02 Oct, 2020 4 commits
    • Nate Graham's avatar
      [applets/systemtray] Fix size of grid on really thick panels · a54d1901
      Nate Graham authored
      Now the grid can have more than 2 rows/columns on really thick panels,
      just like in Plasma 5.19 and earlier.
      
      BUG: 427251
      FIXED-IN: 5.20
      
      
      (cherry picked from commit 649b50cd)
      a54d1901
    • Nate Graham's avatar
      [applets/systemtray] Fix closing active applet by clicking it again · bbce3c93
      Nate Graham authored
      This was removed by mistake in !285
      
      
      (cherry picked from commit bd2fcb05)
      bbce3c93
    • Vlad Zahorodnii's avatar
      [Shell Corona] Work around popup dismissal bug on Wayland · 329db2a6
      Vlad Zahorodnii authored
      A popup needs to grab the keyboard and the pointer in order to dismiss
      itself when another window is clicked. It works perfectly on X11.
      
      On Wayland though, the compositor is responsible for dismissing popups
      if some surface of another application has been clicked. Note that I
      said "of another application." If user clicks some surface of the same
      application, the compositor won't dismiss the popup.
      
      If the application uses only QtWidgets, then the popup will be closed
      as expected in both cases. But if the application uses both Qt Quick and
      Qt Widgets, e.g. plasmashell, then the popup won't be dismissed if a
      QQuickItem has been clicked.
      
      It is a Qt bug, but for the time being, this change introduces an event
      filter that monitors Qt::MouseButtonPress events and when needed closes
      the active popup widget. This is a workaround.
      
      CCBUG: 379635
      
      
      (cherry picked from commit 6689abaf)
      329db2a6
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 2907cb04
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      2907cb04
  5. 01 Oct, 2020 1 commit
  6. 30 Sep, 2020 2 commits
    • David Edmundson's avatar
      [containmentactions] Guard against having no virtual desktops · 5cb38dae
      David Edmundson authored
      It can apparently happen that virtual desktops is empty at a given point
      in time. Potentially due to other bugs on the system.
      
      Calls to desktopIds.at(N) will fail.
      
      BUG: 427106
      
      
      (cherry picked from commit 2441c82a)
      5cb38dae
    • David Edmundson's avatar
      [libkworkspace] Port from deprecated GetSessionByPID · 3acf8f30
      David Edmundson authored
      This method calls doesn't seem to work anymore having been replaced by
      the more intuitve virtual paths on the logind over a year ago.
      
      Arguably that's still a bug upstream that GetSessionByPID no longer
      works correctly, but we may as well port to the simpler path that avoids
      so many layers of indirection.
      
      Use of "/auto" does not exist on old distros so the legacy path is kept.
      
      The paths used in this class were always wrong, which went unnoticed as
      this is the first usage of them.
      
      BUG: 423526
      
      
      (cherry picked from commit bb7b1226)
      3acf8f30
  7. 29 Sep, 2020 1 commit
  8. 28 Sep, 2020 2 commits
  9. 27 Sep, 2020 1 commit
  10. 25 Sep, 2020 2 commits
  11. 24 Sep, 2020 2 commits
  12. 23 Sep, 2020 1 commit
    • Harald Sitter's avatar
      disable ksyscoca rebuilding in appstream runner · d684f832
      Harald Sitter authored
      same as 5a648c56 for the service runner.
      
      Kservice internally will hold a KDirWatch instance through KSycoca and
      that instance has an inotify instance. Since inotify instances have a
      per-user limit we mustn't be wasteful with them. Since our runner
      threads do not actually need automatic ksyscoca reloading (reloading
      on-demand as we use ksyscoca is perfectly reasonable) we need to
      explicitly disable this feature so the internal inotify instance can be
      freed.
      
      CCBUG: 423818
      
      
      (cherry picked from commit 783e856e)
      d684f832
  13. 22 Sep, 2020 3 commits
  14. 21 Sep, 2020 1 commit
  15. 20 Sep, 2020 1 commit
  16. 19 Sep, 2020 1 commit
    • Nate Graham's avatar
      Add margins to System Activity window · a1bf7ba2
      Nate Graham authored
      Right now it is deliberately setting the margins to zero, which causes
      all of its UI controls and framed areas to touch the window border,
      which looks bad and is just an incorrect thing to do in general for a
      thing that does not deliberately provide its own margins for content.
      
      Let's not do that anymore, so the window looks better.
      
      BUG: 426661
      FIXED-IN: 5.20
      
      
      (cherry picked from commit 42e2078c)
      a1bf7ba2
  17. 18 Sep, 2020 2 commits
  18. 17 Sep, 2020 5 commits
  19. 16 Sep, 2020 6 commits