1. 26 Jan, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Remove scrollbar paddings · 82d7fd7a
      Konrad Materka authored
      Summary: Removes additional paddings. Not needed when scrollbar is no longer overlaying content. See: D26530
      
      Test Plan:
      1. Open configuration window
      2. No paddings
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, nicolasfella
      
      Reviewed By: nicolasfella
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26924
      82d7fd7a
  2. 22 Jan, 2020 2 commits
  3. 21 Jan, 2020 3 commits
  4. 20 Jan, 2020 1 commit
  5. 19 Jan, 2020 1 commit
  6. 18 Jan, 2020 1 commit
  7. 16 Jan, 2020 8 commits
  8. 15 Jan, 2020 7 commits
    • Tranter Madi's avatar
      Fix wallpaper destination path · 2212a9af
      Tranter Madi authored
      Summary:
      - Correct the destination path when downloading images.
      - Switch from FileCopyJob to CopyJob to allow showing file overwrite dialog.
      
      BUG: 379469
      
      Test Plan: Drop files from Firefox to the desktop to set the wallpaper successfully.
      
      Reviewers: #plasma, mart, ngraham
      
      Reviewed By: #plasma, mart, ngraham
      
      Subscribers: mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26525
      2212a9af
    • Konrad Materka's avatar
      [SystemTray] Rework system tray settings · e2bfeb16
      Konrad Materka authored
      Summary:
      Combines settings of SNI icons and plasmoids in one list. Ability to disable whole section is removed.
      
      Initial idea was proposed by Nicolas Fella (D22176).
      
      BUG: 360307
      FIXED-IN: 5.18.0
      
      {F7880936}
      
      Test Plan:
      1. Disable/enable plasmoids
      2. Set Shown/Hidden for plasmoid
      3. Set shortcut for plasmoid
      4. Previously hidden categories are shown
      5. Show all icons and revert
      6. Set Auto/Shown/Hidden for SNI icons
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, mart
      
      Reviewed By: #plasma_workspaces, #plasma, ngraham, mart
      
      Subscribers: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26586
      e2bfeb16
    • David Edmundson's avatar
      [sddm-theme] Don't have a broken reveal password button · 505ce992
      David Edmundson authored
      Summary:
      sddm-greeter will have a button for the reveal password button, but due
      to sddm-greeter not loading a relevant QPT has no code to force it to
      load the breeze icon set.
      
      Without the breeze icon set, the clear button does not show.
      
      There are ways to solve this, but none are trivial or reliable.
      
      I threatened to do a revert in 5.12 (https://phabricator.kde.org/D9040)
      but the bug has still not been fixed since.
      
      BUG: 396039
      CCBUG: 387418
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26675
      505ce992
    • David Edmundson's avatar
      [kcms/feedback] Fix default button not showing · e1324b0f
      David Edmundson authored
      Reviewers: ngraham
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26679
      e1324b0f
    • David Edmundson's avatar
      [kcms/feedback] Implement setRepresentsDefaults · 1f75ac80
      David Edmundson authored
      Test Plan:
      Moved slider
      Defaults button enabled/disabled appropriately
      
      Reviewers: #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: meven, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26680
      1f75ac80
    • David Edmundson's avatar
      [kcms/feedback] Fix slider value · e5ef7ea3
      David Edmundson authored
      Summary:
      If the kcm's property changes externally we don't update the slider
      after the initial load, which is before KConfigModule::load which actually sets
      the property.
      
      Whilst there is an alternative fix calling load() a second time, we need
      this anyway for default and reset buttons to work correctly.
      
      I also think the original code was broken, I don't see why we would map
      the value back to modeOptions[idx], we want the slider value to be the
      index of the array, not the enum value. They just happen to be the same.
      
      Test Plan: Opened KCM changed it, opened KCM repeat
      
      Reviewers: #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26678
      e5ef7ea3
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 4cb2eae9
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      4cb2eae9
  9. 14 Jan, 2020 4 commits
    • Nate Graham's avatar
      [wallpapers/image] Add default XDG wallpaper locations for slideshow · 8be6fb74
      Nate Graham authored
      Summary:
      BUG: 415461
      FIXED-IN: 5.18.0
      Depends on D26510
      
      Right now when you first change the wallpaper plugin to slideshow, no locations are
      pre-configured, so you have to add one yourself. This patch adds a
      `preferred:wallpaperlocations` token as the default that gets replaced in the user's
      config file at runtime with the XDG wallpaper locations.
      
      Test Plan:
      Log in as new user > right-click desktop > configure > change to slideshow wallpaper
      See that`/usr/share/wallpapers` is already in the list of wallpaper locations; how nice
      
      Reviewers: #plasma, #vdg, ndavis, davidedmundson
      
      Reviewed By: #plasma, #vdg, ndavis, davidedmundson
      
      Subscribers: davidre, broulik, davidedmundson, ndavis, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26483
      8be6fb74
    • Nate Graham's avatar
      [KCMs/Feedback] Adjust UI to be more user-friendly · 61a89ec9
      Nate Graham authored
      Summary:
      Adjust to the string changes in D26551 and improve the presentation
      overall to make it more likely that people will feel comfortable
      using it and submitting information.
      
      Depends on D26551
      
      Test Plan: How it looks now: {F7875839}
      
      Reviewers: #vdg, #plasma, apol
      
      Reviewed By: apol
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26552
      61a89ec9
    • Dan Leinir Turthra Jensen's avatar
      Switch to KNSQuick for getting new wallpapers · 47a1091b
      Dan Leinir Turthra Jensen authored
      Summary:
      This switches the image plugin to using KNewStuffQuick instead of
      launching the widget dialog through that ol' widget dialog hack.
      It further uses the big preview mode by default, which just seems
      to make a lot of sense for wallpapers.
      
      Test Plan:
      Without: Uses the old dialog
      With: Uses the new dialog, as seen below
      {F7882885}
      
      Reviewers: mart, #plasma, ngraham
      
      Reviewed By: mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26665
      47a1091b
    • Kai Uwe Broulik's avatar
      [Notifications] Raise application window if no default action is provided · 48d3613a
      Kai Uwe Broulik authored
      BUG: 416107
      FIXED-IN: 5.18.0
      
      Differential Revision: https://phabricator.kde.org/D26622
      48d3613a
  10. 13 Jan, 2020 2 commits
  11. 12 Jan, 2020 3 commits
  12. 10 Jan, 2020 4 commits
    • Nate Graham's avatar
      [wallpapers/image] Disambiguate identical folder names in paths list · c3242c1d
      Nate Graham authored
      Summary:
      When multiple paths that end in the same folder name are added (for example with D26483),
      currently the list shows multiple identical entries distinguished only by their different
      tooltips. This patch improves the situation by putting the path to the folder in a
      subtitle.
      
      Test Plan:
      Before: {F7868784}
      
      After: {F7868785}
      
      Reviewers: #vdg, #plasma, mart
      
      Reviewed By: #vdg, #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26510
      c3242c1d
    • Nate Graham's avatar
      [wallpapers/image] Put spinbox labels inside the spinboxes · 276eac85
      Nate Graham authored
      Summary: They look a little nicer this way, and can be localized more easily.
      
      Test Plan:
      Before: {F7871094, size=full}
      After:{F7871093, size=full}
      
      Reviewers: #vdg, #plasma, mart
      
      Reviewed By: #vdg, #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26529
      276eac85
    • Nate Graham's avatar
      [wallpapers/image] Add placeholder labels when wallpaper lists are empty · b79f9967
      Nate Graham authored
      Summary:
      Right now, when there are no configured wallpaper slideshow paths or wallpapers in the
      slideshow, the list and grid (respectively) are just empty. This patch adds some
      placeholder labels to let the user know that it's not broken, just like we do in the
      Thunderbolt KCM.
      
      See one `FIXME:` in the code that I could use a hand with.
      
      Test Plan: {F7870947}
      
      Reviewers: #vdg, #plasma, mart
      
      Reviewed By: #vdg, #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26528
      b79f9967
    • Nate Graham's avatar
      [applets/digital-clock] Fix truncated Long Date display in a vertical panel · 02c89d74
      Nate Graham authored
      Summary:
      BUG: 381551
      FIXED-IN: 5.18.0
      
      Test Plan:
      Before: {F7851382, size=full}
      
      After: {F7851383, size=full}
      
      Texted extensively because this code is so brittle. No regressions with long date in a
      thick or normal-sized horizontal panel or short date in a thick or normal-sized
      horizontal or vertical panel.
      
      The one issue I could find is that sometimes switching between short and long date
      formats in a double-thickness vertical panel causes the long date  to be truncated again
      until plasmashell is restarted. I was unable to determine why. Assistance would be
      appreciated if this is a blocker.
      
      Reviewers: #plasma, #vdg, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: ndavis, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26312
      02c89d74
  13. 09 Jan, 2020 2 commits
    • David Edmundson's avatar
      [startkde] Drop hack to manually set XDG_DATA_DIRS to the install root · 3c1a34a2
      David Edmundson authored
      Summary:
      For normal distros it doesn't make sense, KDE_INSTALL_FULL_DATAROOTDIR
      will be /usr/.
      
      For devs using a prefix startplasma-dev.sh already does this for us only
      for the dev setup.
      
      For any other user, it should be their responsibility to adjust it.
      
      It's currently broken anyway, if a user simply installs flatpak that sets this env
      earlier in the boot, so this will do nothing. It implies no-oe relies on thisl
      
      It's a relic from 2007 (bd38d59e11548f160efd0918ca5461536ac72349) that doesn't
      make sense now.
      
      BUG: 315452
      
      Test Plan: Compiles
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26537
      3c1a34a2
    • Konrad Materka's avatar
      [SystemTray] Set maximum size to block tiling · 4a65dcef
      Konrad Materka authored
      Summary:
      System tray dialog/popup can be tiled. This should not be allowed, in this case expanded representaiton should have fixed size. When tiled, it is no longer possible to restore original size.
      This also applies to other plasmoids.
      
      BUG: 386551
      FIXED-IN: 5.18.0
      
      Test Plan:
      1. Open any applet from system tray (for example Clipboard or hidden items)
      2. Use shortcut to tile window (by default Meta + Left/Righ/...)
      3. Applet will change size and tile at the borded of the screen
      4. Expected:
      a) before fix: allowed and not possible to restore size
      b) after fix: not allowed or restores size on next open
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26545
      4a65dcef
  14. 08 Jan, 2020 1 commit
    • Konrad Materka's avatar
      [XembedSNIProxy] Hide container window when something shows it · 69786a1f
      Konrad Materka authored
      Summary:
      For each tray icon XEmbedSNIProxy is creating container window 32x32 in size. It is black with opaque set to 0 (fully transparent when compositor is enabled). All of these container windows are stacked below all windows, so normally you can't see them. On creation all container windows are created in top-left corner. When user clicks on the tray icon, container window is moved to the click location (to handle events correctly).
      On KWin restart all windows are shuffled, usually KWin is able to restore ordering correctly, but for some reason not it this case. As a result black/transparent container windows are stacked above all other windows and panels.
      To solve that, when container window is visible, XembedSNIProxy needs hide it again by stacking the container window below again.
      
      BUG: 357443
      FIXED-IN: 5.18.0
      
      Test Plan:
      1. Run any application with XEmbed system tray icon, do not click on the icon
      2. Restart KWin
      3. [Optional] Disable compositor - with disable container window is black and easier to spot
      4. Expected:
      a) before fix: black/transparent rectangle in the top-left corner, reacts to mouse click
      b) after fix: no rectangle, mouse clicks work as expected.
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson
      
      Reviewed By: #plasma_workspaces, #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26395
      69786a1f