1. 26 Jan, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Remove scrollbar paddings · 82d7fd7a
      Konrad Materka authored
      Summary: Removes additional paddings. Not needed when scrollbar is no longer overlaying content. See: D26530
      
      Test Plan:
      1. Open configuration window
      2. No paddings
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, nicolasfella
      
      Reviewed By: nicolasfella
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26924
      82d7fd7a
  2. 15 Jan, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Rework system tray settings · e2bfeb16
      Konrad Materka authored
      Summary:
      Combines settings of SNI icons and plasmoids in one list. Ability to disable whole section is removed.
      
      Initial idea was proposed by Nicolas Fella (D22176).
      
      BUG: 360307
      FIXED-IN: 5.18.0
      
      {F7880936}
      
      Test Plan:
      1. Disable/enable plasmoids
      2. Set Shown/Hidden for plasmoid
      3. Set shortcut for plasmoid
      4. Previously hidden categories are shown
      5. Show all icons and revert
      6. Set Auto/Shown/Hidden for SNI icons
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, mart
      
      Reviewed By: #plasma_workspaces, #plasma, ngraham, mart
      
      Subscribers: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26586
      e2bfeb16
  3. 16 Dec, 2019 1 commit
    • Konrad Materka's avatar
      [System Tray] Unified data model for System Tray items · 6d2fa8e6
      Konrad Materka authored
      Summary:
      Currently there are two different sources of SystemTray items:
      * Plasmoids
      * Status Notifier
      
      Thi change adds new model that holds both Plasmoids and SNIs.
      
      Test Plan: Add/disable applets. Start/stop SNI app.
      
      Reviewers: #plasma, broulik, ngraham, nicolasfella
      
      Reviewed By: nicolasfella
      
      Subscribers: plasma-devel, nicolasfella, anthonyfieroni
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25580
      6d2fa8e6
  4. 14 Oct, 2019 1 commit
  5. 07 Jul, 2019 1 commit
  6. 20 May, 2019 1 commit
    • ivan tkachenko's avatar
      Fix system tray UI/UX & refactor · a73aa330
      ivan tkachenko authored
      Summary:
      System tray widget had the following UX problem:
      Icons are laid out in a Flow QML layout, using minimal amount of
      space, thus not filling the height/width of the task bar. In other
      words: user can only click directly on an icon, not over or under it.
      
      Consider the following scenario:
      
      Given icon size X and task bar of height 1.5 * X located at the bottom;
      User moves pointer down to the limit and tries to click the icon.
      Expected outcome: applet is activated.
      Actual outcome: nothing happens, because icon (together with mouse
      area) floats slightly above the bottom.
      
      Which is inconvenient, especially when most other widgets tend to fill
      up the space.
      
      This patch fixes aforementioned problem by refactoring layouts using
      modern GridLayout, RowLayout et al., so that icons are arranged in
      rows and columns based on their number, and each one fills up its
      cell. I also made a handful of minor internal refactorings and fixes.
      Unfortunately, due to tight coupling, almost all files needed changes
      anyway.
      
      Special note on 'CompactApplet.location': it didn't seem to affect
      anything at all, so removed it.
      
      At the end of the day no visual changes should be noticeable. Layout
      works in both vertical and horizontal form-factor an all four sides of
      the desktop.
      
      Test Plan: Please, check whether 'LayoutMirroring' works properly.
      
      Reviewers: #vdg, #plasma, broulik, mart, hein, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19745
      a73aa330
  7. 15 May, 2019 1 commit
    • Nate Graham's avatar
      [System tray] Modernize "Entries" category · fc086efe
      Nate Graham authored
      Summary:
      - Port mostly to QQC2+Kirigami FormLayout style (Don't touch the TableView since there's no QQC2 version yet)
      - Use standard import names
      
      Test Plan: {F6821757}
      
      Reviewers: #vdg, #plasma, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: ndavis, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10586
      
      Differential Revision: https://phabricator.kde.org/D21189
      fc086efe
  8. 09 Mar, 2019 1 commit
  9. 08 Feb, 2019 1 commit
  10. 02 Nov, 2017 1 commit
  11. 30 Dec, 2016 1 commit
    • Lindsay Roberts's avatar
      Systray: Move all icon resolution to dataengine · e43b89e2
      Lindsay Roberts authored
      Summary:
      Changes triggered by investigation into a long-running high CPU usage bug with system tray animations. The systray itself had icon name to icon resolution code, which was being triggered (twice) for every icon, every time any icon in the systray was updated. This code was spinning up a KIconLoader on each of these instances, and throwing it directly away. Each one triggered a large quantity of memory allocations and disk scans.
      
      This patch moves the extra bit of "appName" logic from the native part of the system tray to the statusnotifieritem datasource, which already had a stored 'customIconLoader' to handle icon theme paths, and removes the special lookup from the sytemtray applet completely. It also prefers icons provided by the dataengine to doing another lookup (contentious?). This removes all the extra CPU usage outside of the QML scene graph and graphics drivers locally.
      
      This is very much a looking for feedback item - there are things about the icon loading paths I almost certainly haven't appreciated yet, and perhaps preferring loading by icon name in the applet has a another purpose.
      
      BUG: 356479
      
      Test Plan: Have tested locally with kgpg and steam, the two apps I have that trigger the old code path. In neither case, however, did the appName logic produce a different result to the code with just the icon search path in statusnotifieritem.
      
      Reviewers: #plasma, davidedmundson, mart
      
      Reviewed By: #plasma, davidedmundson, mart
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D2986
      e43b89e2
  12. 10 Oct, 2016 1 commit
    • Lindsay Roberts's avatar
      Systray: Move all icon resolution to dataengine · 749f60b8
      Lindsay Roberts authored
      Summary:
      Changes triggered by investigation into a long-running high CPU usage bug with system tray animations. The systray itself had icon name to icon resolution code, which was being triggered (twice) for every icon, every time any icon in the systray was updated. This code was spinning up a KIconLoader on each of these instances, and throwing it directly away. Each one triggered a large quantity of memory allocations and disk scans.
      
      This patch moves the extra bit of "appName" logic from the native part of the system tray to the statusnotifieritem datasource, which already had a stored 'customIconLoader' to handle icon theme paths, and removes the special lookup from the sytemtray applet completely. It also prefers icons provided by the dataengine to doing another lookup (contentious?). This removes all the extra CPU usage outside of the QML scene graph and graphics drivers locally.
      
      This is very much a looking for feedback item - there are things about the icon loading paths I almost certainly haven't appreciated yet, and perhaps preferring loading by icon name in the applet has a another purpose.
      
      BUG: 356479
      
      Test Plan: Have tested locally with kgpg and steam, the two apps I have that trigger the old code path. In neither case, however, did the appName logic produce a different result to the code with just the icon search path in statusnotifieritem.
      
      Reviewers: #plasma, davidedmundson, mart
      
      Reviewed By: #plasma, davidedmundson, mart
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D2986
      749f60b8
  13. 11 Jul, 2016 1 commit
  14. 06 Jul, 2016 1 commit
  15. 10 May, 2016 1 commit
  16. 09 Mar, 2016 1 commit
  17. 05 Jan, 2016 1 commit
  18. 01 Nov, 2015 1 commit
  19. 08 Sep, 2015 2 commits
  20. 14 Jul, 2015 1 commit
  21. 09 Jul, 2015 1 commit
  22. 20 Apr, 2015 1 commit
  23. 14 Oct, 2014 1 commit
  24. 19 Sep, 2014 2 commits
  25. 22 Jul, 2014 2 commits
  26. 19 Jul, 2014 1 commit
  27. 29 May, 2014 1 commit
  28. 09 May, 2014 1 commit
    • Marco Martin's avatar
      Configuration for Auto, Shown, Hidden · ec96ae74
      Marco Martin authored
      This is the last big piece that was missing from the systray,
      now possible to set an entry as always shown, always hidden, or auto (default)
      BUG:332505
      ec96ae74