1. 07 Mar, 2021 1 commit
  2. 05 Mar, 2021 2 commits
    • Nate Graham's avatar
      Port to singleton Units · 2f4b27fc
      Nate Graham authored
      The context property version is slower to access and won't be supported
      in Qt6. Let's port away from it and use the singleton version instead.
      
      Here was my full process for making this change:
      
      1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
      2. Verified no more occurrences with `grep -r " units."`
      3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+   " | grep "//"`
      4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
      5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done`
      2f4b27fc
    • Nate Graham's avatar
      Use more standard duration values · c22feb74
      Nate Graham authored
      This lets these durations be scaled or disabled according to the user's
      preferences.
      
      CCBUG: 433948
      c22feb74
  3. 21 Dec, 2020 1 commit
  4. 11 Nov, 2020 1 commit
  5. 10 Nov, 2020 1 commit
    • Konrad Materka's avatar
      Fix Connections warnings · 5abed2dd
      Konrad Materka authored
      Qt 5.15 introduced new syntax for defining Connections. Fix warnings like this one:
      QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
      5abed2dd
  6. 09 Nov, 2020 1 commit
  7. 05 Nov, 2020 1 commit
    • Marco Martin's avatar
      put selection of which items are visible in a popup menu · bfe0f301
      Marco Martin authored
      the comboboix of a very rarely used feature right
      in the header area is super noisy, looks misaligned and puts the feature
      in a too much prominent role.
      Put everything under a popup menu, mustually exclusive actions will be
      shown as radiobuttons
      bfe0f301
  8. 05 Oct, 2020 1 commit
  9. 23 Aug, 2020 1 commit
  10. 17 Aug, 2020 2 commits
    • Nate Graham's avatar
      [applets/devicenotifier] Remove UI to suppress popup for new device connection · ff544ed5
      Nate Graham authored
      This option is just too nerdy to show a UI for. We keep the logic for it
      in the code (it's just two lines) but it's now only available for people
      who know about this and manually add "popupOnNewDevice=false" to their
      plasma-org.kde.plasma.desktop-appletsrc file.
      
      This prevents the applet from being too cluttered with options with the
      new design.
      ff544ed5
    • Nate Graham's avatar
      [applets/devicenotifier] Move all settings into main UI itself and rename · b878a64c
      Nate Graham authored
      Right now the Device Notifier applet has two settings: what kind of
      devices to show, and whether or not to open on new device attachment.
      
      My sense is that nobody knows that these options exist because they're
      hidden away in a config window that you can only access by
      right-clicking on the item in the system tray.
      
      Furthermore, the setting for what kind of devices to show is more useful
      than we give it credit for; when set to "All devices", the applet functions
      as an always-visible way to access all of the machine's disks. This is
      quite handy.
      
      Accordingly, this commit removes the config window and moves all of the
      settings into the main UI of the applet using PlasmoidHeaders--one
      header and one footer, exactly like the plasma-pa applet.
      
      With this change, the "Show all devices" feature becomes discoverable:
      when you plug in a flash drive or whatever, the applet will pop open,
      showing you the combobox that chooses what it will display. In this moment,
      you can notice it, play with it, and configure it to show all devices if
      you'd like.
      
      Accordingly again, the name of the applet is renamed to "Disks &
      Devices" since "Device Notifier" is not an accurate name. It was only
      ever accurate when using the applet's default settings, and now that
      non-default settings are made more discoverable, it feels appropriate
      to give it a more generally appropriate name.
      b878a64c
  11. 03 Aug, 2020 1 commit
  12. 26 Jul, 2020 1 commit
  13. 23 Jul, 2020 1 commit
    • Nate Graham's avatar
      Begin porting to PlasmaComponents3 · f55b00fe
      Nate Graham authored
      This begins the process of porting plasma-workspace to PlasmaComponents3. At
      this point, only the relatively easy work is done. Every file not ported
      now has been given the reason for still using PC2 in a comment on the import
      line so you can see at a glance what the blocker is by running
      `grep -r "org.kde.plasma.components 2.0"` in the repo.
      
      Everything is tested and there are no breakages or functional regressions. In
      the process, a few unused imports are removed.
      
      Here are the remaining PC3 omissions blocking what's left from getting easily
      ported:
      - No Highlight
      - No ListItem
      - No PageStack
      - No ContextMenu
      - No QueryDialog
      - No ModelContextMenu
      - TabBar has no left and right tab states
      - ToolButton has no built-in method to show a menu when clicked
      f55b00fe
  14. 14 Jul, 2020 1 commit
    • Nate Graham's avatar
      [applets/devicenotifier] Port to ExpandableListItem · b16eee88
      Nate Graham authored
      Summary:
      Port the Device Notifier to use an ExpandibleListItem.
      
      Tested with:
      - Removable flash drive
      - Removable LUKS-encrypted hard disk drive
      - Android phone
      - iOS phone
      - Internal disks
      
      No regressions or departures from the current behavior were found.
      
      The only major UI change is the loss of the progress bar, which is difficult
      to display properly with an ExpandableListItem. It is replaced with a textual
      display of free space and total space in the subtitle, which is more consistent with the
      appearance of other ExpandableListItem-using applets, and IMO is more useful anyway.
      b16eee88
  15. 05 Apr, 2020 1 commit
    • Nate Graham's avatar
      Stop multiplying duration values · 29587025
      Nate Graham authored
      Summary:
      After D28144, some animations are now too long because they were inappropriately
      multiplying a duration value. That's no longer necessary, so let's remove the
      multiplication.
      
      Depends on D28144
      
      Test Plan: Various things that were a bit too slow before feel just right now
      
      Reviewers: #vdg, #plasma, cblack
      
      Reviewed By: #vdg, #plasma, cblack
      
      Subscribers: cblack, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28238
      29587025
  16. 08 Feb, 2020 2 commits
  17. 09 Mar, 2019 1 commit
  18. 17 Jan, 2019 1 commit
    • Thomas Surrel's avatar
      [Device Notifier] Add a button to unmount all devices · 81db7443
      Thomas Surrel authored
      Summary:
      When at least two removable devices are mounted, a button shows
      up that will allow to unmount all mounted removable devices.
      This is convenient for removable drives with several partitions,
      each of which have to be unmounted to be able to safely plug the
      device out.
      
      {F6330009}
      
      FEATURE: 395644
      
      Test Plan:
      Plug and mount two devices.
      Click on the new 'unmount all' button.
      
      Reviewers: #plasma, #vdg, ngraham, broulik
      
      Reviewed By: #plasma, #vdg, ngraham, broulik
      
      Subscribers: abetts, broulik, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16212
      81db7443
  19. 08 Jan, 2019 2 commits
    • Thomas Surrel's avatar
      [Device Notifier] Disable the possibility to unmount the root partition · d1a5507b
      Thomas Surrel authored
      Test Plan: {F6461150}
      
      Reviewers: #plasma, #vdg, davidedmundson, ngraham
      
      Reviewed By: #plasma, #vdg, davidedmundson, ngraham
      
      Subscribers: abetts, ngraham, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17402
      d1a5507b
    • Thomas Surrel's avatar
      [Device Notifier] Keep the device label & icon after unmounting · cb323798
      Thomas Surrel authored
      Summary:
      When unmounting a device, the device notifier keeps the information
      of the device and its icon for a few seconds before it disappears.
      But the binding on the label and the icon was making them go blank
      before, leaving an emblem without an icon and a 'This device can
      now be safely removed' notice without the name of the device
      (although it did not always happen, this I am not sure why).
      
      The problem appeared with commit 61b2b173
      
      Test Plan:
      Unmount a removable device with the device notifier: for a few
      seconds, the device name and icon should still be displayed
      
      An example of the problem:
      {F6442095}
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, filipf, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17127
      cb323798
  20. 24 Sep, 2018 1 commit
    • Stefan Brüns's avatar
      [Device Notifier] Avoid accessing attributes of stale UDIs · 61b2b173
      Stefan Brüns authored
      Summary:
      When a Solid device is removed (e.g. a CD is ejected) the notifier tries
      to read the attributes although the Source for the UDI has just vanished.
      
      Fixes several QML error messages, i.e. "TypeError: Cannot read property
      '...' of undefined" and "Unable to assign [undefined] to QString".
      
      Apparently these errors also have the effect of items showing outdated
      state, i.e. optical media still being shown after ejecting it.
      
      CCBUG: 394348
      
      Test Plan:
      1. insert optical medium
      2. eject
      Without the changes, the item was stuck
      Now, the item is removed as soon as the medium is ejected
      
      Also, no more errors are logged for the devicenotifier
      
      Reviewers: #frameworks, broulik
      
      Reviewed By: broulik
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15687
      61b2b173
  21. 01 Mar, 2018 1 commit
    • Marco Martin's avatar
      auto hide popup when it opened itself · 2da603f9
      Marco Martin authored
      Summary:
      when the device notifier pops up automatically, leave it open
      if there is no user activity, if there is any, close after around
      3 seconds. Suspend the countdown if the notifier window either has
      focus or the mouse cursor is over it, leaving the user the time to
      go interact. if it doesn't have focus and the mouse leaves, resume
      the countdown
      replaces D10591
      
      Test Plan:
      tested for a while in a real world usage, it behaves in a fairly natural
      way
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10921
      2da603f9
  22. 15 Jun, 2016 1 commit
  23. 13 Jun, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Device Notifier] Be more declarative · 6c0b1e54
      Kai Uwe Broulik authored
      Instead of having a bunch of handlers in various places messing with various settings,
      try to use declarative bindings where possible.
      
      * Remove separate passive timer, instead re-use the pendingDelegateRemoval property
        which has its own timer. This way, when a device is unmounted, device notifier stays
        active until the notification has cleared, however, when the device is yanked out manually,
        it disappears right away
      * Don't break binding on Plasmoid.active to ensure its state is always proper depending on
        whether a device or not is present (the linked bug)
      * Create tooltip declaratively rather than imperatively
      
      BUG: 362992
      FIXED-IN: 5.7.0
      
      Differential Revision: https://phabricator.kde.org/D1793
      6c0b1e54
  24. 09 May, 2016 1 commit
  25. 08 Mar, 2016 1 commit
  26. 24 Jan, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Device Notifier] Provide inline feedback · 1ed7209f
      Kai Uwe Broulik authored
      Instead of showing a detached status bar with the device name, show the message
      below the device in the list.
      
      When removing a device, device notifier will pop up and a "You can now safely remove
      this device" message will show up with a highlight gradually fading away until 5 seconds
      later the device is removed from the list.
      
      REVIEW: 126688
      1ed7209f
  27. 09 Jan, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Device Notifier] Rewrite delegates to use Layouts · 9cc524e5
      Kai Uwe Broulik authored
      The code is from a time before we had smart layouts and thus is pretty complicated
      with lots of anchoring. This cleans up the code massively.
      
      The layout is a bit tighter now, the eject/mount button is now a proper ToolButton.
      The "n actions for this device" text now disappears when the actions are expanded;
      (dis)appearance of the disk usage bar is now nicely animated, while the lagging behind
      hover effet has been removed.
      
      REVIEW: 126673
      9cc524e5
  28. 13 Sep, 2015 1 commit
  29. 03 Apr, 2015 2 commits
  30. 25 Nov, 2014 1 commit
  31. 19 Nov, 2014 1 commit
  32. 07 Nov, 2014 1 commit
  33. 25 Aug, 2014 1 commit
  34. 11 Aug, 2014 1 commit
    • Kai Uwe Broulik's avatar
      Streamline device notifier · 7c24d4ef
      Kai Uwe Broulik authored
      - Remove redundand "Available devices" label and only show "No devices available" if there aren't any
      - Use the same Heading as the notifications for the sections
      
      REVIEW: 119720
      7c24d4ef
  35. 28 May, 2014 1 commit