GitLab

Summary:
BUG: 418526

The profile group with the value `Default=1` is not always the default profile, for example in the profiles.ini file from the bug report:
```
[Profile1]
Name=default
IsRelative=1
Path=dun5pnnn.default
Default=1

[Profile0]
Name=default-default
IsRelative=1
Path=xewbk2mp.default-default

[Install11457493C5A56847]
Default=xewbk2mp.default-default
Locked=1```

In the text you can see that the profile with `dun5pnnn.default` has the value `Default=1`,
but it is not  the default profile.
The correct default profile is in the `[Install11457493C5A56847]` group with the key `Default`.

Test Plan:
If you create a new profile it will be extracted as the default profile
(but the old value might still be cached see D28619).

Reviewers: #plasma, ngraham, bruns, broulik, meven

Reviewed By: meven

Subscribers: meven, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29326

System tray models are created lazily, so it is possible that the configuration will load earlier and not notify the model of the stored values. Add explicit configuration load, so that it always loads correctly during the initialization.

This is a fix for regression introduced in the !14

Summary:
Icon and title of entries in System Tray settings should not change when status changes.
Use only plugin's meta-data for consistent title and icon.

BUG: 421561

FIXED-IN: 5.19.0

Test Plan:
1. Check Weather or Media Player applets
2. Enbable/disable/change status
3. Icon and title should remain the same

Summary:
SystemTray model was created in constructor, delay initialization and
create it lazily.
The `SystemTray::appletAdded` signal is connected to both SystemTray's
model and `Container`. `Container` must be connected first, because it sets
some properties of newly added applet: `visible` to false and `parent`
to the root item (container). If `Container` is connected second, then
newly created applet ios added to the model and rendered, but immediately
after that `Container` changes visibility to false.

BUG: 420993

Test Plan:
1. Do not play anything (no Medial Player icon at all)
2. Run Gwenview
3. Check if Medial Player icon in hidden view is rendered correct.
Before change:
Sometimes icon is not rendered, looks like invisible or fully transparent.
After change:
Icon rendered correctly.

Add icon for Playing/Paused states, this partially reverts !16

Summary:
Icon of Media Player applet is missing in the System Tray settings when
the media playing has a cover. Such icon is present when nothing is playing.
Fix by not using album art in any case - icon is not longer used in
tooltip, can be static.

BUG: 420197

FIXED-IN: 5.19.0

Test plan:
1. play audio/video with a player compatible with Media Player applet
2. open system tray settings during playback
3. Icon of Media Player applet is always present in system tray
settings, regardless of state.

This broke showing the inhibitions list. Will find a better way.

This reverts commit ce6a0ec0.

You can't anchor to items that aren't the parent or sibling.

It got removed when the heading element was added.
A negative margin is added below the heading since it has its own spacing.

Notification spec says, when replacing a notification:

> The server must atomically (ie with no flicker or other visual cues) replace the given notification with this one.

Notifications shifting about is a "visual cue".

Differential Revision: https://phabricator.kde.org/D29771

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Fixes regression caused by me meddling with data in 6e660cf9
Unfortunately KRunner has no notion of "this is application xyz" so Kicker has to make assumptions, which broke here.

Differential Revision: https://phabricator.kde.org/D29744

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Even when the vendor logo is turned off it can be briefly seen when the login screen changes from the fadeout state back into normal.

Comments in other code say that "OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)" so this patch replaces it with NumberAnimation.

There's also a minor fix included - placing the drop shadow sooner in the hierarchy because it should be drawn underneath an object, not in front of it.

Test Plan:
Reduce the fadeout time to something small and then:

`sddm-greeter --test-mode --theme /usr/share/sddm/themes/breeze`

Reviewers: ngraham, cblack, #plasma, mart

Reviewed By: ngraham, #plasma, mart

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29351

Summary:
Duplicate function calls to load the config in the runner/config have been removed.
The actions of the runner are also refactored, similar to https://phabricator.kde.org/D3688.
Also the user (owner of process) has been removed from the subtext, because the second line is not shown and adding the user info to the same line would be too long.

Test Plan: Should compile and kill processes as before.

Reviewers: davidedmundson, ngraham, broulik, meven, apol

Reviewed By: meven

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27513

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

See D29692

It only had a return value for "NoCharge" since the else case was only for not plugged in, resulting in it effectively returning undefined,
throwing during assignment "cannot assign [undefined] to string" and leaving whatever text happened to be shown last.

BUG: 420920

Differential Revision: https://phabricator.kde.org/D29633

WatchedNotificationsModel is a unstable API and does not provide any
API/ABI gurantee, look and feel developers or application developers
should not use this API for time being.

Summary: This fixes some wrong alignments

Test Plan:
After:
{F8305161}
{F8305164}
{F8305166}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ndavis, abetts, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29570

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Eugene Popov authored May 11, 2020 and Nate Graham committed May 11, 2020

[applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

Summary:
When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself.

BUG: 421344

Reviewers: ngraham, plasma-devel, broulik

Reviewed By: ngraham, broulik

Subscribers: broulik

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29651

Summary:
If status is set to NeedsAttention it tries to use Attention Icon. If Attention Icon is not set, empty/null QIcon is set. QML can't check if QIcon is null or not, as a result it tries to use empty icon and nothing is rendered.
Set null QVariant if AttentionIcon is not valid so that QML check will work correctly.

Test Plan:
* Set NeedsAttention as a status and with no Attention Icon
* Base Icon should render correctly

Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, mart

Reviewed By: #plasma_workspaces, #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29544

CCBUG: 420934

Ref T12778

Summary: Otherwise the build fails when things try to link to KF5::SysGuard etc.

Test Plan: Builds again

Reviewers: #plasma, meven

Reviewed By: meven

Subscribers: meven, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29628

Summary:
Allows to set Icon, AttentionIcon and OverlayIcon either by name or pixmap.
Makes it easier to test combinations of those.

Reviewers: kmaterka, apol

Reviewed By: kmaterka, apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29619

Summary:
Those plasmoids are intended to replace the old systemmonitor plasmoids
They are based upon the new ksysguard daemon: see D28333 and D28141

It has pluggable presets and sensor "faces" which are available from the KDE store

Every preset is available as a separate plasmoid.
By default are installed ones to replace
roughly one by one the existing systemmonitor plasmoids so systems that use it
will get the new ones in the updates

Depends on D28922

Test Plan: {F8209642}

Reviewers: #plasma

Subscribers: alexde, ngraham, davidedmundson, mmustac, ahiemstra, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28487

Summary:
Warnings such as:
```
CMake Warning at /usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:37 (me
ssage):
  The KF5:: namespace for KSysGuard targets is deprecated.  Please use
   KSysGuard as namespace.
 Call Stack (most recent call first):
   /usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package)
   CMakeLists.txt:55 (find_package)
```

Test Plan: cmake does not output those warnings

Reviewers: #plasma, ahiemstra, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29623

Summary:
as we can't kill completely kcmshell just yet, hack intothe services runner to
replace on the fly the exec line of the service to systemsettings

BUG: 402790
FIXED-IN: 5.19.0

Test Plan:
search and launch directly for a module, systemsettings is launched wit hthe
proper module loaded

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: broulik, ngraham, davidre, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29157

Fix in the f2e34dbb got partially reverted by introduction
of AbstractNotificationsModel in 2357e6f2.

Summary: This allows one to subscribe to notifications from notification server.

Test Plan:
tested using very simple QML

```
import QtQuick 2.0
import org.kde.notificationmanager 1.1 as Notifications

...
Notifications.NotificationWatchedModel {
    id: model
}

```

Reviewers: #plasma, broulik, davidedmundson

Reviewed By: #plasma, broulik

Subscribers: nicolasfella, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28509