1. 24 Mar, 2020 6 commits
  2. 23 Mar, 2020 3 commits
    • Nate Graham's avatar
      Make Pin buttons consistently sized in System Tray and Clock pop-ups · 3a44e360
      Nate Graham authored
      Summary:
      The Pin buttons in the System Tray and Clock pop-ups are very small. This has
      always felt slightly odd to me, and the recent change to add a defined header
      area for the System Tray pop-up makes it even odder in my opinion, as the icon
      is now much smaller than the area it visibly inhabits. This patch makes both icons
      in both applets use the standard size with no local overrides. The clock pop-up's
      pin button is ported to PC3 in the process.
      
      Depends on D28228
      
      Test Plan:
      Before: {F8194101}
      After: {F8194100}
      
      Reviewers: #vdg, #plasma, ognarb, mart
      
      Reviewed By: #vdg, #plasma, ognarb, mart
      
      Subscribers: mart, ndavis, broulik, ognarb, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10470
      
      Differential Revision: https://phabricator.kde.org/D28211
      3a44e360
    • Nate Graham's avatar
      [applets/digital-clock] Switch timezones by clicking on them in the popup · e5caa59a
      Nate Graham authored
      Summary:
      This patch allows you to switch the timezone by clicking on your desired one in the
      applet's expanded representation. This is much simpler than the mouse-wheel-based UI and
      does not need a config setting to turn it on or off.
      
      Test Plan: {F8183863}
      
      Reviewers: #vdg, #plasma, jriddell, cblack
      
      Reviewed By: #vdg, #plasma, cblack
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T9222
      
      Differential Revision: https://phabricator.kde.org/D28133
      e5caa59a
    • Yuri Chornoivan's avatar
      Get updated Messages.sh back · e1a08814
      Yuri Chornoivan authored
      e1a08814
  3. 22 Mar, 2020 1 commit
    • Alexander Lohnau's avatar
      Remove unnecessary code and function calls · 86fd0f2f
      Alexander Lohnau authored
      Summary:
      The ShellConfig class has been deleted. This config class was in KDE4 for the runOptions widget used and the class/the settings are not used anymore.
      Additionally the context type check has been removed, because this is already solved using the ignore types.
      Futhermore the match icon and the list of actions can be reused.
      
      Test Plan: Should compile and execute shell commands as before.
      
      Reviewers: davidedmundson, ngraham, broulik, meven, #plasma
      
      Reviewed By: meven
      
      Subscribers: meven, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27495
      86fd0f2f
  4. 21 Mar, 2020 4 commits
  5. 20 Mar, 2020 1 commit
    • Harald Sitter's avatar
      make servicerunner only build once · d03f98e7
      Harald Sitter authored
      Summary:
      build the runner itself in a static lib we can use for testing and then
      link that into a module lib together with the factory entry point to
      compose the final lib for installation
      
      means servicesrunner.cpp is now only built once, whereas before it was
      built twice through 100% duplicative targets
      
      Test Plan: test still passes, installing and restarting krunner still yields working service searches
      
      Reviewers: broulik, davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28137
      d03f98e7
  6. 19 Mar, 2020 6 commits
  7. 18 Mar, 2020 4 commits
  8. 17 Mar, 2020 4 commits
    • Christian Muehlhaeuser's avatar
      Use methods in KF5-activities to switch to previous/next activity · 805e70bb
      Christian Muehlhaeuser authored
      Summary:
      Since the release of KDE Frameworks 5.68.0 we can now
      use the methods exposed in KActivities::Controller to trigger a
      switch to the previous or next activity from ShellCorona.
      
      Reviewers: ngraham, ivan, apol
      
      Reviewed By: ngraham, apol
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28083
      805e70bb
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 780f2edd
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      780f2edd
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · dbdb78b4
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      dbdb78b4
    • Nate Graham's avatar
      [applets/systemtray] Fix expanded representation's internal margins · 695fec4a
      Nate Graham authored
      Summary:
      This is a pre-existing problem, but became much more visible with D27189 (thus exposing
      one of the reasons why I like visually separating dissimilar elements so much).
      Essentially the dialog's bottom and right margins were not being properly mirrored on
      the top and left, leading to the applet's content view looking off-center. Various apps
      were locally adding their own extra top margins to compensate for this, which can be
      removed once this patch lands.
      
      This patch fixes that by explicitly using the default dialog margins for those edges.
      
      I will submit follow-up patches to fix applets that were adding extra padding that is
      now unnecessary.
      
      Test Plan:
      It was especially noticeable with D27160.
      
      Before: {F8180273}
      
      After: {F8180272}
      
      Reviewers: #vdg, #plasma, cblack
      
      Reviewed By: #vdg, #plasma, cblack
      
      Subscribers: cblack, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28089
      695fec4a
  9. 14 Mar, 2020 2 commits
    • Niccolò Venerandi's avatar
      Created a top area based on widgets/toparea.svg · f4195688
      Niccolò Venerandi authored
      Summary:
      This add a top area based on the current theme. If the file is not in the current theme, said area is not shown.
      
      Problem: the header is moved to the right by the Svg element, and I'm not sure how to align it correctly anymore.
      
      Depends on D27695
      
      Test Plan: {F8088058}
      
      Reviewers: #vdg, #plasma, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: mart, ngraham, ndavis, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10470
      
      Differential Revision: https://phabricator.kde.org/D27189
      f4195688
    • Aleix Pol Gonzalez's avatar
      appstreamrunner: Port to KApplicationTrader · 3f0ca0da
      Aleix Pol Gonzalez authored
      Summary:
      Port away from the query language to lambda using the new KApplicationTrader API.
      
      Depends on D27953.
      
      Test Plan: Tested by hand with several applications, still works as expected.
      
      Reviewers: #plasma, dfaure
      
      Reviewed By: dfaure
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27954
      3f0ca0da
  10. 13 Mar, 2020 3 commits
    • Matej Mrenica's avatar
      [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line · db2518b0
      Matej Mrenica authored
      Summary:
      Currently the applet uses the main line in tooltip to display all info. Instead it should show always the same first line like other widgets and use the second line to show info.
      
      BUG: 411973
      FIXED-IN: 5.19.0
      
      Test Plan:
      The point of this patch is to make the tooltip more like the style used in the Audio Volume applet:
      {F7862465}
      
      Other "after" images:
      
      {F7862461}
      
      {F7862463}
      
      {F7862464}
      
      {F7871067}
      
      Reviewers: #vdg, #plasma, broulik, ndavis, mthw
      
      Reviewed By: #vdg, #plasma, broulik, ndavis, mthw
      
      Subscribers: GB_2, ndavis, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24070
      db2518b0
    • Allan Sandfeld Jensen's avatar
      Fix systemtray configuration · ce69fc4e
      Allan Sandfeld Jensen authored
      Summary: The property currentValue is conflicting making the qml file not run.
      
      Reviewers: #plasma_workspaces, davidedmundson
      
      Reviewed By: #plasma_workspaces, davidedmundson
      
      Subscribers: kmaterka, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26923
      ce69fc4e
    • Nate Graham's avatar
      [applet/digital-clock] Show time zones in expanded representation too · 2130c848
      Nate Graham authored
      Summary:
      Right now time zones are only shown in the tooltip, which is annoying since the tooltip
      times out aftew a few seconds, so it often closes before I can find the timezone I'm
      looking for.
      
      This patch adds a view for the current tomezones in the expanded representation, and
      implements a mockup in https://bugs.kde.org/show_bug.cgi?id=395655 showing a proposal
      for how to present this information.
      
      The Expanded Representation is also ported to Layouts in order to make this task easier.
      
      FEATURE: 395655
      FIXED-IN: 5.19.0
      
      Test Plan:
      Just calendar: {F8157434}
      
      Calendar + events: {F8157435}
      
      Calendar + time zones: {F8157436}
      
      Calendar + events + time zones: {F8157437}
      
      Reviewers: #vdg, #plasma, cblack
      
      Reviewed By: #vdg, cblack
      
      Subscribers: cblack, apol, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T9222
      
      Differential Revision: https://phabricator.kde.org/D27903
      2130c848
  11. 10 Mar, 2020 3 commits
  12. 09 Mar, 2020 3 commits