1. 24 Mar, 2020 1 commit
    • Konrad Materka's avatar
      [applets/systemtray] Simplify icon size logic · a9d941b3
      Konrad Materka authored
      Summary: This change simplifies icon size logic - now it is controled only in one place: AbstractItem. This gives additional benefits, like icons perfectly centered.
      
      Test Plan: Highlights should always be centered
      
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, apol
      
      Reviewed By: #plasma_workspaces, #plasma, ngraham, broulik
      
      Subscribers: mart, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28109
      a9d941b3
  2. 21 Mar, 2020 1 commit
  3. 07 Mar, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Use unified data model everywhere · 39975673
      Konrad Materka authored
      Summary:
      Use the unified data model everywhere, not just in configuration. This simplifies UI code, separetes presentation from data.
      This requires the use of ListView and GridView.
      This change enables the implementation of more advanced sorting algorithms for systemtray items.
      
      Test Plan: Affects almost all areas of system tray.
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
      
      Reviewed By: #plasma_workspaces, #plasma, davidedmundson, ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26992
      39975673
  4. 06 Feb, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Bunch of fixes and improvements in QML · a79f80ed
      Konrad Materka authored
      Summary:
      Few unrelated fixes, bunched together:
      * move some code from main.qml to PlasmoidItem where it belongs
      * easier to understand item size calculation
      * where possible, replace parent.parent comparisons with a property in AbstractItem
      * get rid of marginHints
      * Qt 5.14 compatibility fix in configuration
      * formatting etc
      
      Test Plan: Everything should work as before, this is just refactoring.
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27085
      a79f80ed
  5. 15 Jan, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Rework system tray settings · e2bfeb16
      Konrad Materka authored
      Summary:
      Combines settings of SNI icons and plasmoids in one list. Ability to disable whole section is removed.
      
      Initial idea was proposed by Nicolas Fella (D22176).
      
      BUG: 360307
      FIXED-IN: 5.18.0
      
      {F7880936}
      
      Test Plan:
      1. Disable/enable plasmoids
      2. Set Shown/Hidden for plasmoid
      3. Set shortcut for plasmoid
      4. Previously hidden categories are shown
      5. Show all icons and revert
      6. Set Auto/Shown/Hidden for SNI icons
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, mart
      
      Reviewed By: #plasma_workspaces, #plasma, ngraham, mart
      
      Subscribers: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26586
      e2bfeb16
  6. 12 Jan, 2020 1 commit
  7. 19 Sep, 2019 1 commit
    • Radek Hušek's avatar
      Use consistent ordering for System Tray items · 0df34cc3
      Radek Hušek authored
      Summary:
      @mart dislikes idea of manually ordering the systray (D11233, D11292) but prefers auto
      ordering instead. To make my opinion I hacked up this and started testing on myself.
      Current version breaks if two items have the same category and text (I guess this
      should not happen but...).
      
      Note that category order is more or less randomly chosen (I do believe someone else
      has an opinion what the correct order is).
      
      This is mutually exclusive with D11292.
      
      Reviewers: #vdg, #plasma, mart, ngraham
      
      Reviewed By: #vdg, #plasma, mart, ngraham
      
      Subscribers: kmaterka, ognarb, ngraham, wsdfhjxc, mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D11352
      0df34cc3
  8. 15 Aug, 2019 1 commit
    • Konrad Materka's avatar
      [System Tray] Do not send ContextMenu signal twice · 67c1117f
      Konrad Materka authored
      Summary:
      System Tray sends two "ContextMenu" events which breaks focus.
      One is send on mouse pressed, second on mouse clicked. As a result
      right click on the system tray icon causes focus to lock on the icon.
      If later user clicks somewhere else event is send to the first icon.
      
      BUG: 376277
      BUG: 409768
      FIXED-IN: 5.17.0
      
      Test Plan:
      The best to test with Skype for Linux with SNI bridge.
      
      To reproduce:
      * Right click on the Skype icon, click on menu item (can be Show Skype)
      * Right click on any other icon in system tray (or even any other place on the panel)
      * Skype menu will appear
      
      After fix:
      * Right click on the Skype icon, click on menu item (can be Show Skype)
      * Right click on any other icon in system tray (or even any other place on the panel)
      * Correct menu should show
      
      Reviewers: #plasma, broulik, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: broulik, apol, plasma-devel, #plasma_workspaces
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D22804
      67c1117f
  9. 07 Jul, 2019 1 commit
  10. 20 May, 2019 1 commit
    • ivan tkachenko's avatar
      Fix system tray UI/UX & refactor · a73aa330
      ivan tkachenko authored
      Summary:
      System tray widget had the following UX problem:
      Icons are laid out in a Flow QML layout, using minimal amount of
      space, thus not filling the height/width of the task bar. In other
      words: user can only click directly on an icon, not over or under it.
      
      Consider the following scenario:
      
      Given icon size X and task bar of height 1.5 * X located at the bottom;
      User moves pointer down to the limit and tries to click the icon.
      Expected outcome: applet is activated.
      Actual outcome: nothing happens, because icon (together with mouse
      area) floats slightly above the bottom.
      
      Which is inconvenient, especially when most other widgets tend to fill
      up the space.
      
      This patch fixes aforementioned problem by refactoring layouts using
      modern GridLayout, RowLayout et al., so that icons are arranged in
      rows and columns based on their number, and each one fills up its
      cell. I also made a handful of minor internal refactorings and fixes.
      Unfortunately, due to tight coupling, almost all files needed changes
      anyway.
      
      Special note on 'CompactApplet.location': it didn't seem to affect
      anything at all, so removed it.
      
      At the end of the day no visual changes should be noticeable. Layout
      works in both vertical and horizontal form-factor an all four sides of
      the desktop.
      
      Test Plan: Please, check whether 'LayoutMirroring' works properly.
      
      Reviewers: #vdg, #plasma, broulik, mart, hein, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19745
      a73aa330
  11. 22 Mar, 2019 1 commit
  12. 09 Mar, 2019 1 commit
  13. 15 Mar, 2018 1 commit
  14. 08 Feb, 2017 2 commits
  15. 11 Jan, 2017 1 commit
  16. 04 Nov, 2016 2 commits
    • Marco Martin's avatar
      fix behavior of scrollable systray popups · 95a8a620
      Marco Martin authored
      Summary:
      it's very rare that the icon list in the hidden area
      of the systray is long enough to get a scrollbar, but
      when it does it had a couple of issues:
      sometimes it gets an horizontal scrollbar too and
      the wheel events gets eaten:
      always disable the horizontal scrollbar and
      ignore wheel events over the label.
      wheel events over the icon are still managed by
      the applet (so still possible to for instance
      adjusting the volume on pa applet)
      
      BUG:372050
      
      Test Plan:
      hidden all the cions to enable scrollbar: wheel over
      the text scrolls the view, over the icon adjusts the volume
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3263
      95a8a620
    • Marco Martin's avatar
      fix behavior of scrollable systray popups · ae658c33
      Marco Martin authored
      Summary:
      it's very rare that the icon list in the hidden area
      of the systray is long enough to get a scrollbar, but
      when it does it had a couple of issues:
      sometimes it gets an horizontal scrollbar too and
      the wheel events gets eaten:
      always disable the horizontal scrollbar and
      ignore wheel events over the label.
      wheel events over the icon are still managed by
      the applet (so still possible to for instance
      adjusting the volume on pa applet)
      
      BUG:372050
      
      Test Plan:
      hidden all the cions to enable scrollbar: wheel over
      the text scrolls the view, over the icon adjusts the volume
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3263
      ae658c33
  17. 23 Aug, 2016 1 commit
  18. 18 Jul, 2016 1 commit
  19. 30 Jun, 2016 1 commit
  20. 21 Jun, 2016 1 commit
  21. 14 Jun, 2016 1 commit
  22. 04 Apr, 2016 1 commit
  23. 30 Mar, 2016 2 commits
  24. 29 Mar, 2016 1 commit
  25. 23 Mar, 2016 1 commit
    • Marco Martin's avatar
      a small margin for icons · 8b677a98
      Marco Martin authored
      use the margin within the geometry of icons instead of layout spacing
      otherwise there will be an error during the decision of
      how many lines to use
      8b677a98