1. 25 May, 2020 2 commits
  2. 24 May, 2020 3 commits
  3. 23 May, 2020 2 commits
    • Alexander Lohnau's avatar
      BookmarksRunner: Change caching databases · 61b02b16
      Alexander Lohnau authored
      Summary:
      The copying/updating of the cache has been removed from the FetchSqlite class.
      This allows the browsers to have handle the caching differently.
      
      The firefox sqlite files are only copied if they changed. Before they were copied
      for each match session.
      
      The chrome favicon database is also only copied if needed
      and the check is also made in the prepare method and not just when
      the profile is initialized.
      
      Test Plan:
      For both firefox and chrome:
      Plugin shows icons for results.
      Add new bookmarks, close browser, the new bookmarks should show up with icons.
      
      Reviewers: #plasma, ngraham, meven, broulik
      
      Reviewed By: meven
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29726
      61b02b16
    • Méven Car's avatar
      KRunner location: remove redundant setText · be84a82a
      Méven Car authored
      be84a82a
  4. 22 May, 2020 2 commits
    • Nate Graham's avatar
      [OSD] Add a bit more padding on either side of the layout · b47fb260
      Nate Graham authored
      This makes the contents feel less cramped to me.
      b47fb260
    • Nate Graham's avatar
      [applets/batterymonitor] Improve UI for power management inhibition · 544f917e
      Nate Graham authored
      This patch improves the UI for inhibiting power management and seeing
      which apps are automatically doing it. Here are the changes, explained:
      
      1. Use less jargonistic terminology for the feature itself, and remove
         the explanatory tooltip which is no longer necessary
      2. Show the full list of apps which are inhibiting power management,
         because we have the space now that app icons are smaller
      3. Correctly show and hide the list of inhibitions based on count and
         Whether or not the user has independently suppressed PM
      4. Leave a bit more room for long reasons and alert translators to
         minimize string length as much as possible
      
      BUG: 401108
      FIXED-IN: 5.20.0
      544f917e
  5. 21 May, 2020 7 commits
  6. 20 May, 2020 6 commits
    • Nate Graham's avatar
      Merge branch 'Plasma/5.19' · 0616718a
      Nate Graham authored
      0616718a
    • Nate Graham's avatar
      Revert "[applets/batterymonitor] Collapse inhibitions list properly" · 58def605
      Nate Graham authored
      This broke showing the inhibitions list. Will find a better way.
      
      This reverts commit ce6a0ec0.
      58def605
    • Kai Uwe Broulik's avatar
      [OSD] Fix ProgressBar potentially growing the dialog · c067d498
      Kai Uwe Broulik authored
      Depending on font size and settings the ProgressBar's implicit size might be wider
      than our minimum size of 15 gridUnit. This causes the Popup to change size when switching
      from ProgressBar (e.g. changing volume) to Text (e.g. volume muted).
      
      By setting preferredWidth to 1 we ensure we never exceed the overall minimum size
      when the ProgressBar is shown.
      c067d498
    • Kai Uwe Broulik's avatar
      Merge branch 'Plasma/5.19' · 2f9e2dd6
      Kai Uwe Broulik authored
      2f9e2dd6
    • Kai Uwe Broulik's avatar
      [Battery Monitor] Fix ScrollView anchoring · f364b62c
      Kai Uwe Broulik authored
      You can't anchor to items that aren't the parent or sibling.
      f364b62c
    • Jan Blackquill's avatar
      [applets/appmenu] Hide old menu before showing new menu · caea7f76
      Jan Blackquill authored
      Summary:
      Hiding the old menu after the new menu is shown isn't possible on Wayland:
      ```
      qt.qpa.wayland: setGrabPopup called with a parent, QtWaylandClient::QWaylandXdgSurface(0x17dd550) which does not match the current topmost grabbing popup, QtWaylandClient::QWaylandXdgSurface(0x120d9f0) According to the xdg-shell protocol, this is not allowed. The wayland QPA plugin is currently handling it by setting the parent to the topmost grabbing popup. Note, however, that this may cause positioning errors and popups closing unxpectedly because xdg-shell mandate that child popups close before parents
      ```
      
      Test Plan:
      Before, Wayland: Trying to open a menu under Wayland while one is already open fails.
      After, Wayland: Trying to open a menu under Wayland while one is already open succeeds.
      Ensure no regressions on X11.
      
      Reviewers: #plasma, #kwin, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29464
      caea7f76
  7. 19 May, 2020 8 commits
    • Nate Graham's avatar
      [lookandfeel] Port OSD's slider to PlasmaComponents3 · b9aba6eb
      Nate Graham authored
      It has more correct vertical sizing, which now matters with the new
      OSD design.
      b9aba6eb
    • Kai Uwe Broulik's avatar
      Merge branch 'Plasma/5.19' · 4ed46dfe
      Kai Uwe Broulik authored
      4ed46dfe
    • Jan Blackquill's avatar
      [applets/appmenu] Improve menu feel · bf337f55
      Jan Blackquill authored
      Summary: The appmenu applet now accurately replicates the hover behaviour of a regular menubar.
      
      Test Plan:
      Before: you need to click to engage all menus.
      After: the appmenu applet copies the behaviour of a QMenuBar when it comes to clicks and hovers.
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29465
      bf337f55
    • Kai Uwe Broulik's avatar
      Use more compact OSD · af31ad46
      Kai Uwe Broulik authored
      Summary:
      A frequent complaint over the years is the size of the OSD. It was tried to alleviate that by having it start fading out slowly immediately but the way it was done wasn't ideal, didn't work on Wayland, and also causes flickering issues in recent Qt versions.
      This changes the OSD to a bar-like design similar to the one used in Plasma 4.
      
      BUG: 344393
      BUG: 372665
      FIXED-IN: 5.20.0
      
      Depends on D29263
      
      Test Plan:
      Various OSD messages
      {F6773939}
      It can grow, if necccessary, to accomodate translations, up to half the screen width.
      With Air theme
      {F6773940}
      Full desktop screenshot for some context
      {F6773941}
      
      Reviewers: #plasma, #vdg, broulik, niccolove, ndavis
      
      Reviewed By: #vdg, niccolove, ndavis
      
      Subscribers: ndavis, kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, Codezela, filipf, zzag, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D20569
      af31ad46
    • Nate Graham's avatar
      Use font: instead of font.pointSize: where possible · 93594f60
      Nate Graham authored
      Summary:
      Otherwise we're discarding style information possibly set in
      the user's small font choices when we want to set a smaller
      font.
      
      Test Plan: Stuff that's suposta look small still looks small
      
      Reviewers: cblack, #plasma
      
      Reviewed By: cblack, #plasma
      
      Subscribers: ahiemstra, apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29437
      93594f60
    • Eugene Popov's avatar
      Check if the clipboard is empty when initializing the status of the Clipboard applet · d228a44a
      Eugene Popov authored
      Summary:
      In D29652, I made an annoying mistake: I removed the check if the clipboard is empty when initializing the **Plasmoid.status** of the Clipboard applet. If the user enables the option to save clipboard content, then after restarting the Plasma, even if the clipboard had content, the state of the applet will be **PlasmaCore.Types.PassiveStatus** and its icon will be hidden in the system tray. This patch fixes this issue. I hope it will get into Plasma 5.19.
      
      See: https://phabricator.kde.org/D29652
      
      Reviewers: ngraham, mart
      
      Reviewed By: ngraham, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29818
      d228a44a
    • Kai Uwe Broulik's avatar
      [Notifications] Restore item spacing · 65633268
      Kai Uwe Broulik authored
      It got removed when the heading element was added.
      A negative margin is added below the heading since it has its own spacing.
      65633268
    • Nate Graham's avatar
      [applets] Show KCMs in System Settings or Info Center, as appropriate · e8c72744
      Nate Graham authored
      Summary:
      CCBUG: 417836
      
      Depends on D29711
      
      As this will depend on Frameworks 5.71, it will be landed on master after branching,
      ending up in Plasma 5.20.
      
      Test Plan:
      Right-click on applets and activate their configure menu items
      Open applets and click on their settings buttons
      Observe that the KCMs are opened in System Settings or Info Center
      (depending on the context)
      
      Reviewers: mart, #plasma
      
      Reviewed By: mart, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29712
      e8c72744
  8. 18 May, 2020 5 commits
    • Kai Uwe Broulik's avatar
      Merge branch 'Plasma/5.19' · d8114799
      Kai Uwe Broulik authored
      d8114799
    • Kai Uwe Broulik's avatar
      64794034
    • Kai Uwe Broulik's avatar
      [Notifications] Don't take updated time into account for sorting · d7118124
      Kai Uwe Broulik authored
      Notification spec says, when replacing a notification:
      
      > The server must atomically (ie with no flicker or other visual cues) replace the given notification with this one.
      
      Notifications shifting about is a "visual cue".
      
      Differential Revision: https://phabricator.kde.org/D29771
      d7118124
    • Ahmad Samir's avatar
      [IconApplet] Port KRun to ApplicationLauncherJob · e3b251fd
      Ahmad Samir authored
      Test Plan:
      Open the Application Launcher, right click any app -> Add to Panel (Widget),
      then click the icon on the panel, it should launch.
      
      Reviewers: #plasma, broulik, dfaure
      
      Reviewed By: dfaure
      
      Subscribers: dfaure, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29687
      e3b251fd
    • Kai Uwe Broulik's avatar
      [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too · 97e843d3
      Kai Uwe Broulik authored
      This refactors the free space notifier module to use a critical (i.e. persistent and always on top) notification for warning of low disk space.
      The, albeit blinking, tray icon is easy to miss, especially when you're running a full screen terminal, which I typically do while compiling stuff.
      It now also monitors the Root folder, if it's on a separate partition from the user's home. Furthermore, Filelight is offered to explore the drive (if installed).
      
      The overall warning logic remains pretty much the same:
      
      * Once the drive goes below the configured threshold a warning notification is shown, it stays on screen until dismissed by the user or
        when free space is above warning threshold again.
      * The notification is emitted again when free space drops below half the previous threshold, for added sense of urgency should the drive
        be rapidly filled up
      * The notification is also emitted again if free space remains below the threshold for more than one hour
      
      (It will only emit again when it was closed, obviously, so you won't end up with a tonne of popups after a few hours ;)
      
      I don't think this needs to be separately configurable for Home and Root, since the default threshold is like 200 MiB (it's not a configured
      percentage), so the absolute free space it warns about will be the same, even if your Home is giant compared to Root.
      
      BUG: 340582
      FIXED-IN: 5.20.0
      
      Differential Revision: https://phabricator.kde.org/D29770
      97e843d3
  9. 17 May, 2020 1 commit
  10. 15 May, 2020 4 commits