1. 12 Jan, 2020 2 commits
  2. 10 Jan, 2020 4 commits
    • Nate Graham's avatar
      [wallpapers/image] Disambiguate identical folder names in paths list · c3242c1d
      Nate Graham authored
      Summary:
      When multiple paths that end in the same folder name are added (for example with D26483),
      currently the list shows multiple identical entries distinguished only by their different
      tooltips. This patch improves the situation by putting the path to the folder in a
      subtitle.
      
      Test Plan:
      Before: {F7868784}
      
      After: {F7868785}
      
      Reviewers: #vdg, #plasma, mart
      
      Reviewed By: #vdg, #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26510
      c3242c1d
    • Nate Graham's avatar
      [wallpapers/image] Put spinbox labels inside the spinboxes · 276eac85
      Nate Graham authored
      Summary: They look a little nicer this way, and can be localized more easily.
      
      Test Plan:
      Before: {F7871094, size=full}
      After:{F7871093, size=full}
      
      Reviewers: #vdg, #plasma, mart
      
      Reviewed By: #vdg, #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26529
      276eac85
    • Nate Graham's avatar
      [wallpapers/image] Add placeholder labels when wallpaper lists are empty · b79f9967
      Nate Graham authored
      Summary:
      Right now, when there are no configured wallpaper slideshow paths or wallpapers in the
      slideshow, the list and grid (respectively) are just empty. This patch adds some
      placeholder labels to let the user know that it's not broken, just like we do in the
      Thunderbolt KCM.
      
      See one `FIXME:` in the code that I could use a hand with.
      
      Test Plan: {F7870947}
      
      Reviewers: #vdg, #plasma, mart
      
      Reviewed By: #vdg, #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26528
      b79f9967
    • Nate Graham's avatar
      [applets/digital-clock] Fix truncated Long Date display in a vertical panel · 02c89d74
      Nate Graham authored
      Summary:
      BUG: 381551
      FIXED-IN: 5.18.0
      
      Test Plan:
      Before: {F7851382, size=full}
      
      After: {F7851383, size=full}
      
      Texted extensively because this code is so brittle. No regressions with long date in a
      thick or normal-sized horizontal panel or short date in a thick or normal-sized
      horizontal or vertical panel.
      
      The one issue I could find is that sometimes switching between short and long date
      formats in a double-thickness vertical panel causes the long date  to be truncated again
      until plasmashell is restarted. I was unable to determine why. Assistance would be
      appreciated if this is a blocker.
      
      Reviewers: #plasma, #vdg, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: ndavis, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26312
      02c89d74
  3. 09 Jan, 2020 2 commits
    • David Edmundson's avatar
      [startkde] Drop hack to manually set XDG_DATA_DIRS to the install root · 3c1a34a2
      David Edmundson authored
      Summary:
      For normal distros it doesn't make sense, KDE_INSTALL_FULL_DATAROOTDIR
      will be /usr/.
      
      For devs using a prefix startplasma-dev.sh already does this for us only
      for the dev setup.
      
      For any other user, it should be their responsibility to adjust it.
      
      It's currently broken anyway, if a user simply installs flatpak that sets this env
      earlier in the boot, so this will do nothing. It implies no-oe relies on thisl
      
      It's a relic from 2007 (bd38d59e11548f160efd0918ca5461536ac72349) that doesn't
      make sense now.
      
      BUG: 315452
      
      Test Plan: Compiles
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26537
      3c1a34a2
    • Konrad Materka's avatar
      [SystemTray] Set maximum size to block tiling · 4a65dcef
      Konrad Materka authored
      Summary:
      System tray dialog/popup can be tiled. This should not be allowed, in this case expanded representaiton should have fixed size. When tiled, it is no longer possible to restore original size.
      This also applies to other plasmoids.
      
      BUG: 386551
      FIXED-IN: 5.18.0
      
      Test Plan:
      1. Open any applet from system tray (for example Clipboard or hidden items)
      2. Use shortcut to tile window (by default Meta + Left/Righ/...)
      3. Applet will change size and tile at the borded of the screen
      4. Expected:
      a) before fix: allowed and not possible to restore size
      b) after fix: not allowed or restores size on next open
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26545
      4a65dcef
  4. 08 Jan, 2020 4 commits
    • Konrad Materka's avatar
      [XembedSNIProxy] Hide container window when something shows it · 69786a1f
      Konrad Materka authored
      Summary:
      For each tray icon XEmbedSNIProxy is creating container window 32x32 in size. It is black with opaque set to 0 (fully transparent when compositor is enabled). All of these container windows are stacked below all windows, so normally you can't see them. On creation all container windows are created in top-left corner. When user clicks on the tray icon, container window is moved to the click location (to handle events correctly).
      On KWin restart all windows are shuffled, usually KWin is able to restore ordering correctly, but for some reason not it this case. As a result black/transparent container windows are stacked above all other windows and panels.
      To solve that, when container window is visible, XembedSNIProxy needs hide it again by stacking the container window below again.
      
      BUG: 357443
      FIXED-IN: 5.18.0
      
      Test Plan:
      1. Run any application with XEmbed system tray icon, do not click on the icon
      2. Restart KWin
      3. [Optional] Disable compositor - with disable container window is black and easier to spot
      4. Expected:
      a) before fix: black/transparent rectangle in the top-left corner, reacts to mouse click
      b) after fix: no rectangle, mouse clicks work as expected.
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson
      
      Reviewed By: #plasma_workspaces, #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26395
      69786a1f
    • Kevin Ottens's avatar
      Port the translations module to ManagedConfigModule · 34216709
      Kevin Ottens authored
      Reviewers: #plasma, mart, davidedmundson, crossi, bport
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26242
      34216709
    • Kevin Ottens's avatar
      Remove Kirigami DelegateRecycler · 56529e7b
      Kevin Ottens authored
      Summary:
      This is not really needed here due to the size of the delegates and of
      the list which is generally short. I ended up getting rid of it because
      it makes this config module crash somewhere in the QML runtime when the
      user clicks reset. I couldn't track down why DelegateRecycler does this
      so far.
      
      Reviewers: #plasma, mart, davidedmundson, crossi, bport
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26241
      56529e7b
    • Méven Car's avatar
      Kicker/RecentDocuments: add icons to actions · 4dca72bd
      Méven Car authored
      Test Plan: {F7857520}
      
      Reviewers: #plasma, ngraham, hein
      
      Reviewed By: #plasma, ngraham, hein
      
      Subscribers: hein, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26386
      4dca72bd
  5. 07 Jan, 2020 3 commits
  6. 06 Jan, 2020 6 commits
  7. 05 Jan, 2020 4 commits
  8. 03 Jan, 2020 2 commits
  9. 02 Jan, 2020 2 commits
  10. 31 Dec, 2019 1 commit
    • Aleix Pol Gonzalez's avatar
      battery: Improve the brightness responsiveness · 62be85f4
      Aleix Pol Gonzalez authored
      Summary:
      Use QQC2.Slider, so that we have a moved signal. This way we can only
      issue new brightnesses when the user actually interacts with it.
      Don't adapt to the system brightness until we have finished interacting
      with it.
      
      Test Plan:
      Manual testing, flickering is very much reduced both when scrolling over the
      compact plasmoid as well as the slider.
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26035
      62be85f4
  11. 30 Dec, 2019 6 commits
  12. 29 Dec, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Only serialize window pixmap if we're using it · b49d5cfd
      Kai Uwe Broulik authored
      The previous QIcon::name() check wasn't sufficient as it only works with theme icon names (e.g. kate)
      but not icons created from an absolute path, e.g. /some/special/icon/location/kate.png.
      The latter is usually the case for containerized apps which have a proper application desktop file
      installed but their icon in some path within the application image or some container daemon location.
      Since we already store the information for whether we had to fall back to using the actual window pixmap,
      check for this before trying to serialize icon pixmap data.
      
      Differential Revision: https://phabricator.kde.org/D25762
      b49d5cfd
  13. 28 Dec, 2019 2 commits
  14. 25 Dec, 2019 1 commit