1. 16 Oct, 2020 6 commits
    • Nate Graham's avatar
      [applets/systemtray] Fix icon size for 24px panels · afd1b432
      Nate Graham authored
      We were using a > when we should have been using a >=, so there was one
      panel thickness that would make icons be too large for their panel and
      get squeezed together uncomfortably.
      
      BUG: 427690
      FIXED-IN: 5.20.1
      afd1b432
    • Heiko Becker's avatar
      Make Prison a required dependency · 63f1b860
      Heiko Becker authored
      7bd9bea0 started using Prison
      unconditionally via QML import. So if Prison isn't installed the
      clipboard applet stops working, complaining that "org.kde.prison is
      not installed".
      While it would certainly be possible to add another call to
      "find_package(KF5Prison)" with TYPE RUNTIME, the result in
      feature_summary would be very confusing, because OPTIONAL has a higher
      priority and the runtime hint would vanish if you build with e.g.
      -DCMAKE_DISABLE_FIND_PACKAGE_KF5Prison=TRUE.
      63f1b860
    • Kai Uwe Broulik's avatar
      [Kicker] Show frequently used system settings modules for System Settings · b79f44f4
      Kai Uwe Broulik authored
      For System Settings the frequently used settings modules are shown in the same way
      they are done on System Settings home page.
      
      The default set is taken from its jump list actions when there aren't enough (5)
      frequent entries yet. This matches System Settings behavior, too.
      b79f44f4
    • Alexander Lohnau's avatar
      Close KRunner if query is empty and enter is pressed · 879b2b38
      Alexander Lohnau authored
      FEATURE: 211225
      FIXED-IN: 5.21
      879b2b38
    • Nate Graham's avatar
      [notifications] Fix margins of close button timeout indicator · 07992bc4
      Nate Graham authored
      The previous calculation multiplied the DPR by `units.smallSpacing`, which was not correct; we wanted DPR added to the existing margin, not multiplied by it.
      
      Also using Math.floor is safer since Math.round sometimes rounds up (e.g. in case DPR is 2.501) which can cause undesirable effects.
      
      BUG: 425911
      07992bc4
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 1917ebdb
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      1917ebdb
  2. 15 Oct, 2020 5 commits
  3. 14 Oct, 2020 3 commits
    • Gabriel Souza Franco's avatar
      [systemd] Fix start-condition helper · 808aaafc
      Gabriel Souza Franco authored
      Systemd passes the condition as `--condition <cond>`, not as a positional argument.
      Also switch around return codes, 255 is special-cased to mean that the unit has failed.
      808aaafc
    • Nate Graham's avatar
      [applets/mediacontroller] Improve bottom margin in new layout · 4fd910bb
      Nate Graham authored
      The player buttons looked a bit too close to the footer to my eye. This
      commit adds some more whitespace under them to match the whitespace
      above them.
      4fd910bb
    • Kai Uwe Broulik's avatar
      [Notifications] Also check transient parent for whether it's a dialog · bc12c6ca
      Kai Uwe Broulik authored
      In case a context menu is opened, we want to check the dialog it came from.
      This fixes the case of notifications dancing around when opening a context menu in
      System Tray but does not fix the case when opening a context menu in the notification
      itself since there it cannot know that the still open System Tray popup is the one
      we should evade and not the popup with the menu in it.
      
      CCBUG: 426187
      bc12c6ca
  4. 12 Oct, 2020 5 commits
  5. 11 Oct, 2020 3 commits
  6. 10 Oct, 2020 2 commits
  7. 09 Oct, 2020 7 commits
  8. 08 Oct, 2020 7 commits
  9. 07 Oct, 2020 2 commits
    • Eike Hein's avatar
      [kicker] Don't add invalid actions to the system action model · fcdbbda3
      Eike Hein authored
      The system actions model recently changed behavior to always present all
      possible actions, with `AbstractEntry::isValid` driving the model role
      `Kicker::DisabledRole` so that views can e.g. grey out unavailable
      actions.
      
      This was perceived as a regression by users who are annoyed at e.g.
      `Hibernate` being visible when their system setup precludes it more or
      less permanently.
      
      This patch reverts this behavior.
      
      Note that the dynamic approach we had permanently wasn't very great
      anyway, as the associated favorites models would remove entries when
      they became invalid, and they wouldn't come back automatically when the
      entry were to become valid again. In effect that means when you added one
      of these actions to e.g. the Kicker sidebar and it became unavailable
      it would disappear until re-added anyways.
      
      I can imagine use cases where dynamic behavior would be useful to have -
      let's say disabling Shutdown/Reboot while a critical system update is
      being performed. But in that case we'd need to fix the favorites
      behavior and add some way to inform the user why the action is disabled
      for a good user experienced anyhow.
      
      BUG:426645
      fcdbbda3
    • Alexander Lohnau's avatar
      Implement Pin feature for KRunner · 0004a1f8
      Alexander Lohnau authored
      BUG: 353026
      FIXED-IN: 5.21
      
      For this the close button has been replaced with a checkable button which pins the window. Just like in the system tray.
      0004a1f8