GitLab

We were using a > when we should have been using a >=, so there was one
panel thickness that would make icons be too large for their panel and
get squeezed together uncomfortably.

BUG: 427690
FIXED-IN: 5.20.1

7bd9bea0 started using Prison
unconditionally via QML import. So if Prison isn't installed the
clipboard applet stops working, complaining that "org.kde.prison is
not installed".
While it would certainly be possible to add another call to
"find_package(KF5Prison)" with TYPE RUNTIME, the result in
feature_summary would be very confusing, because OPTIONAL has a higher
priority and the runtime hint would vanish if you build with e.g.
-DCMAKE_DISABLE_FIND_PACKAGE_KF5Prison=TRUE.

For System Settings the frequently used settings modules are shown in the same way
they are done on System Settings home page.

The default set is taken from its jump list actions when there aren't enough (5)
frequent entries yet. This matches System Settings behavior, too.

Alexander Lohnau authored Oct 14, 2020 and Nate Graham committed Oct 16, 2020

FEATURE: 211225
FIXED-IN: 5.21

The previous calculation multiplied the DPR by `units.smallSpacing`, which was not correct; we wanted DPR added to the existing margin, not multiplied by it.

Also using Math.floor is safer since Math.round sometimes rounds up (e.g. in case DPR is 2.501) which can cause undesirable effects.

BUG: 425911

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

We already find KCMs explicitly

Systemd passes the condition as `--condition <cond>`, not as a positional argument.
Also switch around return codes, 255 is special-cased to mean that the unit has failed.

The player buttons looked a bit too close to the footer to my eye. This
commit adds some more whitespace under them to match the whitespace
above them.

In case a context menu is opened, we want to check the dialog it came from.
This fixes the case of notifications dancing around when opening a context menu in
System Tray but does not fix the case when opening a context menu in the notification
itself since there it cannot know that the still open System Tray popup is the one
we should evade and not the popup with the menu in it.

CCBUG: 426187

Show the available players as an icon row of tabs instead of a
combobox. The player name is shown in a tooltip on hover.

It looks better and more consistent with other plasmoids,
but main rationale is to be able to expand it with
more media controls in a future

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This tested the old behaviour where kio_fonts used "fonts://", i.e. setting
the host part of the URL, this isn't the case anymore and just "fonts:/" is
used.

ACK'ed by dfaure:
frameworks/kio!127 (comment 117004)

FEATURE: 423003
FIXED-IN: 5.21

Ahmad Samir authored Oct 03, 2020 and David Faure committed Oct 10, 2020

If you navigate to "desktop:" (without a / at the end) then create a new
folder, you'll end up with "/home/user/DesktopNew Folder", that's because
the path part of the url is empty. Change the code to always add / to the
beginning of the path when needed.

Drive-by change: silence a compiler warning about an unused parameter.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

If no runners are explicitly specified the RunnerManager will read the enabled plugins from the krunnerrc file. This way enabled plugins are configurable and consistent with KRunner.

Read margins in the containment from the root panel file and use them to redirect click inside the panel

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The system actions model needs its own favorites model.

Accidentally removed in fcdbbda3.

BUG:427472

VDG's intention is to use Breeze Light for this Global Theme now to
align with the Breeze Evolution work (https://phabricator.kde.org/T10891).

Major refactoring of SystemTray logic, mainly around Applets/Plasmoids
lifecycle. It is now more event based.

BUG: 424230
FIXED-IN: 5.21.0

Only show it after a bit of querying (500ms), disable it as soon as the
query ends.

BUG: 426746

This caused a lot of CPU load, because the applets were listed and filtered for each letter typed. Now they are only listed when the match() method is called for the first time and reused for the rest of the match session.

DesktopView's constructor calls PlasmaQuick::ContainmentView(corona,
nullptr), to initialise the parent class. nullptr being the parent.

In this case it makes sense as QWindow's overload of setParent must be a
QWindow, but memory management has to happen somewhere.

The current code is broken as the course of events is:
 - we delete the containment
- an existing connect to containment deleted goes to
panelContainmentDestroyed
 - this updates m_panelViews and calls deleteLater
 - this deleteLater isn't run before other exit handlers

The system actions model recently changed behavior to always present all
possible actions, with `AbstractEntry::isValid` driving the model role
`Kicker::DisabledRole` so that views can e.g. grey out unavailable
actions.

This was perceived as a regression by users who are annoyed at e.g.
`Hibernate` being visible when their system setup precludes it more or
less permanently.

This patch reverts this behavior.

Note that the dynamic approach we had permanently wasn't very great
anyway, as the associated favorites models would remove entries when
they became invalid, and they wouldn't come back automatically when the
entry were to become valid again. In effect that means when you added one
of these actions to e.g. the Kicker sidebar and it became unavailable
it would disappear until re-added anyways.

I can imagine use cases where dynamic behavior would be useful to have -
let's say disabling Shutdown/Reboot while a critical system update is
being performed. But in that case we'd need to fix the favorites
behavior and add some way to inform the user why the action is disabled
for a good user experienced anyhow.

BUG:426645

BUG: 353026
FIXED-IN: 5.21

For this the close button has been replaced with a checkable button which pins the window. Just like in the system tray.