1. 16 Oct, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Fix icon size for 24px panels · afd1b432
      Nate Graham authored
      We were using a > when we should have been using a >=, so there was one
      panel thickness that would make icons be too large for their panel and
      get squeezed together uncomfortably.
      
      BUG: 427690
      FIXED-IN: 5.20.1
      afd1b432
  2. 08 Oct, 2020 1 commit
  3. 06 Oct, 2020 1 commit
  4. 02 Oct, 2020 1 commit
  5. 28 Sep, 2020 1 commit
  6. 25 Sep, 2020 1 commit
  7. 11 Aug, 2020 1 commit
  8. 07 Aug, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Return to pre-5.20 default panel icon arrangement · 394b0ca0
      Nate Graham authored
      After much much much VDG discussion, it turned out that we don't
      actually want to make the System Tray icons scale with the panel. We
      returned to that with 31c7ebe3, but one
      element remained: to make the icons automatically become a
      two/row/column layout for thick panels, as we had for Plasma 5.19 and
      earlier. This commit does that, and in the process simplifies the
      configuration UI to show only the two options that we decided make sense:
      
      1. Small icons that become two-row/column for thick panels
      2. Auto-sizing icons that match the size of other panel widgets
      
      Number one returns to being the default as it was before, and number two
      is available for people/themes that want all icons to match in size.
      394b0ca0
  9. 30 Jul, 2020 2 commits
  10. 29 Jul, 2020 2 commits
  11. 16 Jul, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Improve size options · 4db4eab5
      Nate Graham authored
      Currently in git master there are three options for Tray icon sizing/arrangement:
      1. Scale to fit + automatic number of rows/columns
      2. One auto-scaling row/column
      3. Two auto-scaling rows/columns
      
      After consultation with VDG folks and many discussions, we discovered that the
      latter two settings are kind of useless and are unlikely to satisfy anyone.
      Instead, what some people will actually want is a way to return to the pre-Plasma
      5.20 style, with one or two rows/columns of small-ish, fixed size icons.
      
      This commit changes those two options to provide exactly that, allowing people who
      don't like auto-scaling icons to return to the way their System Tray looked before
      Plasma 5.20, and can also be used for global themes which are trying to emulate
      Windows or Cinnamon, which have tray icons like this.
      4db4eab5
  12. 14 Jul, 2020 1 commit
  13. 09 Jul, 2020 1 commit
    • Nate Graham's avatar
      [System Tray] Auto-scale icons and expose setting for number of rows/columns · 55ae651a
      Nate Graham authored
      Before Plasma 5.20, the system tray icons were always 22px in size and became
      multi-row/multi column as the panel increased in thickness.
      
      So far in the Plasma 5.20 development cycle, we have exposed the existing
      `iconSize` setting to the user to allow them to determine for themselves how
      big they want the icon to be, or whether to be multi-row/column.
      
      However this is not exposed very intuitively, as you have to already know that
      the icon size determines the number of rows/columns, or that the largest "Enormous"
      size produces an auto-scaling icon behavior. In other words, the UI reflects the
      implementation, rather than the user's expectation.
      
      This commit changes around the UI to more closely approximate what the user is
      likely to want to configure: the number of rows/columns. The new default setting
      is an "automatic" mode, which approximates the 5.19 and earlier behavior whereby
      the system tray switches to a two-row/column view when the panel becomes thick
      enough. In addition, users can now force it to always display one or two rows/
      columns.
      
      A major difference is that no matter which setting is set, icons now always
      expand to fill the available space, which brings them in line with the margins
      used for other Panel widgets.
      55ae651a
  14. 16 Jun, 2020 1 commit
  15. 15 Jun, 2020 1 commit
    • Michail Vourlakos's avatar
      systemtray items respect Fitt's Law when in panel · fd78da89
      Michail Vourlakos authored
      --systemtray items are now using a rectangular form
      in order to specify their hit area. So they take into
      account the panel thickness in order to calculate
      properly their cell length and thickness to
      respect Fitt's Law. Items that are nearer to the
      screen edge can now trigger all their events when
      the user uses its mouse at the farest of the screen edge.
      fd78da89
  16. 10 Jun, 2020 1 commit
    • Nate Graham's avatar
      [applets/systemtray] Use a grid for the hidden items view · 1669197b
      Nate Graham authored
      This improves the applet in a variety of ways:
      - Much more touch friendly than the current skinny list view
      - Many more items can be displayed without needing to scroll
      - Substantial code simplification
      - UI improvement from no longer sometimes showing an awkward vertical
        strip of icons that was invisibly scrollable but some of whose items
        ate scroll events, and which pushed the header over to the left in a
        somewhat random-looking way
      
      BUG: 402681
      FIXED-IN: 5.20
      1669197b
  17. 29 May, 2020 1 commit
    • Konrad Materka's avatar
      [applets/systemtray] Configurable maximum icon size · 161309cd
      Konrad Materka authored
      Add configuration UI for setting maximum icon size. This utilizes existing configuration parameter. It is a maximum allowed icon size, if panel is smaller, icon will fit to closest smaller size.
      
      BUG: 360333
      
      BUG: 355587
      
      FIXED-IN: 5.20.0
      161309cd
  18. 03 May, 2020 1 commit
  19. 01 May, 2020 1 commit
  20. 01 Apr, 2020 1 commit
  21. 31 Mar, 2020 1 commit
    • Eugene Popov's avatar
      [applets/clipboard]: Fix applet closing itself when clicking on a history item... · 17542416
      Eugene Popov authored
      [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open
      
      Summary:
      When I pin a Klipper widget and then click on a history item, the Klipper widget closes.
      
      To fix this bug, we need to check if Klipped is pinned, but to be able to do this, we also need to "forward" the pinned state from the SystemTray applet to the Klipper applet.
      
      BUG: 416510
      FIXED-IN: 5.19.0
      
      Reviewers: ngraham, #plasma
      
      Reviewed By: ngraham
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28408
      17542416
  22. 24 Mar, 2020 1 commit
    • Konrad Materka's avatar
      [applets/systemtray] Simplify icon size logic · a9d941b3
      Konrad Materka authored
      Summary: This change simplifies icon size logic - now it is controled only in one place: AbstractItem. This gives additional benefits, like icons perfectly centered.
      
      Test Plan: Highlights should always be centered
      
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, apol
      
      Reviewed By: #plasma_workspaces, #plasma, ngraham, broulik
      
      Subscribers: mart, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28109
      a9d941b3
  23. 10 Mar, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Fix item size for very narrow panel · 85f646eb
      Konrad Materka authored
      Summary:
      For very narrow panel item size is too big (item + padding exceed panel size). This adds a check to not exceed panel size.
      Before:
      {F8167941}
      After:
      {F8167942}
      
      Test Plan:
      * Make panel very narrow - icons should fit into panel
      * Repeat for vertical/horizontal
      
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27958
      85f646eb
  24. 08 Mar, 2020 1 commit
    • Dominic Hayes's avatar
      Increase the size of system tray icon hitboxes on the System Tray Plasmoid · d1d76984
      Dominic Hayes authored
      Summary:
      Depends on D27465
      
      @ngraham recommended that I split up https://phabricator.kde.org/D27438 into three patches:
      
      1. The foundation code to get landed first so that the other two patches can be done as patches that change two separate lines instead of just one
      
      2. Tablet Mode increases tray icon spacing
      
      3. This patch - Increase tray icon spacing slightly on Non-Tablet Mode (half of the amount it increases by in Tablet Mode)
      
      This patch is for the third patch of the three recommended patches to split the original patch into, and makes the click areas for the System Tray Plasmoid slightly larger in normal Plasma.
      
      Test Plan:
      1. Install this patch to the System Tray Plasmoid
      
      BEFORE:
      {F8109485}
      
      AFTER:
      {F8109489}
      
      Reviewers: #vdg, niccolove, ngraham
      
      Reviewed By: #vdg, niccolove, ngraham
      
      Subscribers: kmaterka, gvgeo, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27466
      d1d76984
  25. 07 Mar, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Use unified data model everywhere · 39975673
      Konrad Materka authored
      Summary:
      Use the unified data model everywhere, not just in configuration. This simplifies UI code, separetes presentation from data.
      This requires the use of ListView and GridView.
      This change enables the implementation of more advanced sorting algorithms for systemtray items.
      
      Test Plan: Affects almost all areas of system tray.
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
      
      Reviewed By: #plasma_workspaces, #plasma, davidedmundson, ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26992
      39975673
  26. 29 Feb, 2020 1 commit
    • Dominic Hayes's avatar
      Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled · 9e0711ac
      Dominic Hayes authored
      Summary:
      @ngraham recommended that I split up https://phabricator.kde.org/D27438 into three patches:
      
      1. The foundation code to get landed first so that the other two patches can be done as patches that change two separate lines instead of just one
      
      2. Tablet Mode increases tray icon spacing
      
      3. Increase tray icon spacing slightly on Non-Tablet Mode (half of the amount it increases by in Tablet Mode)
      
      This patch integrates both patch 1 and 2 of what ngraham recommended to make system tray icon click areas larger when Kirigami's Tablet Mode setting is true than they normally are.
      
      Test Plan:
      1. Test that System Tray still works after these changes have been made
      
      2. Check that when Kirigami.Settings.tabletMode is enabled the system tray icon click areas become slightly larger in size
      
      Reviewers: ngraham, #vdg, #plasma, niccolove
      
      Reviewed By: ngraham, #vdg, niccolove
      
      Subscribers: davidre, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27465
      9e0711ac
  27. 06 Feb, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Bunch of fixes and improvements in QML · a79f80ed
      Konrad Materka authored
      Summary:
      Few unrelated fixes, bunched together:
      * move some code from main.qml to PlasmoidItem where it belongs
      * easier to understand item size calculation
      * where possible, replace parent.parent comparisons with a property in AbstractItem
      * get rid of marginHints
      * Qt 5.14 compatibility fix in configuration
      * formatting etc
      
      Test Plan: Everything should work as before, this is just refactoring.
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27085
      a79f80ed
  28. 15 Jan, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Rework system tray settings · e2bfeb16
      Konrad Materka authored
      Summary:
      Combines settings of SNI icons and plasmoids in one list. Ability to disable whole section is removed.
      
      Initial idea was proposed by Nicolas Fella (D22176).
      
      BUG: 360307
      FIXED-IN: 5.18.0
      
      {F7880936}
      
      Test Plan:
      1. Disable/enable plasmoids
      2. Set Shown/Hidden for plasmoid
      3. Set shortcut for plasmoid
      4. Previously hidden categories are shown
      5. Show all icons and revert
      6. Set Auto/Shown/Hidden for SNI icons
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, mart
      
      Reviewed By: #plasma_workspaces, #plasma, ngraham, mart
      
      Subscribers: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26586
      e2bfeb16
  29. 19 Sep, 2019 1 commit
    • Radek Hušek's avatar
      Use consistent ordering for System Tray items · 0df34cc3
      Radek Hušek authored
      Summary:
      @mart dislikes idea of manually ordering the systray (D11233, D11292) but prefers auto
      ordering instead. To make my opinion I hacked up this and started testing on myself.
      Current version breaks if two items have the same category and text (I guess this
      should not happen but...).
      
      Note that category order is more or less randomly chosen (I do believe someone else
      has an opinion what the correct order is).
      
      This is mutually exclusive with D11292.
      
      Reviewers: #vdg, #plasma, mart, ngraham
      
      Reviewed By: #vdg, #plasma, mart, ngraham
      
      Subscribers: kmaterka, ognarb, ngraham, wsdfhjxc, mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D11352
      0df34cc3
  30. 07 Jul, 2019 1 commit
  31. 20 May, 2019 1 commit
    • ivan tkachenko's avatar
      Fix system tray UI/UX & refactor · a73aa330
      ivan tkachenko authored
      Summary:
      System tray widget had the following UX problem:
      Icons are laid out in a Flow QML layout, using minimal amount of
      space, thus not filling the height/width of the task bar. In other
      words: user can only click directly on an icon, not over or under it.
      
      Consider the following scenario:
      
      Given icon size X and task bar of height 1.5 * X located at the bottom;
      User moves pointer down to the limit and tries to click the icon.
      Expected outcome: applet is activated.
      Actual outcome: nothing happens, because icon (together with mouse
      area) floats slightly above the bottom.
      
      Which is inconvenient, especially when most other widgets tend to fill
      up the space.
      
      This patch fixes aforementioned problem by refactoring layouts using
      modern GridLayout, RowLayout et al., so that icons are arranged in
      rows and columns based on their number, and each one fills up its
      cell. I also made a handful of minor internal refactorings and fixes.
      Unfortunately, due to tight coupling, almost all files needed changes
      anyway.
      
      Special note on 'CompactApplet.location': it didn't seem to affect
      anything at all, so removed it.
      
      At the end of the day no visual changes should be noticeable. Layout
      works in both vertical and horizontal form-factor an all four sides of
      the desktop.
      
      Test Plan: Please, check whether 'LayoutMirroring' works properly.
      
      Reviewers: #vdg, #plasma, broulik, mart, hein, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19745
      a73aa330
  32. 20 Mar, 2019 1 commit
  33. 09 Mar, 2019 1 commit
  34. 14 Jan, 2019 1 commit
  35. 23 Feb, 2018 1 commit
    • Marco Martin's avatar
      parent full representation to the proper window at start · b17fa4be
      Marco Martin authored
      Summary:
      this avoids some unwanted scene changes and speeds up the
      first open a bit, also initialize the size of the dialog main item
      so there is a resize less when the Dialog is first shown
      
      Test Plan:
      difference in show time is already visible, tough still not perfect,
      something else needs to improve as well
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: apol, broulik, hein, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10692
      b17fa4be
  36. 13 Oct, 2017 1 commit
  37. 03 Mar, 2017 1 commit
    • Marco Martin's avatar
      [System Tray] Listen to external collapse · f8734328
      Marco Martin authored
      Summary:
      when the panel containment collapses all its applets,
      forward the event right to the internal systray and close the popup
      
      Test Plan:
      pinned systray correctly closes when opening a panel controller
      replaces D4842
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4865
      f8734328
  38. 08 Feb, 2017 1 commit