1. 30 Jan, 2018 1 commit
    • Marco Martin's avatar
      Fix iterator · b299d187
      Marco Martin authored
      Summary:
      removing favorites crashed, next() has to be called
      before accessing the item
      
      Test Plan: crash--
      
      Reviewers: #plasma, hein, ivan
      
      Reviewed By: #plasma, ivan
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10177
      b299d187
  2. 29 Jan, 2018 2 commits
  3. 22 Jan, 2018 2 commits
    • Eike Hein's avatar
      Merge branch 'Plasma/5.12' · 8de4fe74
      Eike Hein authored
      8de4fe74
    • Eike Hein's avatar
      Don't close plasmoid when closing a subdialog · cc2038fb
      Eike Hein authored
      Summary:
      This patch redoes the fencing mechanism around
      plasmoid.hideOnWindowDeactivate for window focus
      handovers to be more reliable and generic. It's now
      always disabled when a dialog is about to be
      destroyed, and renabled on focus-in or when exiting
      the root list. The dialog code is also fixed not
      to close the plasmoid when it knows it's window
      deactivation is part of its own destruction.
      
      WindowSystem::monitorWindowFocus is also changed
      to work in a single-shot sort of way, removing
      the event filter again once it caught an event.
      
      Fixes a refactoring regression from 84f1cb1c1.
      
      BUG:388669
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D9945
      cc2038fb
  4. 17 Jan, 2018 1 commit
    • Sergei Lopatin's avatar
      Show root items in kicker menu · fdd78e57
      Sergei Lopatin authored and Eike Hein's avatar Eike Hein committed
      Summary:
      BUG: 358291
      
      For some reason kicker appsmodel ignores root items (apps and separators). This patch added support for them.
      
      Reviewers: #plasma, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: davidedmundson, ngraham, hein, mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8816
      fdd78e57
  5. 02 Jan, 2018 2 commits
    • Eike Hein's avatar
      Merge branch 'Plasma/5.11' · f36f5b69
      Eike Hein authored
      f36f5b69
    • Eike Hein's avatar
      Don't show "Edit Application..." action for non-app services. · fcb86569
      Eike Hein authored
      Summary:
      When the code was refactored to show this action also for runner
      matches, proper care wasn't taken to test for this, so the action
      was shown for document matches as well. It's not safe to use for
      docs currently (which should probably be fixed in
      KPropertiesDialog) and at any rate isn't meant to be a generic
      editing feature as per the action name.
      
      BUG:388340
      
      Reviewers: #plasma, broulik, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D9612
      fcb86569
  6. 13 Nov, 2017 2 commits
    • David Edmundson's avatar
      Merge branch 'Plasma/5.11' · 5ae60536
      David Edmundson authored
      5ae60536
    • David Edmundson's avatar
      Fix crash in KAStatsFavouritesModel · 615f6ac1
      David Edmundson authored
      Summary:
      KAStatsFavouritesModel doesn't initialise a D-pointer for the lifespan
      of the KAStatsFavouritesModel, like the name implies.
      
      It is set in initForClient.
      
      If the activity changes before we have a client ID, there's no point
      doing anything and trying to use the clientID will crash.
      
      BUG: 386439
      
      Test Plan: None.
      
      Reviewers: #plasma, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: anthonyfieroni, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8608
      615f6ac1
  7. 02 Nov, 2017 2 commits
  8. 10 Oct, 2017 1 commit
    • Fabian Vogt's avatar
      Fix editing items in SimpleFavoritesModel · 065a0fcf
      Fabian Vogt authored
      Summary:
      tools.js is supposed to support both KaStatsFavoritesModel (used for
      favorite applications) and SimpleFavoritesModel (used for system actions,
      like poweroff/reboot/logout). The latter did not work though, as tools.js
      unconditionally calls methods only present in KaStatsFavoritesModel.
      This commit makes KaStatsFavoritesModel API compatible to SimpleFavoritesModel
      and changes the relevant code in tools.js to support both.
      
      Additionally, this syncs applets/kickoff/package/contents/code/tools.js again.
      
      BUG: 385463
      
      Test Plan:
      Before this patch it wasn't possible to remove system actions from
      the favorites bar.
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: hein, davidedmundson, rikmills, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8178
      065a0fcf
  9. 08 Sep, 2017 1 commit
    • Ivan Čukić's avatar
      Per-activity favorites (Final, again?) · c311339e
      Ivan Čukić authored
      Summary:
      The favourites are based on KAStats (already released version) **and kactivitymanagerd master (to be released with the next Plasma release)**. It allows favourites to be set to all activities, or the user can choose which activities to show a specific favourite application on.
      
      This change covers applications, files and contacts, other favourites are still based on the old model (now named SimpleFavoritesModel).
      
      {F1028047}
      
      Test Plan:
      Tested in Kicker, Dashboard and Kickoff the following:
      
      Transitioning mechanism:
      
       - load default favorites for the blank user
       - load custom default favorites set in the plasmoidsetupscripts script for Kicker
       - transition old results - when transitioning, merge the favourites from all launchers. The ordering for each launcher is kept separate (newly added items due to the merge go to the end)
      
      Favorite manipulation:
      
       - right-click add favorite to all activities
       - right-click remove favorite from all activities
       - right-click add favorite to specific activity (current)
       - right-click remove favorite from specific activity (current)
       - right-click add favorite to specific activity (not current)
       - right-click remove favorite from specific activity (not current)
       - right-click move from all to specific
       - right-click move from specific to all
       - right-click move from one activity to another
       - dnd reorder items in the model (up)
       - dnd reorder items in the model (down)
       - dnd add to favorites at a specific position
      
      Other:
       - launch the application
       - ordering persists after restart
       - ordering from the previous is kept on the activity that has no ordering
      
      Reviewers: mart, hein
      
      Reviewed By: hein
      
      Subscribers: Zren, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3805
      c311339e
  10. 31 Aug, 2017 1 commit
  11. 11 Aug, 2017 1 commit
  12. 24 Jul, 2017 1 commit
  13. 02 Jun, 2017 1 commit
  14. 25 May, 2017 2 commits
  15. 16 May, 2017 1 commit
  16. 06 May, 2017 1 commit
  17. 27 Apr, 2017 1 commit
  18. 18 Apr, 2017 1 commit
  19. 22 Feb, 2017 4 commits
  20. 21 Feb, 2017 2 commits
  21. 01 Feb, 2017 1 commit
  22. 30 Jan, 2017 2 commits
  23. 25 Jan, 2017 1 commit
  24. 23 Jan, 2017 3 commits
  25. 13 Jan, 2017 2 commits
  26. 09 Jan, 2017 1 commit
    • David Edmundson's avatar
      Return valid string value for DescriptionRole in all models · 0254bb3c
      David Edmundson authored
      Summary:
      A qml binding converting an empty QVariant to a string value will result
      in a warning:
      Unable to assign [undefined] to QString
      
      Which is apparently happening to this bug reporter, but not for other
      roles.
      
      Grepping all models shows 2 code paths where this could happen.
      
      BUG: 369783
      
      Test Plan:
      Kickoff/Kicker still open
      Couldn't reproduce the original bug.
      
      Reviewers: #plasma, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: hein, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4033
      0254bb3c