1. 21 May, 2020 1 commit
  2. 07 May, 2020 1 commit
    • Konrad Materka's avatar
      [applets/systemtray] Hide/show expander arrow - regression fix · b34e88da
      Konrad Materka authored
      Summary:
      Expander arrow should hide when all icons are visible and no icon is hidden. When dialog with hidden items is hidden ListView does not update its count property - property is update on redraw. As a result expander arrow is still visible/hidden until user clicks on any plasmoid to show dialog.
      
      BUG: 420924
      
      Test Plan:
      * select/deselect "Show all items" in settings, save, expander arrow should hide/show imidiatelly
      * select almost all items to "Always shown", leave "Keyboard indicator" as "Shown when relevant". Press Casp Lock, expander arrow should hide/show correctly
      
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
      
      Reviewed By: #plasma_workspaces, #plasma, broulik, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28180
      b34e88da
  3. 24 Mar, 2020 1 commit
    • Konrad Materka's avatar
      [applets/systemtray] Simplify icon size logic · a9d941b3
      Konrad Materka authored
      Summary: This change simplifies icon size logic - now it is controled only in one place: AbstractItem. This gives additional benefits, like icons perfectly centered.
      
      Test Plan: Highlights should always be centered
      
      Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, apol
      
      Reviewed By: #plasma_workspaces, #plasma, ngraham, broulik
      
      Subscribers: mart, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28109
      a9d941b3
  4. 07 Mar, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Use unified data model everywhere · 39975673
      Konrad Materka authored
      Summary:
      Use the unified data model everywhere, not just in configuration. This simplifies UI code, separetes presentation from data.
      This requires the use of ListView and GridView.
      This change enables the implementation of more advanced sorting algorithms for systemtray items.
      
      Test Plan: Affects almost all areas of system tray.
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
      
      Reviewed By: #plasma_workspaces, #plasma, davidedmundson, ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26992
      39975673
  5. 06 Feb, 2020 1 commit
    • Konrad Materka's avatar
      [SystemTray] Bunch of fixes and improvements in QML · a79f80ed
      Konrad Materka authored
      Summary:
      Few unrelated fixes, bunched together:
      * move some code from main.qml to PlasmoidItem where it belongs
      * easier to understand item size calculation
      * where possible, replace parent.parent comparisons with a property in AbstractItem
      * get rid of marginHints
      * Qt 5.14 compatibility fix in configuration
      * formatting etc
      
      Test Plan: Everything should work as before, this is just refactoring.
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27085
      a79f80ed
  6. 07 Jul, 2019 1 commit
  7. 20 May, 2019 1 commit
    • ivan tkachenko's avatar
      Fix system tray UI/UX & refactor · a73aa330
      ivan tkachenko authored
      Summary:
      System tray widget had the following UX problem:
      Icons are laid out in a Flow QML layout, using minimal amount of
      space, thus not filling the height/width of the task bar. In other
      words: user can only click directly on an icon, not over or under it.
      
      Consider the following scenario:
      
      Given icon size X and task bar of height 1.5 * X located at the bottom;
      User moves pointer down to the limit and tries to click the icon.
      Expected outcome: applet is activated.
      Actual outcome: nothing happens, because icon (together with mouse
      area) floats slightly above the bottom.
      
      Which is inconvenient, especially when most other widgets tend to fill
      up the space.
      
      This patch fixes aforementioned problem by refactoring layouts using
      modern GridLayout, RowLayout et al., so that icons are arranged in
      rows and columns based on their number, and each one fills up its
      cell. I also made a handful of minor internal refactorings and fixes.
      Unfortunately, due to tight coupling, almost all files needed changes
      anyway.
      
      Special note on 'CompactApplet.location': it didn't seem to affect
      anything at all, so removed it.
      
      At the end of the day no visual changes should be noticeable. Layout
      works in both vertical and horizontal form-factor an all four sides of
      the desktop.
      
      Test Plan: Please, check whether 'LayoutMirroring' works properly.
      
      Reviewers: #vdg, #plasma, broulik, mart, hein, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19745
      a73aa330
  8. 04 Nov, 2016 2 commits
    • Marco Martin's avatar
      fix behavior of scrollable systray popups · 95a8a620
      Marco Martin authored
      Summary:
      it's very rare that the icon list in the hidden area
      of the systray is long enough to get a scrollbar, but
      when it does it had a couple of issues:
      sometimes it gets an horizontal scrollbar too and
      the wheel events gets eaten:
      always disable the horizontal scrollbar and
      ignore wheel events over the label.
      wheel events over the icon are still managed by
      the applet (so still possible to for instance
      adjusting the volume on pa applet)
      
      BUG:372050
      
      Test Plan:
      hidden all the cions to enable scrollbar: wheel over
      the text scrolls the view, over the icon adjusts the volume
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3263
      95a8a620
    • Marco Martin's avatar
      fix behavior of scrollable systray popups · ae658c33
      Marco Martin authored
      Summary:
      it's very rare that the icon list in the hidden area
      of the systray is long enough to get a scrollbar, but
      when it does it had a couple of issues:
      sometimes it gets an horizontal scrollbar too and
      the wheel events gets eaten:
      always disable the horizontal scrollbar and
      ignore wheel events over the label.
      wheel events over the icon are still managed by
      the applet (so still possible to for instance
      adjusting the volume on pa applet)
      
      BUG:372050
      
      Test Plan:
      hidden all the cions to enable scrollbar: wheel over
      the text scrolls the view, over the icon adjusts the volume
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3263
      ae658c33
  9. 30 Mar, 2016 1 commit
    • Marco Martin's avatar
      bind directly stackBefore stackAfter · d1d1faef
      Marco Martin authored
      it's way simpler and more reliable than using it trough ObjectModel
      ObjectModel seems good enough if items are always owned by one
      but not when going back and forth between  2 models
      d1d1faef
  10. 29 Mar, 2016 1 commit