1. 13 Nov, 2017 1 commit
    • Eike Hein's avatar
      When used by QML, only populate after component is complete · b40c0de0
      Eike Hein authored
      Summary:
      This introduces the use of QQmlParserStatus to delay populating
      the model until all properties have been set, to avoid delegate
      churn.
      
      TasksModel is also meant to be used by C++. There's no good way
      to determine whether an object is being instanciated by QML
      during construction time, therefore this patch also introduces a
      delay in initial population of the model after construction via
      a single-shot timer. At the time the slot is invoked we know if
      we're used by QML (because QQmlParserStatus::classBegin has
      either been called or not by then) so we can decide to populate
      or wait more for QQmlParserStatus::componentComplete.
      
      I'm not super happy with this behavior change for C++ users,
      however as the model is usually used via QML currently, it's
      pragmatic to optimize performance for the common case, and it
      doesn't technically break QAbstractItemModel semantics, as model
      population isn't required to be sync.
      
      There's a decent change this fixes a recently-reported crash as a
      by-product:
      CCBUG:386630
      
      Reviewers: #plasma, davidedmundson, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8723
      b40c0de0
  2. 10 Nov, 2017 1 commit
  3. 09 Nov, 2017 2 commits
    • Xuetian Weng's avatar
      Merge branch 'Plasma/5.11' · be8f58ac
      Xuetian Weng authored
      be8f58ac
    • Xuetian Weng's avatar
      Preserve the order in dbus menu when doing action reusing. · 46aaa0e7
      Xuetian Weng authored
      Summary:
      Right now, new Action always appends to the list, but application may
      want to add new action in the middle of the menu. This breaks such
      application with dynamic menu entries. This change tries to keep the
      order of actions same as the order in dbus request.
      
      Test Plan: Manually tested the brokened menu in certain applications.
      
      Reviewers: #plasma, davidedmundson, broulik
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8585
      46aaa0e7
  4. 08 Nov, 2017 2 commits
  5. 07 Nov, 2017 1 commit
  6. 05 Nov, 2017 1 commit
    • Nathaniel Graham's avatar
      Change "Open..." to "Add Image..." in Wallpaper chooser · 1be6aecf
      Nathaniel Graham authored
      Summary:
      Changes the button in the wallpaper chooser marked "Open..." to say "Add Image..". This matches the text style for the button in slideshow mode, which says, "Add Folder"
      
      Also added ellipses to "Add Folder"; it's now "Add Folder..."
      
      Test Plan:
      Tested in KDE Neon.
      
      Before:
      {F5473479}
      
      After:
      {F5473507}
      
      Reviewers: #plasma, broulik, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: aspotashev, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8658
      1be6aecf
  7. 04 Nov, 2017 1 commit
  8. 02 Nov, 2017 5 commits
  9. 30 Oct, 2017 3 commits
  10. 29 Oct, 2017 2 commits
  11. 28 Oct, 2017 1 commit
  12. 27 Oct, 2017 1 commit
  13. 25 Oct, 2017 3 commits
    • Christoph Feck's avatar
      176eec0e
    • Алексей Шилин's avatar
      Align logout screen action buttons to the top · 3e495b22
      Алексей Шилин authored
      Reviewed by: davidedmundson
      
      BUG: 371249
      FIXED-IN: 5.11.2
      
      Differential Revision: https://phabricator.kde.org/D8397
      3e495b22
    • Bhushan Shah's avatar
      [batterymonitor] Fix brightness resetting to 1 on startup · 1c0f4179
      Bhushan Shah authored
      Summary:
      This was tricky bug to track down, needed to add debug statements in
      literally every functions.
      
      The flow of events is something like this, At startup:
      
      - We don't have information about actual brightness for few seconds
      - In this period, brightness slider have default value of 1
      - This triggers the function which sets batterymonitor.screenBrightness
      - onScreenBrightnessChanged gets called, which sets the actual
      brightness
      - onScreenBrightnessChanged have a guard for disableBrightnessUpdate but
      since we have it marked as false initially, we proceed to set actual
      brightness to 1
      - However before we set value of brightness to 1, we do get actual
      brightness back from dataengine, and our call overrides it to 1 later.
      - On desktop we do get 2nd dataChanged event from somewhere, so
      brightness is proper, but on mobile that is not case and results in
      brightness staying at 1.
      
      To fix this bug, we set disableBrightnessUpdate true at startup, and
      when there is actual brightness change from powerdevil or
      powermanagement engine, Logic.js takes care of enabling and disabling
      brightness change.
      
      (I quite like the boolean trap there in variable name :P .. will fix in
      another change in master)
      
      Test Plan:
      Tested on desktop and mobile, verified that
      
      - Brightness keys work
      - Brightness slider works
      - Scroll to change brightness works
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8462
      1c0f4179
  14. 24 Oct, 2017 10 commits
  15. 23 Oct, 2017 2 commits
  16. 18 Oct, 2017 3 commits
  17. 17 Oct, 2017 1 commit