1. 03 Jul, 2017 2 commits
    • Harald Sitter's avatar
      typo-- · b6130589
      Harald Sitter authored
      misspelling a variable does not help its usefulness
      b6130589
    • Marco Martin's avatar
      get rid of manual window flags setting on controller · 13aa418c
      Marco Martin authored
      Summary:
      with Qt 5.9, the panel controller can't get focus, so
      it can't be dismissed by clicking anywhere, (couldn't
      figure out what was the commit that caused the regression)
      removing the manual setting of flags seems to fix it,
      while the behavior seems unaltered with Qt 5.7 and 5.8
      
      Test Plan: tested on machines with Qt 5.7, 5.8 and 5.9 installed
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: mvourlakos, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D6403
      13aa418c
  2. 02 Jul, 2017 1 commit
  3. 01 Jul, 2017 1 commit
  4. 30 Jun, 2017 3 commits
  5. 29 Jun, 2017 5 commits
  6. 28 Jun, 2017 1 commit
  7. 27 Jun, 2017 1 commit
  8. 26 Jun, 2017 2 commits
  9. 25 Jun, 2017 2 commits
  10. 23 Jun, 2017 4 commits
  11. 22 Jun, 2017 3 commits
  12. 21 Jun, 2017 2 commits
    • Marco Martin's avatar
      create shell surface only at the right moment · 4c2eb556
      Marco Martin authored
      Summary:
      make the behavior similar to Dialog
      create a plasmashell surface only when isVisible() as
      some expose events can arrive there too, and also not
      create the shell surface if the exposed surface is null
      
      Test Plan: krunner seems to be more reliable
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D6299
      4c2eb556
    • Marco Martin's avatar
      simplify positioning code · 415b6d81
      Marco Martin authored
      Summary:
      drop most of the positioning code, drop the animation of the
      window position. position the popup in the signal handler of
      visibleChanged as we are sure there the size is final and the
      first expose event didn't arrive yet.
      at that point we are sure the size is the final and correct one
      
      the animation is supposed to be done by the morphingpopups effect
      instead.
      
      Test Plan:
      notification positions are always correct now, both on X11 and
      Wayland.
      Unfortunately on x11 the notification typ doesn't seem to pass,
      so they are correctly animated only in wayland
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: apol, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D6216
      415b6d81
  13. 20 Jun, 2017 5 commits
    • Harald Sitter's avatar
      Add a integration test suite and fix a signal connect bug when attaching reports · 295af397
      Harald Sitter authored
      Summary:
      - Fix radios' updating UI as they are toggling not buttonclicking :(
      - add a cmdline option to enable bringing up the dialog directly. in a testing scenario it makes sense to skip the notification popup thing and go directly to the dialog
      - new env var DRKONQI_KDE_BUGZILLA_URL to override the bugzilla url. for testing purposes we'll want to change the bugzilla url to point to a double instance but otherwise not impact functionality of drkonqi
      - new env var DRKONQI_IGNORE_QUALITY to bypass trace quality checks. during testing a proper trace may not be creatable, setting the env var allows bypassing the quality constraints
      - set a11y names on text inputs to facilitate a11y enablement (also allows finding them through at-spi for testing purposes ;))
      
      add an integration test based on xvfb+dbus+at-spi
      
      - suite wrapper program isolates the environment a bit,
        starts a xvfb instance and runs a session bus
        inside, then starts the actual tests from inside the isolated environment
      - duplicate_attach_test.rb starts an xmlrpc server, a defunct ruby, and
        a drkonqi to trace the defunct ruby. it then uses at-spi to massage the
        drkoknqi GUI into attaching a new trace to a bug via xmlrpc server.
      - the xmlrpc server partially falls through to bugstest.kde.org but mostly
        doubles for bugzilla
      
      fix a connect bug when attaching a new trace to an existing report
      
      Test Plan:
      `make test` should™ run the integration test assuming requirements are met (ruby+atspi+xmlrpc+xvfb-run).
      
      `XEPHYR=1 make test` will run the test through xephyr rather than xvfb, which is somewhat more useful for test writing and debugging.
      
      Reviewers: #plasma, mart
      
      Reviewed By: #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D6161
      295af397
    • Harald Sitter's avatar
      Merge branch 'Plasma/5.10' · 604b3ae3
      Harald Sitter authored
      604b3ae3
    • Harald Sitter's avatar
      Merge branch 'Plasma/5.8' into Plasma/5.10 · efac82ad
      Harald Sitter authored
      efac82ad
    • Harald Sitter's avatar
      fix attachment signals · 774a23fc
      Harald Sitter authored
      Signals did not get changed for Qt5 porting but no one ever noticed because
      they were still in stringy runtime eval syntax :S
      Using proper signals to connect to fixes attaching a new backtrace to
      an existing bug.
      Backport of fix from D6161.
      
      CHANGELOG: Make attaching backtraces to existing bug reports work
      774a23fc
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 3bc16492
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      3bc16492
  14. 19 Jun, 2017 1 commit
    • David Edmundson's avatar
      Make --test mode run without spawning kactivitymanagerd · 5bd54084
      David Edmundson authored
      Summary:
      This allows us to run the plasma-tests repo on your system without it
      destroying all your real activities. Even though one run tests in a
      nested
      dbus sessions, kactivities will still load and meddle with your real
      database
      at the same time as the real daemon is. That gets messy and broken.
      
      It also allows us to remove a hack in the plasma-tests script.
      
      Test Plan:
      Ran normal plasma, everything is the same.
      Ran plasma-tests everything there now works properly
      
      Reviewers: #plasma, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D6133
      5bd54084
  15. 18 Jun, 2017 2 commits
  16. 17 Jun, 2017 2 commits
  17. 14 Jun, 2017 2 commits
  18. 13 Jun, 2017 1 commit