GitLab

misspelling a variable does not help its usefulness

Summary:
with Qt 5.9, the panel controller can't get focus, so
it can't be dismissed by clicking anywhere, (couldn't
figure out what was the commit that caused the regression)
removing the manual setting of flags seems to fix it,
while the behavior seems unaltered with Qt 5.7 and 5.8

Test Plan: tested on machines with Qt 5.7, 5.8 and 5.9 installed

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: mvourlakos, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6403

Otherwise plasmashell doesn't start on login due to it being ignored
from autostart.

CCMAIL: plasma-devel@kde.org

Summary:
When clicking the hide button provided by the virtual keyboard, the
keyboard hides, but the state is not updated. This means the animation
for hide is not triggered and even more important the next call to
showHide sets a wrong state. The state assumes it is in visible, when
clicking it goes to hidden. So the virtual keyboard is not getting shown
when clicking the show virtual keyboard button.

To address this problem a change handler for keyboardActive is added
which ensures the state is correct whenever the keyboardActive value
changes.

BUG: 381833
FIXED-IN: 5.10.4

Reviewers: #plasma, sitter

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6456

This allows to open the location of the folder the wallpaper is in.

BUG: 371247
FIXED-IN: 5.11.0

Differential Revision: https://phabricator.kde.org/D6450

This will have it show the actual application name instead of the description.

BUG: 358423
FIXED-IN: 5.11.0

CHANGELOG: Application launcher mouse action can now be configured to show application names instead of their description

Differential Revision: https://phabricator.kde.org/D6441

can contain spaces which would not be properly handled as we pass a
composite string through `Kernel.system` which in turn will `sh -c` it

Test Plan:
Opened config window. Saw icons
Checked autostart still worked with the Hidden=true entry

Reviewers: #plasma, graesslin

Reviewed By: #plasma, graesslin

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6400

Summary:
Let's also move the applet pointer to right before it's used and
remove duplicated declarations.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6424

GIT_SILENT

The structure was only freed in case the XTest method was chosen.
But it should always be freed of course (as long as it isn't NULL).

Use a QScopedPointer instead to free it automatically when it goes out
of scope and to be more consistent with the rest of t

Differential Revision: https://phabricator.kde.org/D6389

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Also better sanity-checking of found services being app services
all around.

I'm not particularly happy about adding more X11 code outside of
XWindowTasksModel, but it means greater code reuse (in something that
has experienced unwelcome drift before) and there's a precedent in
LauncherTasksModel.

Reviewers: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6358

Summary:
Otherwise we:
* ... don't get startup notifications.
BUG:381500
* ... don't contribute data to recent/most used apps.

This is a surprisingly large oversight.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6354

Since Qt 5.8 for some reason the Connections {} on plasmoid.nativeInterface breaks.

BUG: 375535
FIXED-IN: 5.10.3

Differential Revision: https://phabricator.kde.org/D6335

Ensures that pressing e.g. Alt+F will popup the "File" menu.

BUG: 376726
FIXED-IN: 5.10.3

Differential Revision: https://phabricator.kde.org/D6336

Summary:
make the behavior similar to Dialog
create a plasmashell surface only when isVisible() as
some expose events can arrive there too, and also not
create the shell surface if the exposed surface is null

Test Plan: krunner seems to be more reliable

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6299

Summary:
drop most of the positioning code, drop the animation of the
window position. position the popup in the signal handler of
visibleChanged as we are sure there the size is final and the
first expose event didn't arrive yet.
at that point we are sure the size is the final and correct one

the animation is supposed to be done by the morphingpopups effect
instead.

Test Plan:
notification positions are always correct now, both on X11 and
Wayland.
Unfortunately on x11 the notification typ doesn't seem to pass,
so they are correctly animated only in wayland

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: apol, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6216

Summary:
- Fix radios' updating UI as they are toggling not buttonclicking :(
- add a cmdline option to enable bringing up the dialog directly. in a testing scenario it makes sense to skip the notification popup thing and go directly to the dialog
- new env var DRKONQI_KDE_BUGZILLA_URL to override the bugzilla url. for testing purposes we'll want to change the bugzilla url to point to a double instance but otherwise not impact functionality of drkonqi
- new env var DRKONQI_IGNORE_QUALITY to bypass trace quality checks. during testing a proper trace may not be creatable, setting the env var allows bypassing the quality constraints
- set a11y names on text inputs to facilitate a11y enablement (also allows finding them through at-spi for testing purposes ;))

add an integration test based on xvfb+dbus+at-spi

- suite wrapper program isolates the environment a bit,
  starts a xvfb instance and runs a session bus
  inside, then starts the actual tests from inside the isolated environment
- duplicate_attach_test.rb starts an xmlrpc server, a defunct ruby, and
  a drkonqi to trace the defunct ruby. it then uses at-spi to massage the
  drkoknqi GUI into attaching a new trace to a bug via xmlrpc server.
- the xmlrpc server partially falls through to bugstest.kde.org but mostly
  doubles for bugzilla

fix a connect bug when attaching a new trace to an existing report

Test Plan:
`make test` should™ run the integration test assuming requirements are met (ruby+atspi+xmlrpc+xvfb-run).

`XEPHYR=1 make test` will run the test through xephyr rather than xvfb, which is somewhat more useful for test writing and debugging.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6161

Signals did not get changed for Qt5 porting but no one ever noticed because
they were still in stringy runtime eval syntax :S
Using proper signals to connect to fixes attaching a new backtrace to
an existing bug.
Backport of fix from D6161.

CHANGELOG: Make attaching backtraces to existing bug reports work

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
This allows us to run the plasma-tests repo on your system without it
destroying all your real activities. Even though one run tests in a
nested
dbus sessions, kactivities will still load and meddle with your real
database
at the same time as the real daemon is. That gets messy and broken.

It also allows us to remove a hack in the plasma-tests script.

Test Plan:
Ran normal plasma, everything is the same.
Ran plasma-tests everything there now works properly

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6133

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Check the return value of xcb_get_window_attributes_reply() to prevent a crash if getting the window attributes would fail for some reason.

Also free the returned structure after usage to avoid memleaks.
This is necessary according to https://xcb.freedesktop.org/windowcontextandmanipulation (see the end of the page).

Differential Revision: https://phabricator.kde.org/D6252

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT