GitLab

This broke showing the inhibitions list. Will find a better way.

This reverts commit ce6a0ec0.

You can't anchor to items that aren't the parent or sibling.

It got removed when the heading element was added.
A negative margin is added below the heading since it has its own spacing.

Notification spec says, when replacing a notification:

> The server must atomically (ie with no flicker or other visual cues) replace the given notification with this one.

Notifications shifting about is a "visual cue".

Differential Revision: https://phabricator.kde.org/D29771

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Fixes regression caused by me meddling with data in 6e660cf9
Unfortunately KRunner has no notion of "this is application xyz" so Kicker has to make assumptions, which broke here.

Differential Revision: https://phabricator.kde.org/D29744

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Even when the vendor logo is turned off it can be briefly seen when the login screen changes from the fadeout state back into normal.

Comments in other code say that "OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)" so this patch replaces it with NumberAnimation.

There's also a minor fix included - placing the drop shadow sooner in the hierarchy because it should be drawn underneath an object, not in front of it.

Test Plan:
Reduce the fadeout time to something small and then:

`sddm-greeter --test-mode --theme /usr/share/sddm/themes/breeze`

Reviewers: ngraham, cblack, #plasma, mart

Reviewed By: ngraham, #plasma, mart

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29351

Summary:
Duplicate function calls to load the config in the runner/config have been removed.
The actions of the runner are also refactored, similar to https://phabricator.kde.org/D3688.
Also the user (owner of process) has been removed from the subtext, because the second line is not shown and adding the user info to the same line would be too long.

Test Plan: Should compile and kill processes as before.

Reviewers: davidedmundson, ngraham, broulik, meven, apol

Reviewed By: meven

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27513

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

See D29692

It only had a return value for "NoCharge" since the else case was only for not plugged in, resulting in it effectively returning undefined,
throwing during assignment "cannot assign [undefined] to string" and leaving whatever text happened to be shown last.

BUG: 420920

Differential Revision: https://phabricator.kde.org/D29633

WatchedNotificationsModel is a unstable API and does not provide any
API/ABI gurantee, look and feel developers or application developers
should not use this API for time being.

Summary: This fixes some wrong alignments

Test Plan:
After:
{F8305161}
{F8305164}
{F8305166}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ndavis, abetts, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29570

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Eugene Popov authored May 11, 2020 and Nate Graham committed May 11, 2020

[applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

Summary:
When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself.

BUG: 421344

Reviewers: ngraham, plasma-devel, broulik

Reviewed By: ngraham, broulik

Subscribers: broulik

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29651

Summary:
If status is set to NeedsAttention it tries to use Attention Icon. If Attention Icon is not set, empty/null QIcon is set. QML can't check if QIcon is null or not, as a result it tries to use empty icon and nothing is rendered.
Set null QVariant if AttentionIcon is not valid so that QML check will work correctly.

Test Plan:
* Set NeedsAttention as a status and with no Attention Icon
* Base Icon should render correctly

Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, mart

Reviewed By: #plasma_workspaces, #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29544

CCBUG: 420934

Ref T12778

Summary: Otherwise the build fails when things try to link to KF5::SysGuard etc.

Test Plan: Builds again

Reviewers: #plasma, meven

Reviewed By: meven

Subscribers: meven, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29628

Summary:
Allows to set Icon, AttentionIcon and OverlayIcon either by name or pixmap.
Makes it easier to test combinations of those.

Reviewers: kmaterka, apol

Reviewed By: kmaterka, apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29619

Summary:
Those plasmoids are intended to replace the old systemmonitor plasmoids
They are based upon the new ksysguard daemon: see D28333 and D28141

It has pluggable presets and sensor "faces" which are available from the KDE store

Every preset is available as a separate plasmoid.
By default are installed ones to replace
roughly one by one the existing systemmonitor plasmoids so systems that use it
will get the new ones in the updates

Depends on D28922

Test Plan: {F8209642}

Reviewers: #plasma

Subscribers: alexde, ngraham, davidedmundson, mmustac, ahiemstra, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28487

Summary:
Warnings such as:
```
CMake Warning at /usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:37 (me
ssage):
  The KF5:: namespace for KSysGuard targets is deprecated.  Please use
   KSysGuard as namespace.
 Call Stack (most recent call first):
   /usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package)
   CMakeLists.txt:55 (find_package)
```

Test Plan: cmake does not output those warnings

Reviewers: #plasma, ahiemstra, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29623

Summary:
as we can't kill completely kcmshell just yet, hack intothe services runner to
replace on the fly the exec line of the service to systemsettings

BUG: 402790
FIXED-IN: 5.19.0

Test Plan:
search and launch directly for a module, systemsettings is launched wit hthe
proper module loaded

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: broulik, ngraham, davidre, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29157

Fix in the f2e34dbb got partially reverted by introduction
of AbstractNotificationsModel in 2357e6f2.

Summary: This allows one to subscribe to notifications from notification server.

Test Plan:
tested using very simple QML

```
import QtQuick 2.0
import org.kde.notificationmanager 1.1 as Notifications

...
Notifications.NotificationWatchedModel {
    id: model
}

```

Reviewers: #plasma, broulik, davidedmundson

Reviewed By: #plasma, broulik

Subscribers: nicolasfella, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28509

Summary:
The config keys/sorting enum have been moved to a new file, before this the runner included the header of the config class.
This patch originated from https://phabricator.kde.org/D27513, but it was requested to split it up into separate patches.

Test Plan: Should compile.

Reviewers: davidedmundson, ngraham, broulik, meven, apol

Reviewed By: meven

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27576

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Last bits needed for T12778.

CCBUG: 420934

Test Plan: {F8295118}

Reviewers: bugseforuns, #plasma, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T12778

Differential Revision: https://phabricator.kde.org/D29516

Summary:
Expander arrow should hide when all icons are visible and no icon is hidden. When dialog with hidden items is hidden ListView does not update its count property - property is update on redraw. As a result expander arrow is still visible/hidden until user clicks on any plasmoid to show dialog.

BUG: 420924

Test Plan:
* select/deselect "Show all items" in settings, save, expander arrow should hide/show imidiatelly
* select almost all items to "Always shown", leave "Keyboard indicator" as "Shown when relevant". Press Casp Lock, expander arrow should hide/show correctly

Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson

Reviewed By: #plasma_workspaces, #plasma, broulik, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28180

Summary:
I probably introduced the issue fixed here with D29315, sorry. This patch makes the
parent layout invisible when all of its children are invisible, so it doesn't keep
taking up some vertical space after a previously-visible inhibition goes away.

Test Plan: When an inhibition goes away, it once again looks like it should: {F8288112}

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29467